Git Product home page Git Product logo

colorful-hearts's People

Contributors

terrails avatar theanaxman avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar

Forkers

theanaxman

colorful-hearts's Issues

loading ResourceLocation class early breaking mixins

https://github.com/Terrails/colorful-hearts/blob/86ca32195a683cb83fe58cadf3a75d4eaf19388b/fabric/src/main/java/terrails/colorfulhearts/fabric/FabMixinPlugin.java#L25C22
Loading your Logger reference here

will class load your main class,

public static final ResourceLocation SPRITE_NAME = new ResourceLocation(CColorfulHearts.MOD_ID, "colored_hearts");

which then loads ResourceLocation to set the static field. dont do this.

Mislabeled supported versions

Hello,

This mod is labeled as working on Game versions 1.19ā€”1.19.3 but it requires 1.19.3 to run.

"Failure message: Mod File colorfulhearts-forge-1.19.3-1.0.0.jar needs language provider javafml:44 or above to load"

is it possible to get a version for 1.19.2?

love, Molly

Eidolon:Repraised Compat issue

Whenever a wraith from Eidolon:Repraised hits you and applies chilled your hearts spilt into several lines of hearts.

Gui messed up

In survival mode and adventure mode (the two with hearts) the gui is shifted to a second smaller window like a pip. This dose not happen with the 4.0.1 and i believe it is related to line 78 MinecraftForge.EVENT_BUS.post(new RenderGuiOverlayEvent.Post(event.getWindow(), event.getGuiGraphics(), event.getPartialTick(), event.getOverlay()));

GUI overlay will be in top left corner however the mouse positions will be in the correct spots.

Mod not showing in game

hey there. im fairly new to mods in minecraft and curseforge. im installed the coolourful hearts and its in my mod folder but its not showing in game. Im not sure what im doing wrong. i have farmers delight croptopia and journey map installed too
thankyou
kylie bree

AppleSkin compatibility

AppleSkin currently renders extra hearts by flashing the vanilla colors. Support should be added by a mixin to overwrite the texture it uses for rendering. Possible issues with implementing this is the heart pre-calculation which I am slightly leaning towards removing and rendering hearts the vanilla way without any pre-calculating.

This will be done when 1.20.2 version of AppleSkin releases and when I have time.

Letter N disappears from text

I added this mod to my personal custom modpack because in my personal server on Minecraft i have a lot of hearts (bc why not).
But I noticed a problem that kinda bugged me (pun not intended). Netherite is missing the letter N and my titles that I have for my PowerRanks plugin don't have the letter N.
When i turned off the mod, everything was fine.

Mod causes part of the ui to act like it's in a lower resolution.

2023-12-29_19 51 57
2023-12-29_19 53 26

Resolution is 4k, Minecraft is in windowed mode.

The inventory and pause screen from vanilla are constrained to the smaller resolution denoted by the Armour, Hunger, and XP bars.

The inventory screen from Traveler's Backpack is similarly constrained.

This is my modlist, exported from the Curseforge Launcher.
1.20.1.zip

AFAICT, everything works fine.

Minecraft is 1.20.1, Forge is 47.2.0

Color Wrapping Error

When you have enough health to use up every entry in a given list, the colors start again from the first entry. This is expected behavior, but what isn't expected is which two colors the wrap causing health bar assumes.

Given the 10 color values seen below (vanilla red hearts enabled)
image

This is what happens in the health bar after the wrap, visualised is the 11th row of health being overlayed by row 12's color in this case 13 hp worth. But since there are only 10 colors defined, it instead wraps back to color 1 and 2 respectively, which is what I observed below working as intended.
image

What about rows 10-11? What I expected to happen is as before, full health on row 10's Maroon means it gets overlayed by row 11's aka row 1's Red, right?
image

But instead, this happens, red (color1) overlayed by orange (color2), which mind you occurs when you run out of row 11 health, meaning ingame it looks like your row 12 health glitches back to full after losing it all. Losing the miscolored row 10-11 row hp then skips to the correct 9-10 row hp
image

image

This bug occurs on a color list of any size, and is most noticable on the default lists of damaging status effects; Poison, Wither, and Freezing. As those lists are only 2 entries long, having any more than 40 max health will cause each full row lost to refill to color 2 when depleted until you reach the last 20 hp (10 Hearts)

image

Any chance of bringing back the Display mode config?

In health overlay you had a config option for displaying the health numerically. Any Chance of that coming back?
"display_mode": "OFF",
/* Text displayed next to health. Minecraft chat color codes are allowed.
Available variables:
"[HEALTH]": Current health.
"[MAX]": Max health.
"[HEARTS]": Current health in hearts.
"[MAX_HEARTS]": Max health in hearts.
"[ROW]": Current health row.
"[MAX_ROW]": Max health row.

Compatibility with Overflowing Bars

Doesn't change my hearts color with this mod installed, I tried changing the ID (Because I've read that Forge (And maybe Fabric too.) uses Alphabetical Order to arrange mods.) of your mod manually but I'm a complete potato with whatever we're supposed to do with the inside code so of course I've failed.

HeartRenderer does not provide DrawContext

As specified in the commit bae76d4, HeartRenderer does not use DrawContext. This is a problem, as adding compatibility for it forces the construction of our own DrawContext.

An example of this is the following Mixin snippet when porting Spectrum to 1.20:

	private void renderPlayerHeartsAzureDikeInjector(MatrixStack poseStack, PlayerEntity player, int x, int y, int maxHealth, int currentHealth, int displayHealth, int absorption, boolean renderHighlight, CallbackInfo ci) {
		InGameHud hud = MinecraftClient.getInstance().inGameHud;
		int scaledWidth = ((InGameHudAccessor) hud).getWidth();
		int scaledHeight = ((InGameHudAccessor) hud).getHeight();

                // Construct own DrawContext, as its not being passed. Loses data, and could produce undefined behavior or bugs
		DrawContext context = new DrawContext(MinecraftClient.getInstance(), MinecraftClient.getInstance().getBufferBuilders().getEntityVertexConsumers());
		context.getMatrices().multiplyPositionMatrix(poseStack.peek().getPositionMatrix());

                // Pass to our own API
		HudRenderers.renderAzureDike(context, scaledWidth, scaledHeight, player);
	}

preLaunch error on startup with some mods.

Version: 1.20.2.
Mod Version: 5.1.6.

Mods: Too lazy to list so here is a screenshot.
image

Issue:

Game crashes on startup with certain mods with error starting Could not execute entry points stage 'preLaunch'.
Going back to 5.1.5 does not crash but doesn't include the appleskin stuff. D:
It does not say all the mods the mixins are crashing with or whatever, but firstly it is with Capes mod to see capes from different mods, and then if I remove that it changes to Essentials.

Crash log:
Crash 2024.txt

Compatibility for Overflowing Bars By Fuzs ??

The mentioned mod does the same work as colorful hearts, but with only two colours and with an indicator for the amount of health/armor rows (2x for 20 hearts and so on).
The thing is, when both mods are together the (?x) count stops working for the health, could you maybe work on a config to allow the (x) count to work together with the heart colours from your mod?
In the image below you can see there is a (2x) indicating the armor rows, there should be one on the left side of the health bar as well, but it disappears when colorful hearts is in the modpack.
image

IĀ“m playing on forge 1.20.1
Thanks!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.