Git Product home page Git Product logo

Comments (7)

gunan avatar gunan commented on June 12, 2024

I think we include that, because we want to make sure to have the exact commit the devel image is built with. We had issues previously where the devel image was updated, and for a few days our users had quite a few issues to build TF.

from build.

bhack avatar bhack commented on June 12, 2024

I understand this and It could be also useful in other cases.
But as SIGs are advanced users I think we could have a source-less image on Dockerhub with almost the same layers (and so with a minimal push overhead).

from build.

bhack avatar bhack commented on June 12, 2024

As I think we will not have image unification quite soon on tensorflow/tensorflow#38352 this devel image sourceless variants could be a valid alternative as a base for SIG docker images.

from build.

bhack avatar bhack commented on June 12, 2024

Also as currently at some point we stated to not pushing anymore versioned devel images like this one I think that we could start again to publish that release format:

E.g for 2.2.0 release:

  • 2.2.0-devel-src-gpu
  • 2.2.0-devel-gpu
  • 2.2.0-devel-src
  • 2.2.0-devel

from build.

gunan avatar gunan commented on June 12, 2024

Unfortunately, any new tag we push brings nontrivial overheads for us.
So, we will need to weigh the options and get back on this.

from build.

lgeiger avatar lgeiger commented on June 12, 2024

@bhack Would using a shallow clone using --depth=1 to add the TensorFlow source code work for you?
This would reduce the size of the source code from 807MB down to 288MB which is still quite large, but won't add additional maintenance overhead.

from build.

bhack avatar bhack commented on June 12, 2024

It Is better then nothing but I think that It will not have so much overhead if the layers are 99% the same between the two images (as we have already the boolean flag).

It think also that having the checkout could be confusing if you work with IDE e.g. like vscode and remote container extension or GitHub codespaces (they are quite the same technology) cause the repo checkout is going to be mounted as volume inside the container.

Generally also if you want to develop on a specific remote setup on Kubernetes you will go to prepare the git clone in the init container to have a better control of your fork/branches.

from build.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.