Comments (7)
@mihaimaruseac I don't know if you could add something here for tensorflow/tensorflow#57468 (comment)
Sadly, I don't think we can do much here. The issue there was that an internal file with internal code also needed to be updated. Using copybara instead of the internal file would have been too cumbersome.
Though, I also think that this type of breakages is small. It should only occur when you are adding new defines.
from build.
P.s. NIT we Need to enforce:
tensorflow/tensorflow#56276 (comment)
P.s.s. the linking required many CPU cores at every iteration cause we had >50 targets to link (very resource intensive) for just running a single test after an edit. So we needed to do the linking in parallel with many core and with a speedup of LD Gold (#110).
Also I needed to keep the PR branch freezed without rebasing/merging for months cause a rebase will eventually invalidate the Bazel cache requiring a monster build time again.
This is another problem for PR that are open for weeks or months and you could need to rebase to solve conflicts.
from build.
We had also a quite tricky issue filtering single test on the development cycle.
You was already notifed at:
tensorflow/tensorflow@0f9af91
from build.
@mihaimaruseac I don't know if you could add something here for tensorflow/tensorflow#57468 (comment)
Thanks
from build.
I believe tensorflow/tensorflow@96b26a2 is a huge step in fixing this, fixing most (if not all) such issues.
from build.
@cheshire Thanks, do you have a full list of the currently enabled warnings as error in copybara related jobs?
from build.
I believe tensorflow/tensorflow@96b26a2 is a huge step in fixing this, fixing most (if not all) such issues.
We are still suppressing all the warnings:
https://github.com/tensorflow/tensorflow/blob/master/.bazelrc#L295-L301
# Suppress all C++ compiler warnings, otherwise build logs become 10s of MBs.
build:android --copt=-w
build:ios --copt=-w
build:linux --host_copt=-w
build:macos --copt=-w
build:windows --copt=/W0
build:windows --host_copt=/W0
With the mentioned commit we are just enabling the specific unused-result
but if we check this table that flag is one of the default error we have also with -Werror
.
So the point here is to understand what flags we have in the copybara builds as if we are using -Werror
there it has > 50 warning types.
from build.
Related Issues (20)
- Leave a commen(optional)
- Enhancement: Add signed SLSA attestations to nightly docker builds HOT 4
- Add the OpenSSF Scorecard Github Action
- T
- <spam>
- Fix Scorecard Github Action error
- latest-jupyter (2.11.1) - error: command 'x86_64-linux-gnu-gcc' failed: No such file or directory HOT 1
- Dashboard improvement ideas HOT 2
- https://github.com/tensorflow/build/blob/090ef48a7884d132092e52e11ded05467df82489/.github/ISSUE_TEMPLATE/plain-issue.md
- ML Machine Learning Data Engineer AI Artificial Intelligent
- Shared from Bing: Zeti: Najib spent at least RM1b of RM3.2b in his account with 1MDB funds HOT 1
- MeTAISmitHData Engineer AI ML
- Keyboard Indicator
- Unwanted Hackers Into Google Finance HOT 1
- ログイン - Google アカウント#Abues #Malware #Mallicious #Interrupted
- Missing tensorflow-rocm wheel with python 3.12
- CMake.exe error
- Tensorflow SIG
- make tutorial directory a variable (and don't run jupyter as root)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from build.