Not possible to use rescue_from in controller about telegram-bot HOT 6 CLOSED

I've found that it calls #request in ActionController::Rescue which is not available in bot controllers. Here is module i've tested, i'll add it to gem later:

  module Telegram::Bot::UpdatesController::Rescue
    extend ActiveSupport::Concern
    include ActiveSupport::Rescuable

    private

    def process_action(*args)
      super
    rescue Exception => exception
      rescue_with_handler(exception) || raise
    end
  end

from telegram-bot.

Does include ActionController::Rescue do the trick?

from telegram-bot.

Nope, if you include ActionController::Rescue, method rescue_from will be available, but will do nothing, exceptions will not be catched.

from telegram-bot.

Wonderful, thank you! I hope it will be included by default, just like in Rails=). Also, it's not a good idea to rescue from Exception, it's better to use StandardError https://robots.thoughtbot.com/rescue-standarderror-not-exception

from telegram-bot.

Added this feature in 45e8a72 I plan to release it in week or so.

I've decided to keep rescue Exception (similar to rails), as it does not restrict end-users and allows them to rescue_from AnyExceptionClass_EvenNotStandardError, ....

from telegram-bot.

Closing this one. Feel free to ping me to reopen :)

from telegram-bot.