tecnovert / particl-coldstakepool Goto Github PK

I'm in the process to setup a staking pool based on this implemention and tried re-syncing the stakepooldb from scratch in observer mode. After completion I switched back to master mode and at the next payout time it created a transaction, which failed because of unsufficent funds.

Reason was that the accumulatedAddr balance in the DB was not updated in processPayments during sync phase because of the sanity check "Warning: Pool height is below node height ...". The sanity check should be moved some lines down, right after the check for "master" mode so that the book keeping is done and just the actual payment transactions are skipped.

I modified the code this way and resyncing works fine now.

BTW: In findPayments: The code related to checking over payment does not look right:
if addrPending < 0:
logmt(self.fp, 'WARNING: txn %s overpays address %s more than pending payout, pending: %d, paid: %d.\n' % (txid, address, addrPending + v, v), True, True)
if addrReward + addrPending < 0:
logmt(self.fp, 'WARNING: txn %s overpays address %s more than accumulated reward %d, paid: %d.\n' % (txid, address, addrPending + v, v), True, True)
else:
addrReward += addrPending
addrPending = 0

addrReward is in unit COIN*COIN and addrPending is in unit COIN so we can't add them.

Hey everyone, I was investigating setting up a stakepool of my own but even looking at the https://github.com/tecnovert/particl-coldstakepool/tree/master/doc. It seems to lack information regarding the configuration file what various settings' does (some are obvious, others aren't so much) and so on as well of any "best practices". Such as (if it applies) what to be backing up, how it should be backed up, restoring/resuming a damaged pool (like if the VPS or hardware were to kick the bucket) and anything else that may be relevant. As far as configuring and maintaining a "live" pool.

Thanks very much in advance!