techgaun / zxcvbn-elixir Goto Github PK

Some of the matching have been done but rest are not.

Need to add tests.. copy over test data from zxcvbn dropbox repo

Need to make punctuation uniform in feedback. Found out there's an issue on dropbox/zxcvbn#248 as well

Fixing punctuation will require updating the test as well

Password was quite long.

 ** (ArithmeticError) bad argument in arithmetic expression: 6 * 4.83472340425532e307
 code: Core.Users.update_account_password(account, valid_account_password(), %{
 stacktrace:
   :erlang.*(6, 4.83472340425532e307)
   (zxcvbn 0.1.3) lib/zxcvbn/scoring.ex:440: ZXCVBN.Scoring.update/5
   (stdlib 5.2) maps.erl:416: :maps.fold_1/4
   (elixir 1.16.2) lib/enum.ex:2528: Enum."-reduce/3-lists^foldl/2-0-"/3
   (elixir 1.16.2) lib/enum.ex:4388: Enum.reduce_range/5
   (zxcvbn 0.1.3) lib/zxcvbn/scoring.ex:91: ZXCVBN.Scoring.most_guessable_match_sequence/3
   (zxcvbn 0.1.3) lib/zxcvbn.ex:96: ZXCVBN.zxcvbn/2

Hi there 👋!

It would be greatly appreciated if a new release could be cut that includes some of the dep updates that are in main (and selfishly also my PR to fix compilation warnings on newer versions of Elixir #22)

Readme is not as detailed right now. Need to provide detail on the result and interpretation of each parameters.

Often times, the password dictionary can be contextual such as demographics or countries. Would be nice to be able to specify custo list of dictionaries apart from what we have right now

Something to be done after initial release.
Eg. ZXCVBN.Matching.Sequence, ZXCVBN.Matching.Repeat, ZXCVBN.Matching.Regex and so on.

Thanks for releasing a new version.
It would be awesome if you could also please add an entry to the Changelog describing what was included in that new version.

There are parts of codes that would benefit from more Elixir style coding. This issue will serve as a ground for future PRs and commits for improving codebase quality

Let's collaborate?

This has been missing and needs to be there at some point.

Hi there. I'm looking to use a zxcvbn library on my elixir app so that the password strength metrics are the same as my client code (which is also using zxcvbn), and this project seems like the furthest along to implement zxcvbn in elixir.

Any updates on when this project might be production ready or if you need any help getting it there?