techend / mahonia Goto Github PK

I am checking for specs for ISO-2022-JP, But haven't figure out how to do it 
yet.

The RFC:

http://tools.ietf.org/html/rfc1468

And the Java implementation:

http://j6a.ru/_i_s_o2022___j_p_8java_source.html

Please add cpXXX (like: cp932 for sjis) on windows.
Most of unix people use it with utf-8. But on windows, we should convert cpXXX 
strings to utf-8 for go. I can get the cpXXX with fmt.Sprintf("cp%d", GetACP()) 
that using syscall.LoadDLL().

Thanks.

What steps will reproduce the problem?
d := EntityDecoder()
printf(d.ConvertString("≪⃒")

What is the expected output? 
≪⃒

What do you see instead?
≪

I try to decode a GB2312, got a panic error.

panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x0 pc=0x697f2]

goroutine 1 [running]:
runtime.panic(0x20b320, 0x570cd9)
    /Users/Hong/go/src/pkg/runtime/panic.c:266 +0xb6
code.google.com/p/mahonia.Decoder.ConvertString(0x0, 0xc210045460, 0xda, 
0xc210045460, 0xda)
    /Users/Hong/gocode/src/code.google.com/p/mahonia/convert_string.go:41 +0xd2
main.fetch(0xc21000af80, 0xc21000aef0, 0xc210045460, 0xda)


------------------------
GB2312 (1980) has been superseded by GBK and GB18030 ([2]). So I register the 
GB2312 charset in gbk.go file.
Now It's work fine for me.

 ~GOPATH/src/code.google.com/p/mahonia hg diff 
diff -r 420ce60cb671 gbk.go
--- a/gbk.go    Fri Jul 19 13:15:30 2013 -0700
+++ b/gbk.go    Mon Dec 09 22:27:42 2013 +0800
@@ -12,6 +12,15 @@
            return encodeGBKRune
        },
    })
+   RegisterCharset(&Charset{
+       Name: "GB2312",
+       NewDecoder: func() Decoder {
+           return decodeGBKRune
+       },
+       NewEncoder: func() Encoder {
+           return encodeGBKRune
+       },
+   })
 }

 func decodeGBKRune(p []byte) (r rune, size int, status Status) {



----------
[1]: http://en.wikipedia.org/wiki/GBK
[2]: http://en.wikipedia.org/wiki/GB2312

You can check the 'Examples' sections
http://golang.org/pkg/testing/#pkg-overview

I think it is better just write TestManonia.go.

So, users could just refer it in

http://godoc.org/code.google.com/p/mahonia