teamworksapp / influxdb_logging Goto Github PK

Shouldn't this

if indexed_keys is not None:
    self.indexed_keys += set(indexed_keys)

Be like this

if indexed_keys is not None:
    self.indexed_keys |= set(indexed_keys)

As this is a union of sets? I'm getting

TypeError: Unsupported operand type(s) for +=: 'set' and 'set'

when passing new indexed_keys.

Hello! I'm looking forward to giving this library a try. In the meantime I noticed a few issues that you might be interested in.

It seems like this package is released on PyPI (yay!), but I noticed the link back to the source here is out-of-date. It links to "influx-logging" but it seems like this has been renamed to "influxdb-logging" now. https://pypi.org/project/influx-logging/

It would be great if the release version numbers on PyPI showed up as tags here in the repo.

Also, it would be great if the README mentioned that this was on PyPI and what the library name is on PyPI. I.e., say something like "install this with pip install influxdb-logging" or w/e.

Thanks all! :)