Description
teamdraco / ravageandcabbage Goto Github PK
View Code? Open in Web Editor NEWLicense: GNU General Public License v3.0
ravageandcabbage's Introduction
ravageandcabbage's People
Contributors
Stargazers
Watchers
ravageandcabbage's Issues
Question: Do you accept Pull Requests ?
Hi there, just found your mod and find it very cool and interesting. Especially now that you're going to add Horn Armor.
I read a comment in the code in RCRavagerEntity.java "There must be a better way to do this" for applying armor to the Entity.
Indeed there is, and if you're ok with it I'll make a PR for it in the next 1-2days. Crafting recipes for horn armor is also missing as of now. I honestly have no clue what would be a fitting pattern. Maybe giving them as loot only is best. And make diamond upgradable to netherite in a smithing table ?!? Just ideas...
Hope to hearing from you soon, btw, sorry to spam your Issues with this question. Feel free to delete it if you don't like it.
Gold horn armor broken recipe
[04:29:39] [Render thread/ERROR]: Parsing error loading recipe ravageandcabbage:gold_horn_armor
com.google.gson.JsonSyntaxException: Unknown item 'ravageandcabbage:gold_horn_armor'
at net.minecraft.item.crafting.ShapedRecipe.func_222129_c(ShapedRecipe.java:262) ~[?:?]
at net.minecraft.item.crafting.ShapedRecipe$$Lambda$18262/1610197892.get(Unknown Source) ~[?:?]
at java.util.Optional.orElseThrow(Optional.java:290) ~[?:1.8.0_51]
at net.minecraft.item.crafting.ShapedRecipe.func_199798_a(ShapedRecipe.java:261) ~[?:?]
at net.minecraft.item.crafting.ShapedRecipe$Serializer.func_199425_a_(ShapedRecipe.java:281) ~[?:?]
at net.minecraft.item.crafting.ShapedRecipe$Serializer.func_199425_a_(ShapedRecipe.java:272) ~[?:?]
at net.minecraft.item.crafting.RecipeManager.func_215377_a(RecipeManager.java:141) ~[?:?]
at net.minecraft.item.crafting.RecipeManager.func_212853_a_(RecipeManager.java:61) [?:?]
at net.minecraft.item.crafting.RecipeManager.func_212853_a_(RecipeManager.java:38) [?:?]
at net.minecraft.client.resources.ReloadListener.func_215269_a(SourceFile:13) [?:?]
at net.minecraft.client.resources.ReloadListener$$Lambda$14403/37050228.accept(Unknown Source) [?:?]
at java.util.concurrent.CompletableFuture.uniAccept(CompletableFuture.java:656) [?:1.8.0_51]
at java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:632) [?:1.8.0_51]
at java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:442) [?:1.8.0_51]
at net.minecraft.resources.AsyncReloader.func_219557_a(SourceFile:71) [?:?]
at net.minecraft.resources.AsyncReloader$$Lambda$14596/31665639.run(Unknown Source) [?:?]
at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213166_h(SourceFile:144) [?:?]
at net.minecraft.util.concurrent.RecursiveEventLoop.func_213166_h(SourceFile:23) [?:?]
at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213168_p(SourceFile:118) [?:?]
at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213161_c(SourceFile:127) [?:?]
at net.minecraft.client.Minecraft.func_238189_a_(Minecraft.java:1863) [?:?]
at net.minecraft.client.Minecraft.loadWorld(Minecraft.java:1715) [?:?]
at net.minecraft.client.Minecraft.lambda$loadWorld$29(Minecraft.java:1804) [?:?]
at net.minecraft.client.Minecraft$$Lambda$18641/200845811.run(Unknown Source) [?:?]
at net.minecraft.client.Minecraft.lambda$displayExperimentalConfirmationDialog$30(Minecraft.java:1834) [?:?]
at net.minecraft.client.Minecraft$$Lambda$18642/1010665156.proceed(Unknown Source) [?:?]
at net.minecraft.client.gui.screen.ConfirmBackupScreen.func_212992_b(SourceFile:40) [?:?]
at net.minecraft.client.gui.screen.ConfirmBackupScreen$$Lambda$18650/861471485.onPress(Unknown Source) [?:?]
at net.minecraft.client.gui.widget.button.Button.func_230930_b_(SourceFile:33) [?:?]
at net.minecraft.client.gui.widget.button.AbstractButton.func_230982_a_(SourceFile:16) [?:?]
at net.minecraft.client.gui.widget.Widget.func_231044_a_(Widget.java:136) [?:?]
at net.minecraft.client.gui.INestedGuiEventHandler.func_231044_a_(SourceFile:27) [?:?]
at net.minecraft.client.MouseHelper.func_198033_b(MouseHelper.java:87) [?:?]
at net.minecraft.client.MouseHelper$$Lambda$17253/2101184295.run(Unknown Source) [?:?]
at net.minecraft.client.gui.screen.Screen.func_231153_a_(Screen.java:427) [?:?]
at net.minecraft.client.MouseHelper.func_198023_a(MouseHelper.java:85) [?:?]
at net.minecraft.client.MouseHelper.func_228030_c_(MouseHelper.java:175) [?:?]
at net.minecraft.client.MouseHelper$$Lambda$17252/1040624209.run(Unknown Source) [?:?]
at net.minecraft.util.concurrent.ThreadTaskExecutor.execute(SourceFile:94) [?:?]
at net.minecraft.client.MouseHelper.func_228028_b_(MouseHelper.java:174) [?:?]
at net.minecraft.client.MouseHelper$$Lambda$14376/1283226190.invoke(Unknown Source) [?:?]
at org.lwjgl.glfw.GLFWMouseButtonCallbackI.callback(GLFWMouseButtonCallbackI.java:36) [lwjgl-glfw-3.2.2.jar:build 10]
at org.lwjgl.system.JNI.invokeV(Native Method) ~[lwjgl-3.2.2.jar:build 10]
at org.lwjgl.glfw.GLFW.glfwWaitEventsTimeout(GLFW.java:3174) [lwjgl-glfw-3.2.2.jar:build 10]
at com.mojang.blaze3d.systems.RenderSystem.limitDisplayFPS(SourceFile:127) [?:?]
at net.minecraft.client.Minecraft.func_195542_b(Minecraft.java:999) [?:?]
at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:607) [?:?]
at net.minecraft.client.main.Main.main(Main.java:184) [?:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_51]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_51]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_51]
at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_51]
at net.minecraftforge.fml.loading.FMLClientLaunchProvider.lambda$launchService$0(FMLClientLaunchProvider.java:51) [forge-1.16.5-36.1.33.jar:36.1]
at net.minecraftforge.fml.loading.FMLClientLaunchProvider$$Lambda$479/1147334625.call(Unknown Source) [forge-1.16.5-36.1.33.jar:36.1]
at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-8.0.9.jar:?]
at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-8.0.9.jar:?]
at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-8.0.9.jar:?]
at cpw.mods.modlauncher.Launcher.run(Launcher.java:82) [modlauncher-8.0.9.jar:?]
at cpw.mods.modlauncher.Launcher.main(Launcher.java:66) [modlauncher-8.0.9.jar:?]
Port to Fabric?
Your mod looks awesome, but sadly it's not available on Fabric. Do you consider switching to it?
Various bugs involving ravagers and horn armor recipes
While doing my tests i have found various bugs in the latest version of Ravage and cabbage:
-Leather and gold horn armor recipes are missing. (this might be intentional but im not sure and kinda wouldn't make sense)
-Netherite horn armor recipe is messed, trying to upgrade the diamond ones with a netherite ingot instead gives the same diamond horn armor.
-Ravagers don't make any bite sound when they attack at their will, commanding them with the horn armor to attack produces the sound with no problem.
-Ravager's bite is weaker than the vanilla ones, dealing only 6 points of damage (3 hearts) instead of the vanilla 12 (6 hearts) (tested it in normal difficulty) and they seem to do even less damage when their bite is commanded with the horn armor, about 4 points of damage (2 hearts) regardless of the horn armor material.
-Tamed ravager's roar can damage it's owner.
-Ravagers sometimes doesn't want to attack not even if attacked or if their owner attacks a mob or is being attacked, and sometimes when they do so their ai is wonky. (this bug is kinda tricky since sometimes they work just fine, sometimes they want to attack their target but do weird pauses, and sometimes just won't attack)
-(maybe not a bug but more a suggestion) Ravager's footsteps are not correct, they sound like a player or creeper footstep. they should sound like the vanilla ones.
So here we go. Despite of these bugs, i had so much fun playing with this mod, and i hope it gets better and more popular in the future!
Crash dimensions MythicBotany and Twilight Forest
When I teleport to these dimensions, nothing happens. But if I walk through these dimensions, then there is a chance of the game crashing. Crash report says it's probably because of the ravageandcabbage structure.
crash-2022-06-10_22.44.10-server.txt
Also if I write a command to find this structure in these worlds /locate ravageandcabbage:stable. I am getting an error while searching, which is shown in the pictures below:
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.