teamauroramods / fruitful-forge Goto Github PK

Hello! Someone was running my mod called Blame with a small modpack and it seemed to have found that Fruitful's ConfiguredFeature form of its budding/flowering oak tree is not registered. This can be an issue for mod compatibility as under certain conditions, unregistered ConfiguredFeatures can basically prevent other mod's registered ConfiguredFeatures from spawning if in the same generation stage.

By that I mean, if mod A adds an unregistered CF to the ore generation stage and the biome's codec reaches it first, it will choke and basically nuke mob B's registered CFs afterwards. Here's a case where BetterCaves forgot to register their CF and caused several CFs from Oh The Biomes You'll Go to stop spawning in the world: YUNG-GANG/YUNGs-Better-Caves#75

Here's a more detailed explanation of why this happens in the biome's codec:

Specifically, when you call .withConfiguration on a Feature, you create a ConfiguredFeature. This is what should be registered to the WorldgenRegisties at mod init (you can do it in FMLCommonSetupEvent so you have your config ready too if it is needed).

Anyway here's an example from my mod RepurposedStructures of me registering all my ConfiguredFeatures.
https://github.com/TelepathicGrunt/RepurposedStructures/blob/584433a0745338802c84e9f498dc063c1f5505f8/src/main/java/com/telepathicgrunt/repurposedstructures/modinit/RSConfiguredStructures.java#L72-L74

I hope this helps!

From the log with Blame where it tried to figure out what unnamed configuredfeature is unregistered by parsing its json:

****************** Blame Report 1.9.0 ******************

This is an experimental report. It is suppose to automatically read
the JSON of all the unregistered ConfiguredFeatures, ConfiguredStructures,
and ConfiguredCarvers. Then does its best to collect the terms that seem to
state whose mod the unregistered unnamed stuff belongs to.

Possible mods responsible for unregistered stuff:

fruitful:budding_oak_leaves
fruitful:flowering_oak_leaves

Here is the log this is after downloading the Fruitful-1.16.1-v1.2.2 update.

https://pastebin.com/CQK3x0ji

I use a modpack that runs in 1.15.2 because a lot of mods I prefer over others work in 1.15.2 and not above, and I was wondering if there is any plans to backport to 1.15.2 so I could use this mod

Quark crates burn btw.

****************** Blame Report 1.16.5-3.0.1-forge ******************

This is an experimental report. It is suppose to automatically read
the JSON of all the unregistered ConfiguredFeatures, ConfiguredStructures,
and ConfiguredCarvers. Then does its best to collect the terms that seem to
state whose mod the unregistered stuff belongs to.

Possible mods responsible for unregistered stuff:

fruitful:budding_oak_leaves
fruitful:flowering_oak_leaves
]

I really like the concept of needing pollination to grow but does my apple yield really have to depend on the full moon?

It takes 160 (2hrs and 40min) in-game minutes for a full moon to occur.
It takes on average 31 in-game minutes (according to the minecraft wiki) for wheat to fully mature.

Perhaps they could blossom every other day or some blossom according to some config value?

just sticking this here so it's simple to keep track of. exactly what it says on the tin.

current fixing plan: make OakBlossomBlock extend Block, not LeavesBlock, and just copy vanilla code. not pretty but it works.

Farmer's delight adds a couple apple foods (Apple Pie Slice, a placeable Apple Pie, and Fruit Salad), could you let them give sustaining?
Alternatively, could you make a tag for all apple items, so that pack authors can add any number of extra apple items without bugging you guys?