tcprescott / pyz3r Goto Github PK

when running the code on windows using python 3.7
I get an error with write rom.
def write_rom(self, rom, dstfilepath):
fw = open(dstfilepath,"wb")
patchrom = bytes()
for idx, chunk_array in enumerate(self._chunk(rom,256)):
patchrom += bytes(chunk_array)
fw.write(patchrom)
fw.close

Traceback (most recent call last):
File "zelda.py", line 35, in
seed.write_rom(patched_rom, "patched_rom.sfc")
File "C:\Users\linkm\AppData\Local\Programs\Python\Python37\lib\site-packages\pyz3r_init_.py", line 324, in write_rom
for idx, chunk_array in enumerate(self._chunk(rom,256)):
RuntimeError: generator raised StopIteration

I just wanted to check to see if this supports windows or if it is a 3.7 issue. Thanks!

Sorry I didn't know where else to put this so I apologize if this is the wrong spot. Awesome program BTW!

It took some editing of mystery.py to get the generate_random_settings() to give me a dict that can be used with seed = pyz3r.alltpr(settings=settings). Mystery.py was adding a quickswap and pot shuffle setting that didn't work with the seed generation and then "return settings, customizer" made the settings variable type a tuple instead of dict. Perhaps I am not smart enough to have converted it, but when I removed quickswap and pot suffle options and deleted the customizer return the seed generation worked perfectly.

TL;DR The sample mystery seed generation code didn't work as shown in the Readme. I had to modify mystery.py to make it function.

I am unable to patch a game with the Open world state. I'm more or less following the readme sample docs. Patches do seem to be applying. Uncle's text is changed, the chest in link's house is randomized and the opening menu is patched to alttpr custom and to show the validation code items, but initial game state is raining instead of open.

I have tested patched roms in bsnes on windows and snes9x on ARM (raspberry-pi4), same behavior on both.

repro code https://gist.github.com/mgius/48b6c71808da53cdaff57b41b49db1cd

(retropie-alttpr-SYqaV0nu-py3.7) mgius@ICHABOD:~/src/retropie-alttpr$ python repro.py
Hash: ZeM48D74Mj
Code: ['Empty Bottle', 'Ice Rod', 'Pendant', 'Hookshot', 'Hammer']

I'm sure you already know this, but it's broken as of the latest release for alttpr.

It looks like you need a BPS patcher and some updates to fetch the new base BPS and apply it as well as how to get the randomizer BPS and apply that.