Git Product home page Git Product logo

cards-database's People

Contributors

allcontributors[bot] avatar aviortheking avatar calli23 avatar dependabot[bot] avatar junetwooo avatar maxopoly avatar spyworldxp avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

cards-database's Issues

Chilling Reign

What do you want to change?

  • Serie
  • Set
  • Card

What change do you want to do?

Describe the change(s) you want to be added/enhanced

Add Chilling Reign informations

Decks support

Blocked by #59

What do you want to change?

  • Serie
  • Set
  • Card
  • Deck

What change do you want to do?

Describe the change(s) you want to be added/enhanced

Add new datas to support decks that are/was sold in the market

possible sourcing https://bulbapedia.bulbagarden.net/wiki/Theme_Deck_(TCG)

interface Deck {
	name: Languages
	typeFocus: Array<Types>
	cards: Array<{
		// card global id
		id: string
		// card quantity
		quantity?: number
		// if the card(s) is an holo
		variant?: 'holo'
	}>
}

data/[serie]/[set]/decks/[deckname].ts or elsewhere

const deck: Deck = {
	name: {
		en: 'Charizard',
		fr: 'Dracaufeu',
		it: 'Charizard',
		de: 'Glurak',
		es: 'Charizard'
	},
	typeFocus: ['Fire'],
	cards: [{
		id: 'swsh4-25',
		variant: 'holo'
	}, {
		id: 'swsh4-25'
	}, {
		id: 'swsh4-24',
		quantity: 3
	}, {
		id: 'swsh4-23',
		quantity: 3
	}]
}

export default deck

issue: Missing sets

found a missing set? create a new issue or comment below

Some sets are currently missing from the Database based on https://bulbapedia.bulbagarden.net/wiki/Pok%C3%A9mon_Trading_Card_Game#Wizards_of_the_Coast_sets

Normal sets

  • W Promotional (Base) (No longer a set ) #183
  • Best of game (E-Card) #108
  • Sample (E-Card)
  • Poké Card Creator Pack (EX) #184
  • Pokémon Futsal Collection (SWSH) #107

Macdonald's collections

  • Macdonald's Collection 2011 #101
  • Macdonald's Collection 2012 #101
  • Macdonald's Collection 2013 #102
  • Macdonald's Collection 2014 #101
  • Macdonald's Collection 2015 #101
  • Macdonald's Collection 2016 #101
  • Macdonald's Collection 2017 #101
  • Macdonald's Collection 2018 #101
  • Macdonald's Collection 2018 French #102
  • Macdonald's Collection 2019 #101
  • Macdonald's Collection 2019 French #102

Trainer Kits

  • DP trainer Kit (Lucario) #106 (not complete)
  • DP trainer Kit (Manaphy) #106 (not complete)
  • EX trainer Kit (Latias).ts #106 (not complete)
  • EX trainer Kit (Latios).ts #106 (not complete)
  • EX trainer Kit 2 (Ninun).ts #106 (not complete)
  • EX trainer Kit 2 (Plusle).ts #106 (not complete)
  • HS trainer Kit (Excadrill).ts #106
  • HS trainer Kit (Gyarados).ts #106 (not complete)
  • HS trainer Kit (Raichu).ts #106 (not complete)
  • HS trainer Kit (Zoroark).ts #106
  • SM trainer Kit (Alolan Raichu).ts #106
  • SM trainer Kit (Lycanroc).ts #106
  • XY trainer Kit (Bisharp).ts #106
  • XY trainer Kit (Latias).ts #106
  • XY trainer Kit (Latios).ts #106
  • XY trainer Kit (Noivern).ts #106
  • XY trainer Kit (Pikachu Libre).ts #106
  • XY trainer Kit (Suicune).ts #106
  • XY trainer Kit (Sylveon).ts #106
  • XY trainer Kit (Wigglytuff).ts #106

[Up]: Add `firstSeen` field

Data affected

  • Card
  • Set
  • Serie
  • Other
  • new Data Type

Please explain in more details what idea you have

to be able to know when specific cards were released (mostly for PROMO cards)

[Up]: regulationMark endpoint

Data affected

  • Card
  • Set
  • Serie
  • Other
  • new Data Type

Please explain in more details what idea you have

Add a regulationMark endpoint to filter by the regulation mark

  • /regulation-marks
  • /regulation-marks/d
  • /regulation-marks/e

Multiple illustrators support

What do you want to change?

  • Serie
  • Set
  • Card

What change do you want to do?

Describe the change(s) you want to be added/enhanced

Support for multiple illustrators for a single card

Coming soon example
20210715_081134.jpg

[Up]: trainerType endpoint

Data affected

  • Card
  • Set
  • Serie
  • Other
  • new Data Type

Please explain in more details what idea you have

  • /trainer-types
  • /trainer-types/{type}

issue: Missing/Corrupted Images

found another missing images? create a new issue or comment below

  • DE,ES,IT,PT < SWSH

All languages

Normal sets

SWSH

  • Fusion Strike
  • Evolving skies
  • Pokémon Futsal Collection

E-Card

  • Best of game
  • Sample

EX

  • Poké Card Creator Pack

Base

  • W Promotional (Base)

Macdonald's collections

  • Macdonald's Collection 2011
  • Macdonald's Collection 2012
  • Macdonald's Collection 2013
  • Macdonald's Collection 2014 English
  • Macdonald's Collection 2014 French
  • Macdonald's Collection 2015
  • Macdonald's Collection 2016
  • Macdonald's Collection 2017
  • Macdonald's Collection 2018
  • Macdonald's Collection 2019

Trainer Kits

  • DP trainer Kit (Lucario)
  • DP trainer Kit (Manaphy)
  • EX trainer Kit (Latias).ts
  • EX trainer Kit (Latios).ts
  • EX trainer Kit 2 (Ninun).ts
  • EX trainer Kit 2 (Plusle).ts
  • HS trainer Kit (Excadrill).ts
  • HS trainer Kit (Gyarados).ts
  • HS trainer Kit (Raichu).ts
  • HS trainer Kit (Zoroark).ts
  • SM trainer Kit (Alolan Raichu).ts
  • SM trainer Kit (Lycanroc).ts
  • XY trainer Kit (Bisharp).ts
  • XY trainer Kit (Latias).ts
  • XY trainer Kit (Latios).ts
  • XY trainer Kit (Noivern).ts
  • XY trainer Kit (Pikachu Libre).ts
  • XY trainer Kit (Suicune).ts
  • XY trainer Kit (Sylveon).ts
  • XY trainer Kit (Wigglytuff).ts

Add logo to series

What do you want to change?

  • Serie
  • Set
  • Card

What change do you want to do?

Describe the change(s) you want to be added/enhanced

Add a logo field to the series (is the first set logo mainly)

Remove set.variants

The goal of set.variants was to know if there was cards available in a variant in the set.

This is now better expressed by using the set.cardCount and can be removed from the API

note: deprecate it in the SDKs beforehand

Ideas for `tcgdex/distribution`

  1. Rename from tcgdex/distribution to tcgdex/server

  2. I want to add some new APIs systems like a GraphQL one (AND maybe finish the documentation lol)
    APIs I want to try out

  • REST (default)
  • GraphQL (on the /graphql endpoint I think)
  • SOAP/XML (I don't really know)

issue: Sets to be removed in v3

What seems to be the issue

Set

Field(s)

all

Description

Set to be removed: Reason

  • misc/Jumbo: Jumbo is now a variant
  • Base/W Promotional: WPromo is now a variant
  • Black & White/Radiant Collection: Radiant Collection isRC cards from Legendary Treasures

[Up]: No cards in "Base Set" for fr translation

Data affected

  • Card
  • Set
  • Serie
  • Other
  • new Data Type

Please explain in more details what idea you have

There is no cards in fetchSet('Set de Base') for fr translation (works for en)

FR :
image

EN :
image

Is this normal ?
Thank you !

2021 Goals

  • 10 stars
  • PHP SDK stable
  • Kotlin/Java SDK stable
  • GO? SDK Beta
  • New endpoints
  • Mobile app
  • 20 stars

Add regulation Mark field

What do you want to change?

  • Serie
  • Set
  • Card

What change do you want to do?

Describe the change(s) you want to be added/enhanced

Add regulation Mark field

[Up]: add `related` field

Data affected

  • Card
  • Set
  • Serie
  • Other
  • new Data Type

Please explain in more details what idea you have

this field is going to be a lot of work:

The main goal of this field would be to list all the reprint of the same cards.

Some things are to see before:

  • does all reprint contains the exact same fields?
  • are fields change only Erratas?

Remove set.cardCount.total

It is now not needed as it is automaticly fetched from the count of cards in the folder

  • Remove any usage from the Compiler
  • Remove it from each sets

[Up]: add `Baby` stage

Data affected

  • Card
  • Set
  • Serie
  • Other
  • new Data Type

Please explain in more details what idea you have

there is a Baby stage cel25-20A

[Up]: energyType endpoint

Data affected

  • Card
  • Set
  • Serie
  • Other
  • new Data Type

Please explain in more details what idea you have

  • /energy-types
  • /energy-types/{type}

[Up]: Move translations to the Database Repository

Data affected

  • Card
  • Set
  • Serie
  • Other
  • new Data Type

Please explain in more details what idea you have

compiler/utils/translations

Currently on the Compiler repository it would be better if hosted on the cards-database repository

Also, change the format from JSON to Typescript to have easy access

Add serie-wide energy support

What do you want to change?

  • Serie
  • Set
  • Card

What change do you want to do?

Describe the change(s) you want to be added/enhanced

Generally each series add their own new version of an energy card

the goal would be to add support in the serie file of which energy cards were in this serie

  • each energy would have the id {serie-id}-{type.toLowerCase()} (unblocking #33)
export interface Serie {
	id: string
	name: Languages
+	energies?: Array<Types>
}

issue: List serie wide cards

Where are you having the issue

  • GraphQL
  • JSON API

Is the issue affecting one of the two elements below ?

  • Translations
  • Definitions Files (Open API, GraphQL Schema, etc)

Description

Serie wide cards are currently not listable as the schemas have the set field has mandatory

The Goal would be to make set optional and to add a serie field mandatory

in the api.d.ts schema

	/**
	 * Card Set
	 */
-	set: SetResume;
+	set?: SetResume
+
+	/**
+	 * Card Serie
+	 */
+	serie: SerieResume

[Up]: suffix endpoint

Data affected

  • Card
  • Set
  • Serie
  • Other
  • new Data Type

Please explain in more details what idea you have

Allow to filter by using the pokemon card suffix

  • /suffixes
  • /suffixes/{suffix}

Fix `Fightning` to `Fighting`

What do you want to change?

  • Serie
  • Set
  • Card

What change do you want to do?

Describe the change(s) you want to be added/enhanced

[Up]: dexId endpoint

Data affected

  • Card
  • Set
  • Serie
  • Other
  • new Data Type

Please explain in more details what idea you have

Added a dexId endpoint to filter Pokemon cards by their national pokedex IDs

note: a card can have multiple dexIds if multple pokemon are on it

  • /dex-ids
  • /dex-ids/{dexid}

Swap from a card/set based Legal generation to a file based one

What do you want to change?

  • Serie
  • Set
  • Card

What change do you want to do?

Describe the change(s) you want to be added/enhanced

Swap from a card/set based Legal generation to a file based one

a new file named legals.ts would be created and it would have fields like this

type Filter = {
    includes: {
        sets: Array<string> // array of sets names
        regulationMark: Array<String> // array of marks
    },
    exclude: {
        cards: Array<string> // Array of card full id
    }
}

standard: Filter = {}
expanded: Filter = {}

the main goal is to make it less hard to change legals for each cards/set/everything

Goal is to make it before the 2021-09-10 to be up with the new system from Pokemon

Sources:
https://www.pokemon.com/us/pokemon-news/2022-pokemon-tcg-championship-series-season-format-rotation/
https://www.pokemon.com/us/pokemon-tcg-banned-card-list/

blocked by #12

[Up]: variants endpoint

Data affected

  • Card
  • Set
  • Serie
  • Other
  • new Data Type

Please explain in more details what idea you have

Add a new Endpoint that filter cards by variants

  • /variants
  • /variants/normal
  • variants/reverse
  • etc

enhancement: Output progress of translation as part of compilation

Data affected

  • Card
  • Set
  • Serie
  • Other
  • new Data Type

Please explain in more details what idea you have

Autogenerated output to track translation progress would be great. Would likely need to collect base data first on which sets released in which language.

Tasks

From #141 (comment)

So the new goal in the short term are:

  • Add a button that give you the missing cards IDs
  • Add links to directly go to the set/serie
  • Change colors to be more clear
  • Make a .svg file that generate the top Table for README display

In the long term (After finishing the Documentation):

  • Redesign the whole page to be easier on the eyes

issue: Duplicated attacks

What seems to be the issue

{"label"=>"Card"}

Field(s)

attacks

Description

Some cards have a duplicated entry in 'attacks'. The duplicated entry seems to always have only a french translation. Example

List of all cards which are seemingly affected by this issue, based on iterating them and searching for attacks without an english name:

bwp-BW85
dp1-120
dp1-121
dp1-122
dp3-10
dp3-83
dp3-86
dp3-95
dp5-4
dp5-11
dp5-57
dp5-72
dp5-78
dp5-91
hgss1-11
hgss1-30
hgss1-44
hgss1-46
hgss3-87
hgss3-88
hgss3-89
hgss3-90
hgss4-99
hgss4-100
hgss4-101
hgss4-102
sm5-58
sm5-62
sm5-77
sm5-89
sm6-31
sm6-74
sm6-96
sm7.5-7
sm8-19
sm8-144
sm8-154
sm9-10
sm9-51
sm10-1
sm10-20
sm10-107
sm10-130
sm10-191
sm10-192
sm10-194
sm11-35
sm11-54
sm11-71
sm11-126
sm11-214
sm11-215
sm11-217
sm11-218
sm11-220
sm11-221
sm11-222
sm11-225
sm11-226
sm12-210
sm12-211
sm12-212
sm12-214
sm12-215
sm12-216
sm12-223
sm115-29
sm115-44
smp-SM166
smp-SM168
smp-SM169
smp-SM201
xy1-114
xy2-13
xy2-69
xy2-79
xy2-107
xy2-108
xy2-109
xy5-55
xy5-149
xy5-151
xy6-35
xy6-59
xy6-61
xy6-76
xy6-100
xy6-102
xy6-105
xy7-8
xy7-11
xy7-15
xy7-18
xy7-21
xy7-28
xy7-32
xy7-35
xy7-43
xy7-50
xy7-67
xy7-85
xy7-92
xy7-96
xy7-97
xy7-98
xy8-12
xy8-50
xy8-79
xy8-92
xy8-104
xy8-113
xy9-18
xy9-41
xy10-19
xyp-XY39
xyp-XY63
xyp-XY87
xyp-XY154

enhancement: Support `weight` and `height` fields

Data affected

  • Card
  • Set
  • Serie
  • Other
  • new Data Type

Please explain in more details what idea you have

Currently each cards have a Pokémon Weight and Height.

idk how to put this in the database and how to transform it in the distribution base.

ex:

a float in KG in the db and the dist show and object with each thingy

OR

the API show the internationnal format and each SDKs have helper function to translate it to another format

[Up]: Move `compiler` repository to the `cards-database` repository

Data affected

  • Card
  • Set
  • Serie
  • Other
  • new Data Type

Please explain in more details what idea you have

The main goal is to easily fix errors generated from the compiler when paths are changed or data are added/removed

It would also allows to make WAY better tests on the PRs as We would be able to build the whole database and run a command like git diff to see the changes instead or crossing my fingers that I didn't break everything

[Up]: stage endpoint

Data affected

  • Card
  • Set
  • Serie
  • Other
  • new Data Type

Please explain in more details what idea you have

Allow to filter Pokemon cards by using their stage

  • /stages
  • /stages/{stage}

Add new rarities

Currently there is multiple rarities in the TCG, Common, Uncommon, Rare and ultra Rare(white instead of black) are the four most common with their symbols on the cards itself.

A Card HAS only one rarity (unless the TCG change).

some other cards have a rarity of "Holofoil Rare"/"Rare holo"/"Holo Rare" and while they could be used in the rarity field it would be redundant with the variants.holo field.

So it would mean that the following rarities will be used in the v3:

  • None // no rarity is displayed
  • Common // the circle
  • Uncommon // the diamond
  • Rare // the star
  • Ultra Rare // kept because it is officially kept (in the japanese at least) // Pokemon EX,LV.X,PRIME,GX,Tag Team GX,V,VMAX
  • Rare LEGEND // the star is yellow
  • Rare Star // the star is to be white with a yellow border
  • Amazing // an A in a rainbow
  • Secret Rare // number is beyond the official one
  • Shining // has three Stars

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.