tasianmedia / cookiejar Goto Github PK

I included a mention of your extra in a blog post, and after looking at the code, had a few ideas for you I wanted to mention:

1. Make the expiration in days rather than seconds by multiplying the value 86400. Users can still use fractional days if they want a shorter period.

$expires = !empty($expires) ? time() + intval( ($expires * 86400)) : '';

2. Add the cookie name and value to the $_COOKIE array so the value will be available later in the page without a reload.

3. Log an error if setCookie() fails.

if (isset($name)) {
  $success = setcookie($name,$value,intval($expires),$path,$domain,$secure,$httponly);
} else {
  $modx->log(modX::LOG_LEVEL_ERROR, 'setCookie() - &name is required');
}

if ($success) {
    /* Make cookie available immediately */
   $_COOKIE[$name] = $value;
} else {
   $modx->log(modX::LOG_LEVEL_ERROR, 'Cookie not set');    
}

I didn't do a pull request because I wasn't sure what you'd want to do about existing installs that use seconds (e.g., convert them in the update package, or introduce a new property: &units which defaults to seconds).

Set default val for $result to fix undefined variable notice in logs.

Can you change the log from ERROR to DEBUG?

My MODX error log is filling up with "getCookie() - Cookie name not recognised." My boss thinks it is an error, but it isn't. Most visitors won't have the cookie I am looking for on that page. It is only for special visitors to another page that get that cookie.

The getCookie does not work if your cookie has a period in the name e.g. if your cookie is named "local.user", however, setCookie works fine with cookies named that way.