tarsius / moody Goto Github PK

Tabs and ribbons for the mode-line

License: GNU General Public License v3.0

Emacs Lisp 92.82% Makefile 7.18%

moody's Introduction

Blog	Mastodon	Github	Gitlab	Sourcehut

Please consider sponsoring my work. Thank you!

7E108E46F316CBA0CE3C8D20FC61B7237C7155B7

Keyoxide

OpenPGP

gpg --keyserver hkps://keys.openpgp.org \
    --recv-key 7E108E46F316CBA0CE3C8D20FC61B7237C7155B7

moody's People

Stargazers

Watchers

Forkers

emacsmirror unhammer edkolev qq591638853 jemmanuel wilfred marioba ataraxic ktp-forked-repos pradhyu rtwalker kd-collective askurihin jcs-pr richerve corrigentia scamchamp jtmcx procyberian

moody's Issues

Faulty rendering on HiDPI screen

Hi,

this is what I get on the 3200x1800 display's resolution of my Dell XPS 13.

Everything works fine with the external monitor (1920x1080).

I am using Ubuntu 16.04 LTS, with latest moody from MELPA on GNU Emacs 27.0.50 (build 1, x86_64-debian-linux-gnu, GTK+ Version 3.18.9) of 2018-03-11.

If you need more tests or details, feel free to ask.

When `xpm` is not supported?

Hi, Jonas! Thanks for another awesome package as always!

I recently encountered an issue when xpm is not supported. See screenshot below:

(image-type-available-p 'xpm)   ; nil

Screenshot:

I was wondering if you have a plan to make it look nicer. Maybe just remove the | character when it is not supported? 🤔I am also not a very artistic person, so I couldn't tell it looks better with | or not.

Dynamic height

I set moody-mode-line-height to 18, but when I scale the default font via C-x C-M-+ (global-text-scale-adjust), it produces modeline artifacts around moody slants.

Is there a way to calculate the height dynamically? It seems the default defcustom expression is evaluated once

Question about straight.el integration and about autoloads in general

Hi, thanks for your awesome things on emacs!
I've tried to install moody with straight.el and wasn't able to succeed because moody's functions weren't available in my init file's scope.
Straight's documentation says that it doesn't use require and relies on package autoloads instead.
So I've tried explicitly require moody instead like so:

;; the path is where straight clones packages
(require 'moody "~/.emacs.d/straight/repos/moody/moody.el")

and it worked.
So here is my question: why it doesn't work with regular straight way? Your other packages (magit and minions) both worked great for me.

P.S. I'm not that experienced in these aspects of emacs, so forgive me if it doesn't make any sense to you :)

Styling tab-{bar,line}-mode

Hello,

Are there any plans for adding support for styling the new tab modes with the same moody style?

Thanks!

moody error on startup

I'm getting this error when I start emacs: Error (use-package): moody/:catch: Wrong type argument: stringp, nil

My emacs environment:

Emacs version: GNU Emacs 27.0.50 (build 1, x86_64-apple-darwin16.7.0, NS appkit-1504.83 Version 10.12.6 (Build 16G1212))
 of 2018-03-14, built using commit d993d00394707e69b6ac7befeb72140d9b12a4e9.

./configure options:
  --disable-dependency-tracking --disable-silent-rules --enable-locallisppath=/usr/local/share/emacs/site-lisp --infodir=/usr/local/Cellar/emacs/HEAD-d993d00/share/info/emacs --prefix=/usr/local/Cellar/emacs/HEAD-d993d00 --without-x --with-xml2 --without-dbus --with-gnutls --with-imagemagick --with-rsvg --with-ns --disable-ns-self-contained

Features:
  RSVG IMAGEMAGICK NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS THREADS

No line around ribbons for some themes

If I load first the solarized-theme and then doom-nord-light, I get a nice modline:

Unfortunately, if I only load doom-nord-light I get an ugly modling (the line around ribbons is missing). What am I doing wrong?

Double tab in C-x C-f moves point to beginning of minibuffer

Hi,
I've noticed an odd bug, and it seems repeatable for me if I just load straight.el and then have the following config:

(use-package moody
  :config
  (setq x-underline-at-descent-line t)
  ;; (moody-replace-mode-line-buffer-identification)
  ;;(moody-replace-vc-mode)
  )

From a fresh emacs, if I load straight, and then the above config, moody appears.
If I then do C-x C-f TAB TAB

after the first tab I get [Complete, but not Unique] at the end of the minibuffer; after the second tab I see a Completions buffer with the files in my current directory. So far so good.

If however I then do M-x moody-replace-vc-mode the declaration around the Git-master changes, as expected. However, if I now do C-x C-f TAB TAB

after the second tab, as well ast the completions buffer appearing, point moves to the beginning of the minibuffer (i.e. over the F of "Find file" prompt).

Is this just my config? I've got an up to date moody.el i think and I'm running

(emacs-version)
"GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.28, cairo version 1.17.4)
 of 2021-04-28"

Thanks for any help.

Don't make tab/ribbon when receives empty string

Since both "" and nil means no information, do you think it's good to make moody behaves in the same way on them?

Error (use-package): moody/:catch: Invalid font name

The error I'm receiving I believe is cause by the foundy section of the font containing a trailing space. I'm not sure if this is a moody issue or something else.

Error (use-package): moody/:catch: Invalid font name: -FBI -InputMono-KF-normal-normal-normal-*-24-*-*-*-m-0-iso10646-1

Using a modified version of the Input font in emacs.
The font loads correctly with everything else, but Moody raises a catch.

#+BEGIN_SRC emacs-lisp
  ;; Test char and monospace:
  ;; 0123456789abcdefghijklmnopqrstuvwxyz [] () :;,. !@#$^&*
  ;; 0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ {} <> "'`  ~-_/|\?
  (set-default-font "InputMono-KF 9")
  (add-to-list 'default-frame-alist
               '(font . "InputMono-KF 9"))
#+END_SRC

Output of fc-scan:

kef@osh in ~ 
> fc-scan ~/.fonts/Display/Input-KF/InputMono-KF-Regular.ttf
Pattern has 24 elts (size 32)
	family: "InputMono-KF"(s)
	familylang: "en"(s)
	style: "Regular"(s)
	stylelang: "en"(s)
	fullname: "InputMono-KF"(s)
	fullnamelang: "en"(s)
	slant: 0(i)(s)
	weight: 80(i)(s)
	width: 100(i)(s)
	spacing: 100(i)(s)
	foundry: "FBI "(s)
	file: "/home/kef/.fonts/Display/Input-KF/InputMono-KF-Regular.ttf"(s)
	index: 0(i)(s)
	outline: True(s)
	scalable: True(s)
	charset: 
	0000: 00000000 ffffffff ffffffff 7fffffff 00000000 ffffffff ffffffff ffffffff
	0001: ffffffff ffffffff ffffffff ffffffff 00040000 00000000 00000000 fc000000
	0002: 0f000000 00800000 00000000 00000000 00000000 08000000 3f0002c0 00000000
	0003: 00041ddf 000001c0 00000000 00000000 ffffd7f0 fffffffb 00007fff 00000000
	0004: ffffffff ffffffff ffffffff 00000000 00030000 00000000 00000000 00000000
	001e: 00000000 00000000 00000000 00000000 0000003f 00000000 00000000 000c0000
	0020: 7fbb0ebf 560d0047 00000010 83f10000 000003ff 00001098 00000000 00000000
	0021: 00c80020 00004044 78000000 00000000 003f0000 00000100 00000000 00000000
	0022: c6268044 00000a00 00000100 00000033 00000000 00000000 00000000 00000000
	0023: 00010000 00000002 00000000 00000000 00000000 00008000 00000000 00000000
	0025: ffffffff ffffffff ffffffff ffffffff ffffffff 14040c03 00008c10 00000040
	0026: 02000000 00000000 00000005 00000469 00000000 00000002 00000000 00000000
	0027: 00080000 00000000 00000000 00000080 00000000 00000000 00000000 00000000
	00e0: ffffffff ffffffff ffffffff 00000001 00000000 000f0007 00000000 00000000
	00f6: 00000000 00000000 00000000 00000000 00000000 40000000 00000008 00000000
	00f8: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 80000000
	00fe: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 80000000
	01f4: 08000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
(s)
	lang: aa|af|av|ay|be|bg|bi|br|bs|ca|ce|ch|co|cs|cy|da|de|el|en|eo|es|et|eu|fi|fj|fo|fr|fur|fy|gd|gl|gv|haw|ho|hr|hu|ia|id|ie|ik|io|is|it|ki|kl|kum|la|lb|lez|lt|lv|mg|mh|mk|mo|mt|nb|nds|nl|nn|no|nr|nso|ny|oc|om|os|pl|pt|rm|ro|ru|se|sel|sk|sl|sm|sma|smj|smn|so|sq|sr|ss|st|sv|sw|tk|tl|tn|to|tr|ts|uk|uz|vo|vot|wa|wen|wo|xh|yap|zu|an|crh|csb|fil|hsb|ht|jv|kj|ku-tr|kwm|lg|li|ms|na|ng|pap-an|pap-aw|rn|rw|sc|sg|sn|su|za(s)
	fontversion: 72090(i)(s)
	capability: "otlayout:DFLT otlayout:latn"(s)
	fontformat: "TrueType"(s)
	decorative: False(s)
	postscriptname: "InputMono-KF-Regular"(s)
	color: False(s)
	symbol: False(s)

Feature Request: Icons support.

Hey, Dev!
Moody and Minion-mode is perfect combo and I really appreciate your efforts.
I request you to add icon-support for minor modes and evil state, maybe something like this, Mode-icon.

Invisible buffer name in leuven-theme

When I use leuven-theme, buffer name is invisible on modeline.

It becomes yellow when I hover the mouse above. Here's a minimal reproducible config.

Version info:

GNU Emacs 26.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.30) of 2018-07-05
Org mode version 9.2 (9.2-elpaplus @ /home/yiufung/.cyf-emacs/elpa/org-plus-contrib-20181230/)

Direct support for theming moody

Reusing the faces mode-line and mode-line-inactive works well for tabs but not always for ribbons. For example, a dark foreground with a light background and a dark border or the inverse results in unreadable ribbons. Yes, one can pass alternate faces to moody-ribbon, however, that requires defining faces, i.e., difficult to support by themes. As it currently stands, one has to modify the faces anyway, couldn't moody define its own faces which themes can target? Open to suggestions. Whatever you decide, thank you in advance.

(moody-replace-mode-line-buffer-identification) doesn't set the mode-line-format

Hi!

I just updated moody to the latest version and now the buffer identification is not replaced.

Setup:

  (use-package moody
    :config
    (setq moody-slant-function 'moody-slant-apple-rgb)
    (setq x-underline-at-descent-line t)
    (setq moody-mode-line-height 25)
    (moody-replace-mode-line-buffer-identification)
    (moody-replace-vc-mode))

(moody-replace-vc-mode) works though.

If I do this (setq mode-line-format (moody-replace-mode-line-buffer-identification)) instead of only (moody-replace-mode-line-buffer-identification) it works.

Update

The issue seems to arise when you call both (moody-replace-mode-line-buffer-identification) and (moody-replace-vc-mode).

If I only call one of them it works as expected.

Can moody work with dracula-theme?

This is more general question. Is it possible to use moody with dracula-theme?

When I tried the second example it just wrap the git branch inside a box , ex:

Is this the way it should work?

Right align mode-line-misc-info

I really like moody with minions but I would like to be able to right align
mode-line-misc-info and minions (/mode-line-modes).
That's the only feature I'm currently missing from smart-mode-lines.
I saw https://emacs.stackexchange.com/a/7542/12559 but it doesn't seem to work
with my setup.

failed to provide feature ‘moody’

Hi,

I updated my packages today and the following error is shown:
elpa/moody-20190203.1747/moody.elc failed to provide feature ‘moody’

Debugger entered--Lisp error: (error "Loading file c:/home_levis/.emacs.d/elpa/moody-20190203.1747/moody.elc failed to provide feature ‘moody’")
  require(moody nil t)
  (not (require 'moody nil t))
  (if (not (require 'moody nil t)) (display-warning 'use-package (format "Cannot load %s" 'moody) :error) (use-package-statistics-gather :config 'moody nil) (let ((now (current-time))) (message "%s..." "Configuring package moody") (prog1 (condition-case err (progn (setq x-underline-at-descent-line t) (moody-replace-mode-line-buffer-identification) (moody-replace-vc-mode) t) ((debug error) (funcall use-package--warning125 :config err))) (let ((elapsed (float-time (time-subtract (current-time) now)))) (if (> elapsed 0.1) (message "%s...done (%.3fs)" "Configuring package moody" elapsed) (message "%s...done" "Configuring package moody"))))) (use-package-statistics-gather :config 'moody t))
  (prog1 (if (not (require 'moody nil t)) (display-warning 'use-package (format "Cannot load %s" 'moody) :error) (use-package-statistics-gather :config 'moody nil) (let ((now (current-time))) (message "%s..." "Configuring package moody") (prog1 (condition-case err (progn (setq x-underline-at-descent-line t) (moody-replace-mode-line-buffer-identification) (moody-replace-vc-mode) t) ((debug error) (funcall use-package--warning125 :config err))) (let ((elapsed (float-time (time-subtract (current-time) now)))) (if (> elapsed 0.1) (message "%s...done (%.3fs)" "Configuring package moody" elapsed) (message "%s...done" "Configuring package moody"))))) (use-package-statistics-gather :config 'moody t)) (let ((elapsed (float-time (time-subtract (current-time) now)))) (if (> elapsed 0.1) (message "%s...done (%.3fs)" "Loading package moody" elapsed) (message "%s...done" "Loading package moody"))))
  (let ((now (current-time))) (message "%s..." "Loading package moody") (prog1 (if (not (require 'moody nil t)) (display-warning 'use-package (format "Cannot load %s" 'moody) :error) (use-package-statistics-gather :config 'moody nil) (let ((now (current-time))) (message "%s..." "Configuring package moody") (prog1 (condition-case err (progn (setq x-underline-at-descent-line t) (moody-replace-mode-line-buffer-identification) (moody-replace-vc-mode) t) ((debug error) (funcall use-package--warning125 :config err))) (let ((elapsed (float-time (time-subtract (current-time) now)))) (if (> elapsed 0.1) (message "%s...done (%.3fs)" "Configuring package moody" elapsed) (message "%s...done" "Configuring package moody"))))) (use-package-statistics-gather :config 'moody t)) (let ((elapsed (float-time (time-subtract (current-time) now)))) (if (> elapsed 0.1) (message "%s...done (%.3fs)" "Loading package moody" elapsed) (message "%s...done" "Loading package moody")))))
  (progn (use-package-statistics-gather :init 'moody nil) (let ((now (current-time))) (message "%s..." "Loading package moody") (prog1 (if (not (require 'moody nil t)) (display-warning 'use-package (format "Cannot load %s" 'moody) :error) (use-package-statistics-gather :config 'moody nil) (let ((now (current-time))) (message "%s..." "Configuring package moody") (prog1 (condition-case err (progn (setq x-underline-at-descent-line t) (moody-replace-mode-line-buffer-identification) (moody-replace-vc-mode) t) ((debug error) (funcall use-package--warning125 :config err))) (let ((elapsed (float-time (time-subtract (current-time) now)))) (if (> elapsed 0.1) (message "%s...done (%.3fs)" "Configuring package moody" elapsed) (message "%s...done" "Configuring package moody"))))) (use-package-statistics-gather :config 'moody t)) (let ((elapsed (float-time (time-subtract (current-time) now)))) (if (> elapsed 0.1) (message "%s...done (%.3fs)" "Loading package moody" elapsed) (message "%s...done" "Loading package moody"))))) (use-package-statistics-gather :init 'moody t))
  (condition-case err (progn (use-package-statistics-gather :init 'moody nil) (let ((now (current-time))) (message "%s..." "Loading package moody") (prog1 (if (not (require 'moody nil t)) (display-warning 'use-package (format "Cannot load %s" 'moody) :error) (use-package-statistics-gather :config 'moody nil) (let ((now (current-time))) (message "%s..." "Configuring package moody") (prog1 (condition-case err (progn (setq x-underline-at-descent-line t) (moody-replace-mode-line-buffer-identification) (moody-replace-vc-mode) t) ((debug error) (funcall use-package--warning125 :config err))) (let ((elapsed (float-time (time-subtract (current-time) now)))) (if (> elapsed 0.1) (message "%s...done (%.3fs)" "Configuring package moody" elapsed) (message "%s...done" "Configuring package moody"))))) (use-package-statistics-gather :config 'moody t)) (let ((elapsed (float-time (time-subtract (current-time) now)))) (if (> elapsed 0.1) (message "%s...done (%.3fs)" "Loading package moody" elapsed) (message "%s...done" "Loading package moody"))))) (use-package-statistics-gather :init 'moody t)) ((debug error) (funcall use-package--warning125 :catch err)))
  eval-buffer(#<buffer  *load*> nil "c:/home_levis/.emacs.d/init.el" nil t)  ; Reading at buffer position 61667
  load-with-code-conversion("c:/home_levis/.emacs.d/init.el" "c:/home_levis/.emacs.d/init.el" t t)
  load("c:/home_levis/.emacs.d/init" t t)
  #f(compiled-function () #<bytecode 0x1000bfab5>)()
  command-line()
  normal-top-level()

Thank you

:scale 1 causes xpm error

Updating emacs packages after a long hiatus, I found the following change in moody doesn't agree with emacs 27.1, Ubuntu 16.04.7, Emacs built from source:

f6bebfe

This causes many messages like this:

Color allocation error ((image :type xpm :data /* XPM */ static char * image[] = {
 "15 30 3 1",
 "0 c #d7d7d7",
 "1 c nil",
 "2 c #ffffff", "2222222222222221",
 "2222222222222210",
 "2222222222222210",
 "2222222222222100",
 "2222222222222100",
 "2222222222221000",
 "2222222222221000",
 "2222222222210000",
 "2222222222210000",
 "2222222222100000",
 "2222222222100000",
 "2222222221000000",
 "2222222221000000",
 "2222222210000000",
 "2222222210000000",
 "2222222100000000",
 "2222222100000000",
 "2222221000000000",
 "2222221000000000",
 "2222210000000000",
 "2222210000000000",
 "2222100000000000",
 "2222100000000000",
 "2221000000000000",
 "2221000000000000",
 "2210000000000000",
 "2210000000000000",
 "2100000000000000",
 "2100000000000000",
 "1000000000000000",

}; :scale 1 :ascent center))

Changing this to just :scale (without parameter) gets rid of the problem, but I have no idea if this is the correct fix.

Popup actions partially hidden

Following Magit documentation, I added some actions to the file popup with this:

(use-package magit-files                ; Magit file operations
  :ensure magit
  :config
  ;; Add more operations to the file popup
  (magit-define-popup-action 'magit-file-popup
    ?R "Rename file" 'magit-file-rename)
  (magit-define-popup-action 'magit-file-popup
    ?K "Delete file" 'magit-file-delete)
  (magit-define-popup-action 'magit-file-popup
    ?U "Untrack file" 'magit-file-untrack)
  (magit-define-popup-action 'magit-file-popup
    ?C "Checkout file" 'magit-file-checkout))

When I use M-x magit-file-popup this is what I see:

Same actions are completely visible with moody disabled.

This is how I configured moody:

(use-package moody                      ; Tabs and ribbons for the mode line
  :ensure t
  :config
  (moody-replace-mode-line-buffer-identification)
  (moody-replace-vc-mode))

I also slightly decreased the font in the mode-line, if this is relevant:

(set-face-attribute 'mode-line nil
                    :family "Iosevka"
                    :height 130)

And these are some details about my system, in case they can help with debugging:

GNU Emacs 27.0.50 (build 1, x86_64-debian-linux-gnu, GTK+ Version 3.22.30)
 of 2018-07-02

Repository revision: ee3e432300054ca488896e39fca57b10d733330a
Configured using:
--host=x86_64-debian-linux-gnu --with-modules

Emacs uptime: 4 minutes, 36 seconds
Colour theme: sanityinc-tomorrow-night
Operating system: Ubuntu 18.04 LTS
Window system: x11
Desktop environment: GNOME Shell 3.28.1

How do I insert a variable into a moody tab?

Hello,

I'm trying to understand how I can personalize a bit the moody mode line.

For example, I want the variable evil-mode-line-tag (which shows if I'm in normal, insert or visual mode) to appear into a moody tab.

I found I can do this by rewriting the whole mode-line-format (I've shorten the code for the example):

:custom 
(mode-line-format                        
 '(" "                                   
   (:eval                                
    (moody-wrap "%b"))                   
   " "                                   
   (:eval                                
    (moody-tab evil-mode-line-tag 0 'up))

   etc.

It works fine, but is there not a better way that I'm missing? Like something that I can configurate on one line which says "take the evil-mode-line-tag and put it into a tab", instead of rewriting the whole mode-line-format like above?

Thanks for your help.

VC tab has wrong shape

I've tried several off-the-shelf themes, and I'm seeing it all over. The first tab on the left is correct, but not the second, the tab for VC.

moody-ribbon-background showing next to VC mode element

When the VC mode element in the modeline gets replaced I am seeing an area of the modeline being shown in the style of moody-ribbon-background. To make it extra clear I have set moody-ribbon-background to a combination of elements that stands out:

I'm on the most recent commit on master.

Not working with solarized

Here is my config

     :straight t
     :config
     (load-theme 'solarized-light t)
     (let ((line (face-attribute 'mode-line :underline)))
	(set-face-attribute 'mode-line          nil :overline   line)
	(set-face-attribute 'mode-line-inactive nil :overline   line)
	(set-face-attribute 'mode-line-inactive nil :underline  line)
	(set-face-attribute 'mode-line          nil :box        nil)
	(set-face-attribute 'mode-line-inactive nil :box        nil)
	(set-face-attribute 'mode-line-inactive nil :background "#f9f2d9")))
    
(use-package moody
  :straight t
  :config
  (setq x-underline-at-descent-line t)
  (moody-replace-mode-line-buffer-identification)
  (moody-replace-vc-mode)
  (moody-replace-eldoc-minibuffer-message-function))

But it is not working ? When i run eval-buffer it is showing cannot find (vc-mode vc-mode) and use (vc-mode moody-vc-mode) in its place . Can somebody point out what i have done wrong ?

Setting the correct value for mode-line-format and mode-line-buffer-identification for treemacs buffers?

This is how treemacs mode-line looks when I enable it. I tried modifying the mode-line-format to contain mode-line-buffer-indentification and vc-mode, but no matter what I try, I'm unable to get moody mode-line to work on treemacs window :(

Relevant discussion in Treemacs issue tracker: Alexander-Miller/treemacs#204

Display problem

Hi, after upgrade, moody doesn't work on my MacBook

error message:

Error during redisplay: (eval (moody-tab (substring vc-mode 1) nil (quote up))) signaled (void-function evenp)

os:

macOS 10.13

emacs:

GNU Emacs 25.3.3 (x86_64-apple-darwin13.4.0, Carbon Version 157 AppKit 1265.21) of 2017-09-28

Sometimes coloring disappears in slant

I sometimes run into a problem where the coloring from the slant disappears. This seems to happen more frequently when I hit the super key, but I haven't figured out how to reliably reproduce it yet. It does happen quite frequently though.

Here's a screenshot of what I mean.

And my moody config:

(use-package moody
  ;; Set up the `mode-line'
  :demand
  :custom
  (moody-mode-line-height (if (string= (system-name) "mars") 22 40))
  (x-underline-at-descent-line t)
  :custom-face
  (mode-line ((t (:box nil :background "#5d4d7a" :underline "#5d4d7a" :overline "#5d4d7a"))))
  (mode-line-inactive ((t (:box nil :underline "#5d4d7a" :overline "#5d4d7a"))))
  :config
  (moody-replace-mode-line-buffer-identification)
  (moody-replace-vc-mode))

I am using moody at the most recent commit: db27ba1

Glitch on multiple windows

An image speaks more than my words :)

This only happens with 3 windows, no problem with 2 windows.

Underline below vc-mode

Hi, am I doing something wrong or is the underline below Git:master in the screenshot something to be expected:

If I swap the windows so that the vc-mode indicator is at the bottom of the frame that thin separation disappears, as in the picture in your README. It may be a tiny separator between windows and not part of the modeline itself.

After a quick glance at the code this is the only condition I found that could be related (window-at-side-p nil 'bottom).

Separators have weird colors

I'm experimenting with using moody with the zenburn theme on macOS. However, the slants have some weird colors.

Config:

(use-package moody
  :config
  (setq x-underline-at-descent-line t)
  (moody-replace-mode-line-buffer-identification)
  (moody-replace-vc-mode))

  (use-package zenburn-theme
    :demand t
    :config
    (load-theme 'zenburn' t)
    (zenburn-with-color-variables
        (set-face-attribute 'mode-line-inactive nil :overline   zenburn-bg-05)
        (set-face-attribute 'mode-line          nil :overline   zenburn-bg-1)
        (set-face-attribute 'mode-line          nil :underline  zenburn-bg-1)
        (set-face-attribute 'mode-line-inactive nil :underline  zenburn-bg-05)
        (set-face-attribute 'mode-line          nil :box        nil)
        (set-face-attribute 'mode-line-inactive nil :box        nil)
        (set-face-attribute 'mode-line-inactive nil :background zenburn-bg+05)
        (set-face-attribute 'mode-line          nil :background zenburn-bg-1)
        (set-face-attribute 'mode-line          nil :foreground zenburn-blue)
        (set-face-attribute 'mode-line-inactive nil :foreground zenburn-blue-2)))

Looks like this:

I don't know if it's the same issue as the one in Powerline, regarding Emacs using different color spaces on macOS for XPM and all other GUI elements, which was fixed here:
milkypostman/powerline@8a24690

What do you think?

Update

It seems to be the same issue. Adding (setq ns-use-srgb-colorspace nil) fixes it. However, that makes the rest of my theme look a bit off so I'd rather not do that.

Would it be possible to implement a similar fix as in powerline?

Symbol’s function definition is void: font-info

I got the following error in my CI.

Symbol’s function definition is void: font-info

Can we avoid this by first checking the function's existence before calling it in the root level?

Thanks!

(setq moody-slant-function 'moody-slant-apple-rgb) causes Error during redisplay

With (setq moody-slant-function 'moody-slant-apple-rgb) in the config, I get the following error multiple times in the messages buffer.

The errors disappear when I comment it out.

Error during redisplay: (eval (moody-tab (format-mode-line (propertized-buffer-identification "%b")) 20 (quote down))) signaled (wrong-type-argument number-or-marker-p nil) [2 times]

Below is my whole minions / moody config:

;; A minor-mode menu for the mode line
(use-package minions
  :ensure t
  :config
  (setq
    minions-mode-line-lighter "[+]"
    minions-direct '(flycheck-mode pyvenv-mode))
  (minions-mode 1))

;; Tabs and ribbons for the mode line
(use-package moody
  :ensure t
  :config
  (setq x-underline-at-descent-line t
        moody-mode-line-height 25)
        ;;moody-slant-function #'moody-slant-apple-rgb)
  (moody-replace-mode-line-buffer-identification)
  (moody-replace-vc-mode))

Moody height differs between Emacs and Emacsclient

I noticed that the height of the Moody modeline depends on how I start my emacs. If I start "Emacs", the height is taller compared to using an emacsclient and then connecting to a server.

Left is emacsclient, Right is Emacs. My moody configuration is

(use-package moody
  :straight t
  :after modus-themes
  :custom
  (x-underline-at-descent-line t)
  :config
  (moody-replace-mode-line-buffer-identification))

Not really a big deal to me, but I kind of like the slimmer modeline :)

smart-mode-line integration?

Hi, this is quite a nice modeline :-) Is there a way to get the buffer-identification stuff from https://github.com/Malabarba/smart-mode-line/ into it? Right now, it only shows the buffer name, not the full abbreviated path.

Top right of ribbon down is missing its border

They say a picture is worth a thousand words. Look at the top right of ribbon down. Its border is missing. I made :underline and :overline red so it's easier to see.

In case you'd like the above mode line format:

(setq mode-line-format
      '(" "
        (:eval
         (moody-tab "Tab down"))
        " "
        (:eval
         (moody-tab "Tap up" 0 'up))
        " "
        (:eval
         (moody-ribbon "Ribbon down"))
        " "
        (:eval
         (moody-ribbon "Ribbon up" 0 'up))))

Thank you for making moody.

Emacs 28 mode-line-compact distorts styling

Hello Jonas! I noticed that (setq mode-line-compact nil) (Emacs 28) has a negative effect on Moody: it eliminates the spaces that are used to draw the diagonal lines of e.g. moody-replace-mode-line-buffer-identification. Just thought I would bring this to your attention.

Problem when running Emacs as systemd user unit

When I start Emacs via systemd (i.e., on Linux) and then connect via emacsclient, moody's "graphical" elements (i.e., the diagonals) are broken. Instead, I see empty boxes:

When I start Emacs "normally", everything looks as expected (also when connecting using emacsclient to a server process that was not started via systemd).

Any ideas what might be the problem here?

Truncated org-attach popup

Maybe related to the org-set-tags-command case but worse and doesn't get fixed with the previous redisplay.

I've seen this in both moody and doom modelines.

Also disabled the redisplay advice just in case but to no avail.

Recipe:

Open any org file
Press C-c C-a
You should see something like:

instead of (without customized modeline):