Git Product home page Git Product logo

Comments (9)

ardeora avatar ardeora commented on May 29, 2024 1

Oopsie! Thanks taking a look now

from query.

ardeora avatar ardeora commented on May 29, 2024

Hello! Yeah I just reworked the internals of createQuery that fixes a lot of these issues. If you update to v5.30.1+ It should fix the issues. Here it is working https://stackblitz.com/edit/solidjs-templates-xcihcy?file=package.json

from query.

PeterDraex avatar PeterDraex commented on May 29, 2024

Hello! Yeah I just reworked the internals of createQuery that fixes a lot of these issues. If you update to v5.30.1+ It should fix the issues. Here it is working https://stackblitz.com/edit/solidjs-templates-xcihcy?file=package.json

@ardeora I can still repro this if I type oi quickly. Here is a screen recording from your StackBlitz:
https://github.com/TanStack/query/assets/18402223/0e6fb515-a829-4800-acbb-d022c2acce18

from query.

ardeora avatar ardeora commented on May 29, 2024

Hello! Yeah I just reworked the internals of createQuery that fixes a lot of these issues. If you update to v5.30.1+ It should fix the issues. Here it is working https://stackblitz.com/edit/solidjs-templates-xcihcy?file=package.json

@ardeora I can still repro this if I type oi quickly. Here is a screen recording from your StackBlitz: https://github.com/TanStack/query/assets/18402223/0e6fb515-a829-4800-acbb-d022c2acce18

This is a super weird issue which seems like a SolidJS cleanup issue. Could potentially be upstream but if this is a pressing issue, it seems to be solved if the inner component is wrapped in suspense too

https://stackblitz.com/edit/solidjs-templates-xcihcy?file=src%2FApp.tsx Her is the repro

from query.

ardeora avatar ardeora commented on May 29, 2024

I'm still investigating this actively and will have some updates soon (hopefully)

from query.

ardeora avatar ardeora commented on May 29, 2024

Another workaround using reconcile to keep the same DOM node intact

https://stackblitz.com/edit/solidjs-templates-ux7dqi?file=src%2FApp.tsx

from query.

ardeora avatar ardeora commented on May 29, 2024

Okay fully fixed with existing code https://stackblitz.com/edit/solidjs-templates-wvsree?file=src%2FApp.tsx

from query.

PeterDraex avatar PeterDraex commented on May 29, 2024

@ardeora Working! Thanks for this and for all the other fixes.

from query.

ardeora avatar ardeora commented on May 29, 2024

@ardeora Working! Thanks for this and for all the other fixes.

Anytime! ❤️ Thanks for taking the time and filing these issues. SolidQuery is in a much better spot because of these bug fixes

from query.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.