Git Product home page Git Product logo

Comments (2)

hollyos avatar hollyos commented on September 23, 2024

Diagnosis

Looks like the onPress event handler is getting interference from the web-specific behaviors. Specifically, the onFocus. My thinking is that if the first click sets the focus but does not immediately trigger the tab selection change. Then the second click, finding the tab already focused, successfully triggers the selection change.

Potential Resolution

Could try to adjust the event handling logic to ensure the tab change is triggered on the initial click regardless of the focus state.

Tabs.tsx#L247

  if (!disabled && !isSelected && webChecks) {
    context.onChange(value);

    if (!isSelected) {
      event.preventDefault();
    }
  } else {
    event.preventDefault();
  }

Notes

  • I'm just getting started with Tamagui. I'll give this a try and update soon

from tamagui.

wongk avatar wongk commented on September 23, 2024

This seems to have fixed itself. Closing.

from tamagui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.