Git Product home page Git Product logo

Comments (4)

hackily avatar hackily commented on September 2, 2024 1

Thanks for the tip! However, it seems that removing the animation prop doesn’t actually remove the animation, I just bumped the tamagui patch version from 1.108.3 to the latest, 1.108.4 and tried again.

To summarize what I've seen, there appears to be two issues here:

  1. We are unable to remove the animation off of the progress bar, regardless of if we provide animation prop as null, or do not provide animation at all, to either the indicator or the progressbar component.
  2. We are seeing the progress animate from right to left, even when explicitly using maxValue as 100, and a whole number value between 0-100

I'd appreciate if there's anything else you think I should try, and I'm happy to provide more info as well.

from tamagui.

MichaelGorski avatar MichaelGorski commented on September 2, 2024

@hackily you kinda have to multiply it by 100. it looks and is buggy if you use values which are lower than 100.
if you set your progress to 1 and max to 100, it properly shows the progressbar.
if you have like progress 1 and max10, you get the bug there.

@natew needs to fix the bug with with value and max range which calculates the diff from them and not only at 100 or something.

      <Progress size='$1.5' value={1} backgroundColor='#f4f4f5' max={10}>
        <Progress.Indicator animation='bouncy' backgroundColor='#18181b' />
      </Progress.Indicator>
Bildschirmfoto 2024-08-14 um 18 57 52
    <Progress size='$1.5' value={1} backgroundColor='#f4f4f5' max={100}>
       <Progress.Indicator animation='bouncy' backgroundColor='#18181b' />
     </Progress>
Bildschirmfoto 2024-08-14 um 18 58 41

from tamagui.

hackily avatar hackily commented on September 2, 2024

I'm not sure what you mean, the percent renders correctly, but I see a bouncing animation from right to left when I didn't want an animation.

I have the same animation if I pass a max, and even if I explicitly pass null for animation

<Progress height={10} backgroundColor="gray" value={value} max={100}>
  <Progress.Indicator backgroundColor="green" animation={null}/>
</Progress>
Screen.Recording.2024-08-14.at.2.02.41.PM.mov

from tamagui.

MichaelGorski avatar MichaelGorski commented on September 2, 2024

@hackily ah ok, I misread a bit the post. Thought you also meant the bug with the progress indicator, not showing the right progress :D

remove the animation prop from
<Progress.Indicator backgroundColor="green" animation={null}/>
to
<Progress.Indicator backgroundColor="green" />

and it removes the bouncy animation on init.

from tamagui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.