tallesl / net-l Goto Github PK

I see a few enhancement/change requests on the Reddit threads. Are there any that you want to implement that I could help with? Here are the ones I've seen so far.

• Use atomic appends https://www.reddit.com/r/dotnet/comments/5zt3cn/l_a_configless_logger_xpost_rcsharp/df1lhk6
• Add LogAsync method https://www.reddit.com/r/csharp/comments/5zt31e/l_a_zero_configuration_logging_library/df0vhh6/
• Ignore case of format name https://www.reddit.com/r/csharp/comments/5zt31e/l_a_zero_configuration_logging_library/df0vhh6/
• Remove static constructor https://www.reddit.com/r/csharp/comments/5zt31e/l_a_zero_configuration_logging_library/df0vhh6/

Hello,

We want to use net-L in our project. Could you add license information to the project?

Thanks,
Peter

When throwing an ArgumentNullException, nameof is not used which in the future could mean trouble if the parameter names change but the exception's message doesn't.

This can be fixed by using nameof!

Some people prefer their log more spaced (logs that includes stack traces for instance).

System.InvalidOperationException: 集合已修改；可能无法执行枚举操作。
在 System.ThrowHelper.ThrowInvalidOperationException(ExceptionResource resource)
在 System.Collections.Generic.Dictionary2.Enumerator.MoveNext() 在 System.Linq.Enumerable.WhereEnumerableIterator1.MoveNext()
在 LLibrary.OpenStreams.ClosePastStreams(Object ignored) 位置 A:\GitHub\net-L\Library\OpenStreams.cs:行号 54
在 System.Threading.TimerQueueTimer.CallCallbackInContext(Object state)
在 System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
在 System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
在 System.Threading.TimerQueueTimer.CallCallback()
在 System.Threading.TimerQueueTimer.Fire()
在 System.Threading.TimerQueue.FireNextTimers()
在 System.Threading.TimerQueue.AppDomainTimerCallback()

Hi, thanks for sharing.

Would you consider creating a signed version of the package assembly? This would mean that the assembly could be called by both signed and unsigned code. As it is it cannot be called by signed code. If not, would you be happy for me to fork it?

It's saving the file in the relative path /log. God knows where it goes when it's an web application.

Combine with AppDomain.CurrentDomain.BaseDirectory instead.