Git Product home page Git Product logo

twitch-wrapper-ts's People

Contributors

aalemayhu avatar nyasakiat avatar talha-t avatar timluq avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

Forkers

timluq

twitch-wrapper-ts's Issues

error TS2307: Cannot find module 'twitch-wrapper-ts'.

Hei,

when I try to update our project to use the latest twitch-wrapper-ts version with the colon fixes. I end up with the error below. Is it possible that I introduced a regression when bumping the dependencies in Try updating the package dependencies?

Thanks.

$ npm update --save
[...]
[email protected]
[...]
$ make build
[...]
ERROR in ./src/twitch/TwitchChat.ts
(1,51): error TS2307: Cannot find module 'twitch-wrapper-ts'.

ERROR in ./src/twitch/TwitchChat.ts
Module not found: Error: Can't resolve 'twitch-wrapper-ts' in '/Users/scanf/src/github.com/scanf/snake/src/twitch'
 @ ./src/twitch/TwitchChat.ts 1:0-43
 @ ./src/states/game.ts
 @ ./src/app.ts
 @ multi ./src/app.ts
[...]

parser.parseMessage assumes last colon is the broadcaster:message seperator

https://github.com/Talha-T/twitch-wrapper-ts/blob/master/src/parser.ts#L55

line 62: channel and content is seperated by last colon, hence if a message contains a colon the content and channel will be set to incorrect values.

Example message which results in bad behaviour:
PRIVMSG #twitch-user: http://twitch.tv

actual behaviour:
channel name: "#twitch-user: http"
content: "//twitch.tv"
expected behaviour:
channel name: "#twitch-user"
content: "http://twitch.tv"

Implement Api Response Types

Instead of getting with any, implement all types for all responses from Twitch. This will be finished at 1.0.0 release.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.