From @jmfrancois on August 12, 2016 8:1

Best error message always great :)

Copied from original issue: Talend/react-cmf#7

From @jmfrancois on August 12, 2016 8:58

Proposals:

store schema

• cmf
  -- settings
  -- component
  -- collection

each collection fetched from the server should be stored in cmf.collection.MY_COLLECTION_ID

Copied from original issue: Talend/react-cmf#9

From @talend-glorieux on November 21, 2016 9:29

There is a use case for inline forms. It looks like there isn't any support for it on react-jsonschema-form. Will need to handle it directly on react-talend-forms.

Copied from original issue: Talend/react-talend-forms#40

From @jmfrancois on August 12, 2016 7:50

Copied from original issue: Talend/react-cmf#6

From @frassinier on October 19, 2016 9:50

⚠️ We must deal with autoprefixer task with Webpack for this piece of code for example

Copied from original issue: Talend/react-talend-components#33

From @acateland on October 17, 2016 9:9

on this issue add a generated id and for poiting to this id

https://github.com/Talend/react-talend-components/pull/1/files#r83600138

Copied from original issue: Talend/react-talend-components#26

From @jillyan on December 23, 2016 9:4

in https://github.com/Talend/react-talend-components/blob/master/src/List/Toolbar/Filter/Filter.component.js
role="search" cause js error.

form
className="navbar-form navbar-right"
role="search"
onSubmit={onSubmit}

error:

unmountComponentAtNode(...): Target container is not a DOM element.
Invariant Violation: unmountComponentAtNode(...): Target container is not a DOM element.
    at invariant (webpack:///./~/fbjs/lib/invariant.js?:44:15)
    at Object.unmountComponentAtNode (webpack:///./~/react-dom/lib/ReactMount.js?:440:220)
    at OverlayTrigger.componentWillUnmount (webpack:///./~/react-bootstrap/lib/OverlayTrigger.js?:178:27)
    at eval (webpack:///./~/react-dom/lib/ReactCompositeComponent.js?:409:25)
    at measureLifeCyclePerf (webpack:///./~/react-dom/lib/ReactCompositeComponent.js?:75:12)
    at ReactCompositeComponentWrapper.unmountComponent (webpack:///./~/react-dom/lib/ReactCompositeComponent.js?:408:11)
    at Object.unmountComponent (webpack:///./~/react-dom/lib/ReactReconciler.js?:79:22)
    at ReactCompositeComponentWrapper.unmountComponent (webpack:///./~/react-dom/lib/ReactCompositeComponent.js?:418:23)
    at Object.unmountComponent (webpack:///./~/react-dom/lib/ReactReconciler.js?:79:22)
    at ReactCompositeComponentWrapper.unmountComponent (webpack:///./~/react-dom/lib/ReactCompositeComponent.js?:418:23)

Copied from original issue: Talend/react-talend-components#194

From @jmfrancois on August 11, 2016 14:52

When the settings are fetched it should be nice to validate them against a schema

Copied from original issue: Talend/react-cmf#2

From @jmfrancois on August 11, 2016 15:12

connect create a wrapper to let your component access to store.
But we also have i18n which need this.

This is the signal we may need other wrapper.

So should we create a function which create the needed wrapper with a simple API ?

uiWrapper(options)(MyComponent)

options should support connect, i18n and so on

Copied from original issue: Talend/react-cmf#5

From @jmfrancois on January 6, 2017 13:35

add missing deps

• yarn add babel-plugin-transform-object-assign
• yarn add redux-batched-actions
• yarn add immutable
• yarn add invariant
• yarn add lodash
• yarn add style-loader
• yarn add css-loader
• yarn add talend-bootstrap-theme
• yarn add react-talend-components
• yarn add react-talend-containers
• yarn add lodash react-router bootstrap-sass react react-addons-css-transition-group react-bootstrap talend-icons uuid react-bootstrap react-talend-components reselect

issue on the app

index.js:8Uncaught TypeError: (0 , _reactCmf.initializeStore) is not a function
    at Object.<anonymous> (index.js:8)
    at __webpack_require__ (bootstrap e967120…:19)
    at Object.<anonymous> (bootstrap e967120…:39)
    at __webpack_require__ (bootstrap e967120…:19)
    at bootstrap e967120…:39
    at bootstrap e967120…:39

->

import React from 'react'; // don't forget that for the compiler...
import { render } from 'react-dom';
import { actions, App, store as cmfstore } from 'react-cmf';

import configure from './configure';

configure.initialize();
const store = cmfstore.initialize();
store.dispatch(actions.settingsActions.fetchSettings('/settings.json'));

render(
	<App store={store} />,
	document.getElementById('app')
);

add settings json

{
  "contentTypes": {},
  "actions": {
  },
  "views":{
  },
  "routes": {
    "path": "/",
    "component": "App"
  },
  "ref": {
  }
}

Copied from original issue: Talend/generator-talend#25

Transfer https://github.com/Talend/react-talend-components/pull/237
Transfer https://github.com/Talend/react-talend-components/pull/253

transform non pure recursive function into pure ones, in route.js for example

will help a lot for code complexity and testing.

From @jmfrancois on August 12, 2016 8:17

With react-router you can use componentS

The main problem is to pass settings to theses components

Check route.js

Copied from original issue: Talend/react-cmf#8

From @amaalej on January 6, 2017 11:22

In released version: 0.45.0, there 2 new issues:
1 - Name actions are displayed on the very right of the table row instead of being close to the list item name.
2 - The column actions story is not working.

Copied from original issue: Talend/react-talend-components#217

From @jillyan on December 15, 2016 8:31

for example, in iam-ui

import TabsField from './TabsField.jsx';
...
const customFormFields = { TabsField };
<Form
 {...properties}
fields={customFormFields}
 />```


then my field TabsField can not be registered into form.

_Copied from original issue: Talend/react-talend-forms#54_

From @jsomsanith on November 25, 2016 16:28

@mmaillart has reworked the list selection checkboxes.
This need to we reworked in the List implementation.

The guideline

Copied from original issue: Talend/react-talend-components#123

From @jmfrancois on November 15, 2016 17:13

We should add this also in the generator.

The idea is to keep the name when the code is minified.

By default react compute the display name from the function / class component name;

It's a good practice to add displayName attribute;

Copied from original issue: Talend/react-talend-components#103

From @jlamiel on December 15, 2016 13:46

Component filter will need to handle list of complex elements.

Here is the (not up-to-date) mockup from Marc.

The description of the components itself can be found here : https://jira.talendforge.org/browse/TFD-168

Copied from original issue: Talend/react-talend-forms#55

From @jillyan on December 9, 2016 8:44

https://github.com/mozilla-services/react-jsonschema-form#custom-css-class-names
classNames in uiSchema doesn't work in react-talend-form

Copied from original issue: Talend/react-talend-forms#49

From @frassinier on November 29, 2016 13:49

Some of our components need to have some ARIA roles and states.

Copied from original issue: Talend/react-talend-components#132

Current tree view component doesn't allow using different icons for each item on the tree. However, in some cases we need to assign different icons to parents or have different types of parent or sub- folders - which may also be communicated through icons.

Reference: http://guidelines.talend.com/document/92132#/navigation-layout/tree-view

From @talend-glorieux on December 26, 2016 13:55

The SidePanel currently resets itself to the expanded view everytime the browser page is refreshed.
One good improvements would be to make sure that it appears in the same state as when the user last visit.
One way to do this would be to store the "docked" state on the browser localStorage and restore the SidePanel state from it at the next session.

Copied from original issue: Talend/react-talend-containers#25

https://facebook.github.io/jest/blog/2017/02/21/jest-19-immersive-watch-mode-test-platform-improvements.html

From @jlamiel on December 7, 2016 16:35

We need to have a title on a field, sometime parameter can be complex to understand, we might need to add some documentation or links to a field.

Related to that : Widget range doesn't show the title but show the value instead and ui:help is show as well

Copied from original issue: Talend/react-talend-forms#45

Now that all the packages are under the same roof, we can move all devDependencies to the top level.

From @jmfrancois on August 11, 2016 14:53

The goal is to first discuss some point and then provide an implementation in Pull request #23

Copied from original issue: Talend/react-cmf#4

From @charlesnguyen on November 9, 2016 11:18

Copied from original issue: Talend/react-talend-components#91

From @frassinier on September 20, 2016 16:2

I can see some FA classes but there is no FA dependency.
i.e. Form.js

Copied from original issue: Talend/react-talend-forms#6

From @acateland on October 27, 2016 7:41

List should raise a warning if the given props titleKey do not match on an given list object property.

Copied from original issue: Talend/react-talend-components#55

React router v4 just hit beta stage and its api is set in stone
https://twitter.com/mjackson/status/826114904914489344

Since V4 is a different beast than router V2/3 we should talk on how we will itegrate it into cmf and our apps.

Here will be collected documentation about our integration plan, links to various ressource etc.

FAQ
Bundle size ?
React Router V4 is lighter than V3/2.
What about the api change ?
React Router have completely different api for route handling and declaration wich is LOT simpler and more powerfull.
V2/3 version are dropped altogether ?
No V3 will be kept and maintened for sometime.

Please contribute in following comments.

// doc entry point
https://github.com/ReactTraining/react-router/tree/v4
// migration guide incomplete
Https://gist.github.com/mjackson/33f51e9d6b9ea18b467c613fbbcf50e1
// codepen playground
https://t.co/EUZkuDfowr

https://github.com/Talend/react-flow-designer

Currently we can only call backend services that returns an array of items to store it in CMF collections.

But TMC has pagination in place, their service returns :

{
    totalResults: 36,
    itemsPerPage: 25,
    startIndex: 1,
    Resources: [], // the items list
}

By default, CMF will store this entire object in store.cmf.collections.<provided_name>.
But with app settings, configuring a list you can only provide the collectionId. This means that the component will have the object instead of the list.

Since we need the whole information, a solution could be to pass a path instead collectionId to select a subset of that.
Or we need a solution to store the collection under the collectionId, but to store the other info somewhere else, in the actions.http.get() configuration.

See the topic.
What do you think?

This will help avoid writing:
{props.name && (<Icon name={props.name})}

From @amaalej on November 25, 2016 10:28

Copied from original issue: Talend/react-talend-components#121

From @amaalej on January 4, 2017 12:40

Due to https://github.com/Talend/react-talend-components/pull/205, Tile and Large display modes should be supported UX/implementation.

Copied from original issue: Talend/react-talend-components#206

From @jlamiel on December 7, 2016 16:38

Example :
"default": "gs://temp",
"pattern": "^gs://(.?([^/]+))$"
right now the message is : does not match pattern "^gs://(.?([^/]+))$"

Copied from original issue: Talend/react-talend-forms#47

The generated eslint.txt and sass-lint.txt files are creating conflicts with the master branch.
We need to force there resolution.

From @jillyan on January 16, 2017 3:42

according to guidlines, each item in list has the following actions:
Single click on item background selects it.
Double click on item background opens it.
http://guidelines.talend.com/document/92132#/navigation-layout/list

But now, there are no single or double click actions.

I tried to add onClick into related tr/div, it will get eslint-disable-line jsx-a11y/no-static-element-interactions error. And another pb, the input checkbox's onChange will trigger this onClick as well, so if user checked the checkbox, it would select the same item two times.
ah, really like a stalement

Copied from original issue: Talend/react-talend-components#244

https://github.com/Talend/ui/blob/master/packages/cmf/docs.json#L34
and
https://github.com/Talend/ui/blob/master/packages/cmf/LICENSE#L1

From @yyanwang on October 24, 2016 3:21

Currently we have Dropdown widget, which is nice, but I would like to add support of filtering to it. For example, in our app, we provide user a dropdown to select his/her timezone, which have lots of options, so it would be nice to filter the option list base on input. something like this:

I already have this filtering dropdown component in our project, so it would be easy to add it in talend form, and I can do this in either way:
1- extend existing dropdown;
2- OR add a separate widget for this purpose.

What do you guys think?

Copied from original issue: Talend/react-talend-forms#24

From @Peiren on November 23, 2016 9:2

Copied from original issue: Talend/react-talend-components#110

Enhancement to #100

If you update with the last form lib you will not have the global rjsf class.

please add a new global class for our forms

I vote for tform or talend-form