Git Product home page Git Product logo

Comments (1)

taiki-e avatar taiki-e commented on May 27, 2024

@Aaron1011
Personally, I prefer to open PR as a draft and let CI do those checks but I agree that this is helpful. However, it takes a lot of time to do exactly the same checks that CI does. (FYI: This is a script to run exactly the same checks done by CI.)

So I am thinking of adding the simplified version.

As far as I know, this can detect most cases with the following exceptions.

  • If you already have nightly rust, clippy, and rustfmt installed and it is not up to date. (this can happen even with the full version of ci.sh)
  • If you add a new dependency that does not support -Zminimal-versions.
  • If you use a feature that is not supported by Rust 1.33.

In addition, the following cases will cause an error.

  • If clippy is not available on the latest nightly.
  • If rustfmt is not available on your default toolchain. (this can happen even with the full version of ci.sh)

Any thoughts?

from pin-project.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.