Git Product home page Git Product logo

Comments (5)

taiki-e avatar taiki-e commented on July 4, 2024 2

Fixed in pin-peoject 0.4.24 and pin-project-lite 0.1.8

from pin-project.

Aaron1011 avatar Aaron1011 commented on July 4, 2024 1

I think it would be fine for pin-project-lite to use #[forbid], though.

from pin-project.

Aaron1011 avatar Aaron1011 commented on July 4, 2024

It looks like you're actually using pin_project_lite.

This looks like a bug in rustc - it's emitting an error about this #[deny(safe_packed_borrows)] getting 'overruled'. I think that error is only supposed to occur when a #[warn] or #[allow] get overruled.

from pin-project.

taiki-e avatar taiki-e commented on July 4, 2024

I definitely do not recommend using forbid on the lints other than unsafe_code lint. They will constant improvement/change, and code that was not warned at the release time may become unavailable. Especially for lint groups like future_incompatible, it's possible that a new lint will be added.

That said, as @Aaron1011 said, this can be easily fixed by switching #[deny(safe_packed_borrows)] to #[forbid(safe_packed_borrows)], so I'll do that.


This looks like a bug in rustc - it's emitting an error about this #[deny(safe_packed_borrows)] getting 'overruled'. I think that error is only supposed to occur when a #[warn] or #[allow] get overruled.

I guess this is intentional behavior, as it should be possible to allow lint in scopes where lint is denied, but it's certainly not intuitive...

from pin-project.

yoshuawuyts avatar yoshuawuyts commented on July 4, 2024

They will constant improvement/change, and code that was not warned at the release time may become unavailable.

I hadn't given this enough thought, and you're absolutely right. I'll have to revise this. Thank you!

from pin-project.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.