Comments (5)
Fixed in pin-peoject 0.4.24 and pin-project-lite 0.1.8
from pin-project.
I think it would be fine for pin-project-lite
to use #[forbid]
, though.
from pin-project.
It looks like you're actually using pin_project_lite
.
This looks like a bug in rustc - it's emitting an error about this #[deny(safe_packed_borrows)]
getting 'overruled'. I think that error is only supposed to occur when a #[warn]
or #[allow]
get overruled.
from pin-project.
I definitely do not recommend using forbid
on the lints other than unsafe_code
lint. They will constant improvement/change, and code that was not warned at the release time may become unavailable. Especially for lint groups like future_incompatible
, it's possible that a new lint will be added.
That said, as @Aaron1011 said, this can be easily fixed by switching #[deny(safe_packed_borrows)]
to #[forbid(safe_packed_borrows)]
, so I'll do that.
This looks like a bug in rustc - it's emitting an error about this
#[deny(safe_packed_borrows)]
getting 'overruled'. I think that error is only supposed to occur when a#[warn]
or#[allow]
get overruled.
I guess this is intentional behavior, as it should be possible to allow lint in scopes where lint is denied, but it's certainly not intuitive...
from pin-project.
They will constant improvement/change, and code that was not warned at the release time may become unavailable.
I hadn't given this enough thought, and you're absolutely right. I'll have to revise this. Thank you!
from pin-project.
Related Issues (20)
- pin_project cannot be used with structs that hold mutable references HOT 4
- "unused result" warning with 0.4.18 HOT 2
- ?Sized type parameters don't work
- Tracking issue for 1.0.0 release HOT 5
- Prepare for uplift of drop-bounds lint HOT 3
- #[pin_project] panics with `internal error: entered unreachable code` when used inside a MBE with vis HOT 2
- error: cannot find attribute `derive` in this scope HOT 3
- Rust-Analyzer compatibility HOT 7
- Cannot build with RUSTFLAGS="-Zsanitizer=address" HOT 2
- Leaked UB in enums HOT 10
- Ambiguous macro use does not compile HOT 3
- `parse_quote_spanned` macro name-collides with `syn::parse_quote_spanned` HOT 1
- #![feature(negative_impls)] breaks the guarantee for Unpin provided by pin-project HOT 1
- Can bypass #[repr(packed)] checking since rust 1.57 HOT 2
- Allow #[pin_project(!Unpin)] to `impl !Unpin` HOT 1
- provide project method on `&mut Pin<&mut Self>` HOT 2
- Why was 1.0.10 yanked from crates.io? HOT 6
- Pin-projecting in-line tuples HOT 2
- docs: Add FAQ section?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pin-project.