Git Product home page Git Product logo

Comments (8)

Aaron1011 avatar Aaron1011 commented on June 7, 2024 1

Mention #32 in the documents can be checked off/removed, now that the issue is closed.

from pin-project.

taiki-e avatar taiki-e commented on June 7, 2024

I don't list it as a blocker, but rust-lang/rust#63281 is one of the issues to consider.

from pin-project.

taiki-e avatar taiki-e commented on June 7, 2024

@Aaron1011 thanks 👍

from pin-project.

taiki-e avatar taiki-e commented on June 7, 2024

Published 0.4.0-alpha.1 (crate.io, releases, docs)!

from pin-project.

taiki-e avatar taiki-e commented on June 7, 2024

UPDATE: Replaced with #89

TR; DR: Added "Whether or not self: &mut Pin<&mut Self> stabilizes in Rust 1.39" (rust-lang/rust#64325) to blocker list.

rust-lang/rust#64325 stabilizes self: &mut Pin<&mut Self>.
This removes some of the hacks introduced in #47.
It can also solve some existing problems (e.g., tower-rs/tower#326 (comment)).

However, this means will take a different approach between versions prior to 1.39 and versions 1.39 or later. This should not break compatibility, but it will cause a feature that is "supported only with rust 1.39 or later". Specifically, it is a feature that "project/project_into method can be called outside the defined scope" that is planned to be provided by #80.

Also, if stabilization is delayed, the impact on crate using async / await (e.g., tower) is too big, so merge #80 to make those features available in versions 1.39 and earlier.

from pin-project.

taiki-e avatar taiki-e commented on June 7, 2024

Resolved #26 and added "Change the argument type of project method back to self: Pin<&mut Self>" (#89) to unresolved issue list.

from pin-project.

taiki-e avatar taiki-e commented on June 7, 2024

I have filed #107 to fix #102. Once #107 is merged, I will release 0.4.0. As documentation fixes are no breaking changes, will be fixed in the patch versions.

from pin-project.

taiki-e avatar taiki-e commented on June 7, 2024

Published 0.4.0. Thanks everybody for your contribution and feedback (especially @Aaron1011!).

from pin-project.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.