🚀 Feature request

Is your feature request related to a problem?

The issue is with the current implementation of micro-sentry library. In the original sentry library for JS, we can use the beforeSend hook to filter out events that we do not want to send to sentry by simply returning null from beforeSend. However, in micro-sentry, the type defined for the return value of the beforeSend hook does not allow returning null, making it impossible to use beforeSend for event filtering.

Describe the solution you'd like

I would like to suggest adjusting the logic of the library so that it allows returning null from the beforeSend hook for event filtering purposes.

Additional context

This feature enhancement would provide more flexibility to users of micro-sentry when it comes to filtering events before sending them to the sentry service. It would align the behavior of micro-sentry with the original sentry library for JS and improve the overall usability of the library.

🚀 Feature request

Is your feature request related to a problem?

At the moment you can use only MicroSentryErrorHandler class for ErrorHandler implementation without any additional preparations. And it makes sense if your app uses only 1 ErrorHandler which is good and by Angular design. I faced with situation when the App uses multiple ErrorHandler in conjunction with kind of Visitor pattern. So i could not just use your MicroSentryErrorHandler and i had to use MicroSentryService directly. But then i had to declare MICRO_SENTRY_CONFIG token which has MicroSentryModuleOptions type that you don't export from lib. Of course i could use any type but i wanted more type-safety feature.

Describe the solution you'd like

Export BrowserSentryClientOptions type from lib for more flexibility purposes

Additional context

Who faced with such issue you can use workaround:

import { MicroSentryService } from '@micro-sentry/angular';

type MicroSentryModuleOptionsParams = ConstructorParameters<typeof MicroSentryService>;
type FirstElemFromTuple<T extends unknown[]> = T extends [infer R, unknown] ? R : never;
export type MicroSentryModuleOptions = FirstElemFromTuple<MicroSentryModuleOptionsParams>;

Then you will get BrowserSentryClientOptions type

🐞 Bug report

Description

When using @sentry/angular-ivy I can define a beforeBreadcrumb callback to adjust a breadcrumb before it is persisted, or I can return null for the breadcrumb to be ignored.

Unfortunately the beforeBreadcrumb method of micro-sentry does not accept null as the return type. If I work around that by doing return null as unknown as Breadcrumb unfortunately there is still a (empty) breadcrumb being sent to GlitchTip.

Reproduction

beforeBreadcrumb: (breadcrumb) => {
// ignore XHR requests for `.svg` files
  if (
    breadcrumb.category === 'xhr' &&
    breadcrumb.data?.['method'] === 'GET' &&
    (breadcrumb.data?.['url'] as string | undefined)?.endsWith('.svg')
  ) {
    // // does not work, an empty breadcrumb is still rendered in GlitchTip
    return null as unknown as Breadcrumb; 
  }

  return breadcrumb;
},

Expected behavior

Allow null as return type for beforeBreadcrumb and ignore the breadcrumb if it's null

Versions

7.0.3

🐞 Bug report

Description

I call setUser on login with the user's details and would like to clear the user on logout. Unfortunately there is no method clearUser and setUser does not allow to be called with null.

In @sentry/angular-ivy what I do is get the current scope and call scope.setUser(null) on it.

Expected behavior

Add a new method clearUser or allow calling setUser with null.

Versions

"@micro-sentry/angular": "~7.0.2",

🐞 Bug report

Description

We are calling Sentry.report(new Error('Something bad happened'), {cause: 'Some useful context about the bad thing'}) on a micro-sentry client, but we only see the "Something bad happened" message in sentry.io. I would expect the cause to appear under the "extras" section in the Sentry UI. It's not in the JSON payload sent to sentry a all though

Reproduction

I don't know that it's possible to reproduce in stackblitz since it's about what gets sent to sentry, but it should be easy to reproduce if you have a local sentry set up. Just create a new @micro-sentry/browser client and call the code snippet above.

Expected behavior

Include cause (MDN docs)

Versions

• Package [e.g. @micro-sentry/[email protected]]

If needed:

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Angular/React/Vue [e.g. Angular 11]

Additional context

Docs improvements

Is your feature request related to a problem?

Tried to figure out purposes of all methods inside library classes and it was not obvious and quite difficult without calling them.
It's gonna be very helpful if you can add js-doc for each methods and props

Describe the solution you'd like

Add js-doc for methods

Additional context

Anyway highly appreciate your efforts to develop such library. Thank you guys

(not sure if bug or feature request)

I view reported issues in GlitchTip. In the Additional Data section, which I populate using setExtra every string is wrapped in quotes, and every JSON object (which I already stringified because setExtra only accepts strings) is escaped with backslashes, leading to very unreadable JSON data.

Request:

Either allow passing objects to setExtra or do not stringify string properties a second time