Git Product home page Git Product logo

leader_board's People

Contributors

tafaramafemba avatar

Stargazers

 avatar  avatar

Watchers

 avatar

Forkers

alexr16

leader_board's Issues

Peer-Code-Review-Session 2022-03-25

Good Points ๐Ÿ‘

  • Good naming practice.
  • Clean HTML and CSS structure.
  • Nice and simple UI.

To take note ๐Ÿ“

  • To make a separation of concerns, it would be better to create one class for the tasks (data management) and another for the UI actions.
  • Kindly organize your image assets in another folder to improve file structure.
  • If you take your data array out of your constructor function and place it in the global scope, your code would be more organized, and the data will not be dependent on one object instantiation.
  • Would look better if the input field would take 100% of the width of the list item.

Peer to peer code review

  • Code is very fine ๐Ÿ‘

  • Readable and easy to understand ๐Ÿ’ฏ

  • Modularize the file api.js ::four_leaf_clover:

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.