taeh98 / fibonacci Goto Github PK

The for loop for printing the whole Fibonacci sequence to a given term number is not working. I think it's at least partly due to the failure for the i value in the loop, representing the term number, to increase over each loop. When I work on the code again tomorrow, I'll try to fix this, and fully transition from using a for loop to find the value of a specified term number to using a formula, using Phi or root 5.

Due to integer overflows (if you don't know basically when a number exceeds the maximum size for the data type being used - https://en.wikipedia.org/wiki/Integer_overflow), the program can currently only run to the 92nd term. This is because after that the numbers generated exceed the maximum values for the long types I'm currently using to represent the numbers being added.

To fix this, I'm going to convert from using longs to using BigIntegers instead. I think that has a possibility of crashing the computer though because, as the name suggests, they can get quite big. Maybe I can put a limit on the time to run the for loop once? Or ideally the strain on hardware (like the CPU) and the state of the memory being used by Java. That's probably pretty difficult to implement though, so maybe just a maximum number of terms/loops (but that surely defeats the purpose of the program?).