tactivos / grunt-rev-md5 Goto Github PK

Seems like the there is a line break in the tag, the plugin won't append the md5.

So it will work for:

<script src="abc.js></script>

but won't for:

<script
src="abc.js></script>

I guess it happens because it reads the file line after line and analyze each line separately.
Would it make sense to read the file as a DOM element and work by nodes?

I'm posting this issue to let you know that we will be publishing Grunt 0.4 on Monday, February 18th.

If your plugin is not already Grunt 0.4 compatible, would you please consider updating it? For an overview of what's changed, please see our migration guide.

If you'd like to develop against the final version of Grunt before Monday, please specify "grunt": "0.4.0rc8" as a devDependency in your project. After Monday's release, you'll be able to use "grunt": "~0.4.0" to actually publish your plugin. If you depend on any plugins from the grunt-contrib series, please see our list of release candidates for compatible versions. All of these will be updated to final status when Grunt 0.4 is published.

Also, in an effort to reduce duplication of effort and fragmentation in the developer community, could you review the grunt-contrib series of plugins to see if any of your functionality overlaps significantly with them? Grunt-contrib is community maintained with 40+ contributors—we'd love to discuss any additions you'd like to make.

Finally, we're working on a new task format that doesn't depend on Grunt: it's called node-task. Once this is complete, there will be one more conversion, and then we'll never ask you to upgrade your plugins to support our changes again. Until that happens, thanks for bearing with us!

If you have any questions about how to proceed, please respond here, or join us in #grunt on irc.freenode.net.

Thanks, we really appreciate your work!

stampUrl just does return; for absolute urls and html parser does not check to return value of stampUrl

Console output: Warning: Arguments to path.join must be strings Use --force to continue.

Test cases:
background: url('about:blank');
behavior: url(#default#VML);

type and filename values are included when output warnings messages.

There is also a bad reference to file when calculating the filePath, it should be filename instead

The following markup

<img src="{{avatarUrl.thumb}}" alt="{{username}}">

is being replaced with something like this

<img src="{{avatarUrl.thumb}}?v=679059" alt="{{username}}">

It would be usefult to have the task creating a json manifest file where all the hashes are stored, something like:

{
  "original/file/one": "22324hdvtyd6vchdcs7vc"
}

Hi,

I have this use case on a project using Handlebars templates. All my images src are relative to the application directory, not the template file directory, because at the end all my templates are compiled and concatenated.

It would be great to have an option to indicate if it's relative to source file or gruntfile (application directory) with default to actual behaviour which is relative to source file.

What do you think?