t9md / atom-cursor-history Goto Github PK

View Code? Open in Web Editor NEW

59.0 59.0 7.0 259 KB

Cursor position history manager

Home Page: https://atom.io/packages/cursor-history

License: MIT License

CSS 1.07% JavaScript 98.93%

atom cursor-history

atom-cursor-history's Introduction

personal image registories for my oss project

atom-cursor-history's People

Contributors

Stargazers

Watchers

Forkers

akylas liwangqian christensson cdbattags pixel-perfect-metodology

atom-cursor-history's Issues

Uncaught Error: This TextEditor has been destroyed

/Applications/Atom.app/Contents/Resources/app.asar/src/display-buffer.js:1022
Hide Stack Trace
Error: This TextEditor has been destroyed
  at DisplayBuffer.module.exports.DisplayBuffer.screenPositionForBufferPosition (/Applications/Atom.app/Contents/Resources/app.asar/src/display-buffer.js:1022:15)
  at Marker.module.exports.Marker.getHeadScreenPosition (/Applications/Atom.app/Contents/Resources/app.asar/src/marker.js:176:33)
  at new Marker (/Applications/Atom.app/Contents/Resources/app.asar/src/marker.js:36:41)
  at DisplayBuffer.module.exports.DisplayBuffer.getMarker (/Applications/Atom.app/Contents/Resources/app.asar/src/display-buffer.js:1247:20)
  at Marker.module.exports.Marker.copy (/Applications/Atom.app/Contents/Resources/app.asar/src/marker.js:58:33)
  at /Users/t9md/github/cursor-history/lib/history.coffee:54:42
  at Array.map (native)
  at History.module.exports.History.add (/Users/t9md/github/cursor-history/lib/history.coffee:54:19)
  at Object.module.exports.handleCursorMoved (/Users/t9md/github/cursor-history/lib/main.coffee:78:14)
  at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:82:11)
  at TextEditor.module.exports.TextEditor.cursorMoved (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor.js:1565:27)
  at /Applications/Atom.app/Contents/Resources/app.asar/src/cursor.js:56:31
  at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:82:11)
  at Marker.module.exports.Marker.resumeChangeEvents (/Applications/Atom.app/Contents/Resources/app.asar/src/marker.js:287:24)
  at DisplayBuffer.module.exports.DisplayBuffer.resumeMarkerChangeEvents (/Applications/Atom.app/Contents/Resources/app.asar/src/display-buffer.js:1393:16)
  at DisplayBuffer.module.exports.DisplayBuffer.emitDidChange (/Applications/Atom.app/Contents/Resources/app.asar/src/display-buffer.js:298:19)
  at DisplayBuffer.module.exports.DisplayBuffer.updateWrappedScreenLines (/Applications/Atom.app/Contents/Resources/app.asar/src/display-buffer.js:308:19)
  at DisplayBuffer.module.exports.DisplayBuffer.setWidth (/Applications/Atom.app/Contents/Resources/app.asar/src/display-buffer.js:445:14)
  at TextEditor.module.exports.TextEditor.setWidth (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor.js:2762:33)
  at TextEditorPresenter.module.exports.TextEditorPresenter.setContentFrameWidth (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-presenter.js:1076:20)
  at TextEditorComponent.module.exports.TextEditorComponent.measureDimensions (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-component.js:853:24)
  at TextEditorComponent.module.exports.TextEditorComponent.becameVisible (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-component.js:267:12)
  at TextEditorComponent.module.exports.TextEditorComponent.checkForVisibilityChange (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-component.js:810:16)
  at atom-text-editor.TextEditorElement.attachedCallback (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-element.js:95:22)
  at atom-pane-container.module.exports.PaneContainerElement.rootChanged (/Applications/Atom.app/Contents/Resources/app.asar/src/pane-container-element.js:53:14)
  at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:82:11)
  at PaneContainer.module.exports.PaneContainer.setRoot (/Applications/Atom.app/Contents/Resources/app.asar/src/pane-container.js:187:20)
  at PaneContainer.module.exports.PaneContainer.replaceChild (/Applications/Atom.app/Contents/Resources/app.asar/src/pane-container.js:197:19)
  at PaneAxis.module.exports.PaneAxis.reparentLastChild (/Applications/Atom.app/Contents/Resources/app.asar/src/pane-axis.js:221:19)
  at PaneAxis.module.exports.PaneAxis.removeChild (/Applications/Atom.app/Contents/Resources/app.asar/src/pane-axis.js:186:21)
  at /Applications/Atom.app/Contents/Resources/app.asar/src/pane-axis.js:229:24
  at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:82:11)
  at Pane.module.exports.Pane.destroyed (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:629:20)
  at Pane.module.exports.Model.destroy (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/theorist/lib/model.js:218:14)
  at Pane.module.exports.Pane.destroy (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:620:39)
  at Pane.module.exports.Pane.removeItem (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:394:21)
  at Pane.module.exports.Pane.destroyItem (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:442:16)
  at Pane.module.exports.Pane.destroyActiveItem (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:419:12)
  at Workspace.module.exports.Workspace.destroyActivePaneItem (/Applications/Atom.app/Contents/Resources/app.asar/src/workspace.js:593:35)
  at Workspace.module.exports.Workspace.destroyActivePaneItemOrEmptyPane (/Applications/Atom.app/Contents/Resources/app.asar/src/workspace.js:632:21)
  at atom-workspace.atom.commands.add.core:close (/Applications/Atom.app/Contents/Resources/app.asar/src/workspace-element.js:307:30)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:238:29)
  at /Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61
  at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:519:16)
  at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:354:22)
  at HTMLDocument.module.exports.WindowEventHandler.onKeydown (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:178:20)
The error was thrown from the cursor-history package. You can help by creating an issue. Please explain what actions triggered this error.
Create issue on the cursor-history package

Uncaught TypeError: this.getHistory(...).log is not a function

Steps to reproduce

open a file in Atom
move cursor to a location over the row delta limit
call Cursor History: Dump History

Atom: 1.24.0 x64
Electron: 1.6.16
OS: Mac OS X 10.12.6
Thrown From: cursor-history package 0.13.0

Stack Trace

Uncaught TypeError: this.getHistory(...).log is not a function

At /Users/martin/.atom/packages/cursor-history/lib/main.js:76

TypeError: this.getHistory(...).log is not a function
    at /packages/cursor-history/lib/main.js:76:64)
    at CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app/src/command-registry.js:388:36)
    at Object.didConfirmSelection (/Applications/Atom.app/Contents/Resources/app/node_modules/command-palette/lib/command-palette-view.js:165:35)
    at SelectListView.confirmSelection (/Applications/Atom.app/Contents/Resources/app/node_modules/command-palette/node_modules/atom-select-list/src/select-list-view.js:401:26)
    at HTMLDivElement.core:confirm (/Applications/Atom.app/Contents/Resources/app/node_modules/command-palette/node_modules/atom-select-list/src/select-list-view.js:106:20)
    at CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app/src/command-registry.js:388:36)
    at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Applications/Atom.app/Contents/Resources/app/node_modules/atom-keymap/lib/keymap-manager.js:621:22)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app/node_modules/atom-keymap/lib/keymap-manager.js:412:28)
    at WindowEventHandler.handleDocumentKeyEvent (/Applications/Atom.app/Contents/Resources/app/src/window-event-handler.js:108:40)

Commands

     -2:18.9.0 command-palette:toggle (input.hidden-input)
     -2:17.9.0 core:backspace (input.hidden-input)
 10x -2:15.6.0 core:move-down (input.hidden-input)
  2x -2:13.3.0 core:move-up (input.hidden-input)
     -2:12 core:confirm (input.hidden-input)
     -2:12 cursor-history:next-within-editor (input.hidden-input)
     -2:08.2.0 command-palette:toggle (input.hidden-input)
     -2:02.9.0 cursor-history:prev-within-editor (input.hidden-input)
     -2:00.2.0 command-palette:toggle (input.hidden-input)
  7x -1:56.1.0 core:move-down (input.hidden-input)
  2x -1:54.6.0 core:move-up (input.hidden-input)
     -1:54 core:confirm (input.hidden-input)
     -1:54 cursor-history:next-within-editor (input.hidden-input)
     -0:39.2.0 command-palette:toggle (input.hidden-input)
     -0:32.3.0 core:confirm (input.hidden-input)
     -0:32.3.0 cursor-history:dump-history (input.hidden-input)

Non-Core Packages

aligner 1.2.4 
aligner-coffeescript 1.0.1 
aligner-css 1.2.1 
aligner-javascript 1.3.0 
aligner-ruby 1.6.1 
aligner-typescript 1.0.0 
atom-ide-ui 0.9.2 
autocomplete-gemfile 0.0.5 
autocomplete-xml 0.9.4 
build 0.70.0 
build-osa 0.7.2 
build-rake 0.1.1 
busy-signal 1.4.3 
city-lights-icons 1.1.1 
city-lights-syntax 1.1.8 
city-lights-ui 1.3.3 
cursor-history 0.13.0 
dash 1.7.1 
editorconfig 2.2.2 
ide-css 0.2.0 
ide-html 0.4.2 
ide-json 0.2.1 
ide-typescript 0.7.5 
ide-yaml 0.4.2 
js-refactor 0.7.5 
keymap-control 1.2.0 
language-applescript 0.3.0 
language-fish-shell 1.1.0 
language-javascript-jxa 0.2.8 
language-m 1.0.1 
language-markdown 0.25.1 
mac-move-and-select 0.3.0 
markdown-scroll-sync 2.1.2 
open-project-in-tower 1.4.0 
open-terminal-here 2.3.1 
plist-converter 0.2.0 
refactor 0.11.5 
ruby-solargraph 0.2.0 
script 3.17.3 
teacode-atom-helper 1.1.0 
todo-show 2.2.0 
tree-view-bundler 0.0.3 
update-changelogs 0.1.0 
vim-mode-plus 1.30.0

Failed to activate the cursor-history package

[Enter steps to reproduce below:]

Atom Version: 0.187.0
System: linux 3.13.0-48-generic
Thrown From: cursor-history package, v0.5.5

Stack Trace

Failed to activate the cursor-history package

At undefined is not a function

TypeError: undefined is not a function
  at Object.module.exports.observeCommands (/home/karan/.atom/packages/cursor-history/lib/main.coffee:111:38)
  at Object.module.exports.activate (/home/karan/.atom/packages/cursor-history/lib/main.coffee:39:6)
  at Package.module.exports.Package.activateNow (/usr/share/atom/resources/app/src/package.js:240:19)
  at /usr/share/atom/resources/app/src/package.js:221:30
  at Package.module.exports.Package.measure (/usr/share/atom/resources/app/src/package.js:167:15)
  at Package.module.exports.Package.activate (/usr/share/atom/resources/app/src/package.js:214:14)
  at PackageManager.module.exports.PackageManager.activatePackage (/usr/share/atom/resources/app/src/package-manager.js:465:21)
  at /usr/share/atom/resources/app/node_modules/settings-view/lib/package-manager.js:226:29
  at exit (/usr/share/atom/resources/app/node_modules/settings-view/lib/package-manager.js:43:16)
  at BufferedProcess.triggerExitCallback (/usr/share/atom/resources/app/src/buffered-process.js:63:47)
  at /usr/share/atom/resources/app/src/buffered-process.js:70:18
  at Socket.<anonymous> (/usr/share/atom/resources/app/src/buffered-process.js:150:18)
  at Socket.emit (events.js:138:20)
  at Pipe.close (net.js:477:12)

Commands

     -0:09.0 settings-view:check-for-package-updates (atom-workspace.workspace.scrollbars-visible-always.theme-atom-dark-syntax.theme-atom-dark-ui)

Config

{
  "core": {
    "disabledPackages": [
      "autocomplete-plus",
      "autocomplete-plus-python-jedi"
    ]
  },
  "cursor-history": {}
}

Installed Packages

# User
autocomplete-html, v0.7.2
color-picker, v1.7.0
cursor-history, v0.5.5
minimap, v4.10.0
react, v0.12.10

# Dev
No dev packages

Multi pane support with same file

With multiple panes open, and having the same file open in multiple panes, there is still just one history stored, which is always applied to the first (left most) pane. So, when jumping in another pane (say the right one) and then pressing the shortcut to go back to the previous location the cursor jumps back to the old line I was on in the right pane, but does so in the left pane. The cursor in the right pane is left unchanged.
This is not only confusing when describing it, in reality it is even more... ;-)

Don't save to history while symbols-views temporal scroll.

As far as I considered, there is no way to distinguish temporal movement or actual movement.
So currently I don't think I can solve this issue.

Support from Atom side or symbols-view side is required to solve this problem.

I created issue to symbols-view https://github.com/atom/symbols-view/issues.

Separate cursor histories per pane?

Hi there – first, thank you for all your work on this, vim-mode-plus, and your other packages. They're amazing, especially for vim heads like myself.

There's one way in which this package's behavior differs from Vim's jumplist: whereas this package maintains only one global 'jumplist', Vim maintains separate jumplists for each of its windows. In Vim, if you split a window, the jumplist of the original window gets copied, but then their histories can then diverge. So once a window is split, you can follow tags, open other buffers, etc. in one window without affecting the jumplist of the other window. Apparently I've become quite used to that behavior, so the way atom-cursor-history behaves sometimes trips me up.

Would you consider adding a feature to support separate cursor histories for each pane, or is that outside the scope of what you're looking to do with this package?

[feature request] Mouse button support

It will be great if one can use mouse button 3 and 4 (configurable) to do the jump back/forward.

cursor-history:next won't work

Hey there!

First of all, thanks for this great package… 🙏

Whenever I can easily jump backwards with cursor-history:prev (mapped to ctrl--), but then it seems cursor-history:next won't work (mapped to ctrl-shift--). The issue doesn't seem to be realted to keymapping, because even calling cursor-history:next from the command palette won't work.

Here's how I expect this to work:

A-B-C  <prev>  A-B-C  <prev>  A-B-C  <next>  A-B-C  <prev>  A-B-C
    ^            ^            ^                ^            ^

Regardless of the right-most <prev> in the illustration above, the only <next> in there, won't actually move it to B, but the cursor will stay at A 😞 .

Any ideas?

Using Atom 1.21.1 and cursor-history 0.12.0 with the following keymap:

'atom-workspace':
  'ctrl--': 'cursor-history:prev'
  'ctrl-shift--': 'cursor-history:next'
  'ctrl-alt--': 'cursor-history:prev-within-editor'
  'ctrl-alt-shift--': 'cursor-history:next-within-editor'

After renaming a file, cursor-history:prev opens a new blank file with the old file name

This is a great tool, I've been using it for a few weeks before I noticed this issue.

Steps to reproduce:

edit file A and save
Use atom to rename A to B
browse to file C
call cursor-history:prev.
result) Atom opens a blank file named A

Expected:
result) Atom opens B at the same line the cursor had been at

add next-file, prev-file which skip cursor position of same buffer.

Suggested in #18.

Should use `oldBufferPosition` to save history rather than `newBufferPosition`

Current implementation use newBufferPosition.
Its not intuitive UX perspective.
This change need model (history) change.

new option `keepSingleEntryPerBuffer`

Continuation of #18, I tried #20 but failed, so pick this simple approach.
Add new config option keepSingleEntryPerBuffer. disabled by default.
If enabled(=set to true), it keep only one position per buffer(=file).
So user can always jump to different file.

Leak subscriptions

Please check.

Uncaught TypeError: Cannot read property 'length' of undefined

Encountering errors for almost all new click in the new updated. This did not occur in the previous release of atom-cursor-history.

Click anywhere in a file

Atom: 1.17.0-beta3 x64
Electron: 1.3.14
OS: Mac OS X 10.12.4
Thrown From: cursor-history package 0.10.0

Stack Trace

Uncaught TypeError: Cannot read property 'length' of undefined

At /Users/runarkristoffersen/.atom/packages/cursor-history/lib/history.coffee:131

TypeError: Cannot read property 'length' of undefined
    at History.module.exports.History.uniqueByBuffer (/packages/cursor-history/lib/history.coffee:131:27)
    at /packages/cursor-history/lib/history.coffee:11:8
    at Config.module.exports.Config.observeKeyPath (/Applications/Atom Beta.app/Contents/Resources/app/src/config.js:625:1)
    at Config.module.exports.Config.observe (/Applications/Atom Beta.app/Contents/Resources/app/src/config.js:150:1)
    at /packages/cursor-history/lib/history.coffee:10:35)
    at Object.getHistory (/packages/cursor-history/lib/main.coffee:53:21)
    at Object.checkLocationChange (/packages/cursor-history/lib/main.coffee:129:10)
    at /packages/cursor-history/lib/main.coffee:68:12

Commands

     -4:22.5.0 tree-view:show (atom-workspace.workspace.scrollbars-visible-when-scrolling)

Non-Core Packages

aligner-python 1.0.1 
atom-alignment 0.12.1 
atom-beautify 0.29.23 
atom-clock 0.1.7 
atom-css-clean 2.19.6 
atom-dedupe-open-files 0.1.0 
atom-django 0.3.2 
atom-like-brackets-editor 1.1.4 
atom-reveal-file-in-finder 1.1.4 
atom-runner 2.7.1 
autocomplete-json 5.4.0 
autocomplete-python 1.8.63 
autoprefixer 3.6.1 
browser-plus 0.0.87 
browser-refresh 0.9.0 
browser-refresh-on-save 0.0.6 
busy-signal 1.4.1 
change-case 0.6.5 
color-picker 2.2.5 
cursor-history 0.10.0 
dash 1.7.1 
django-test-runner 0.5.0 
emmet 2.4.3 
enhanced-tabs 1.7.0 
expand-region 0.2.7 
expand-selection-to-quotes 0.11.0 
file-icons 2.1.4 
filecolor 0.4.0 
fold-comments 0.6.0 
git-plus 7.7.0 
gitignore-snippets 0.2.5 
golden-ratio 0.3.0 
goto 1.8.3 
highlight-line 0.12.0 
highlight-selected 0.13.1 
inc-dec 1.2.0 
intentions 1.1.2 
intentions-texdoc 0.3.0 
javascript-snippets 1.2.1 
keybinding-cheatsheet 0.1.1 
language-django 0.1.1 
language-latex 1.0.0 
language-lua 0.9.11 
language-markdown 0.21.0 
language-pgsql 0.2.3 
language-restructuredtext 1.1.0 
language-sql-mysql 0.3.1 
latex-hyperclick 0.2.0 
latextools 0.8.5 
linter 2.1.4 
linter-chktex 1.3.0 
linter-csslint 1.3.4 
linter-htmlhint 1.3.3 
linter-jshint 3.0.3 
linter-jsonlint 1.3.0 
linter-pylama 0.8.16 
linter-rst 0.0.3 
linter-spell 0.13.1 
linter-spell-latex 0.9.2 
linter-ui-default 1.2.3 
lipsum 0.1.0 
lorem 1.2.1 
markdown-preview-plus 2.4.9 
markdown-writer 2.6.4 
open-in-browsers 0.0.19 
open-recent 5.0.0 
pdf-view 0.57.0 
pigments 0.39.1 
preview-inline 1.4.7 
python-indent 1.0.2 
remove-whitespace 0.2.1 
rulerz 0.4.3 
script 3.14.1 
simply-django-atom 0.0.2 
sort-lines 0.14.0 
split-diff 1.3.1 
Sublime-Style-Column-Selection 1.7.4 
swackets 0.26.0 
sync-settings 0.8.1 
tab-to-escape 0.1.0 
tabularize 0.2.5 
tail 0.1.0 
text-pastry 0.6.1 
todo-show 1.11.0 
tree-view-git-modified 0.7.2 
tree-view-git-status 1.3.1 
turbo-javascript 1.4.0 
wakatime 7.0.0 
zentabs 0.8.8

Uncaught Error: no pane found for [object Object]

[Enter steps to reproduce:]

Not sure how that happens, yet.

Atom: 1.19.1 x64
Electron: 1.6.9
OS: Mac OS X 10.12.5
Thrown From: cursor-history package 0.12.0

Stack Trace

Uncaught Error: no pane found for [object Object]

At /Users/despairblue/.atom/packages/cursor-history/lib/history.js:241

Error: no pane found for [object Object]
    at History.jump (/packages/cursor-history/lib/history.js:241:15)
    at jump (/packages/cursor-history/lib/main.js:37:57)
    at /packages/cursor-history/lib/main.js:42:11)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app/src/command-registry.js:265:35)
    at /Applications/Atom.app/Contents/Resources/app/src/command-registry.js:3:65
    at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Applications/Atom.app/Contents/Resources/app/node_modules/atom-keymap/lib/keymap-manager.js:610:22)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app/node_modules/atom-keymap/lib/keymap-manager.js:401:28)
    at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeyEvent (/Applications/Atom.app/Contents/Resources/app/src/window-event-handler.js:100:42)
    at HTMLDocument.<anonymous> (/Applications/Atom.app/Contents/Resources/app/src/window-event-handler.js:3:65)

Commands

     -0:12.9.0 command-palette:toggle (input.hidden-input)
  3x -0:12.7.0 blur (input.hidden-input)
     -0:12.1.0 editor:consolidate-selections (input.hidden-input)
     -0:12.1.0 core:cancel (input.hidden-input)
  2x -0:12 blur (input.hidden-input)
  4x -0:09.6.0 cursor-history:prev-within-editor (input.hidden-input)
     -0:06.2.0 cursor-history:prev (input.hidden-input)
  4x -0:06.2.0 blur (input.hidden-input)
     -0:05.6.0 cursor-history:next (input.hidden-input)
  4x -0:05.6.0 blur (input.hidden-input)
  3x -0:05.4.0 cursor-history:next (input.hidden-input)
  3x -0:05.1.0 blur (input.hidden-input)
     -0:04.8.0 cursor-history:next (input.hidden-input)
  3x -0:04.8.0 blur (input.hidden-input)
     -0:04.6.0 cursor-history:next (input.hidden-input)
  2x -0:00.3.0 blur (input.hidden-input)

Non-Core Packages

advanced-open-file 0.16.6 
atom-beautify 0.30.5 
atom-debugger 0.1.6 
atom-fuzzy-grep 0.16.0 
atom-handlebars 1.3.0 
atom-jinja2 0.6.0 
atom-keyboard-macros-vim 0.1.6 
atom-lupa 0.7.40 
atom-typescript 11.0.6 
atomic-chrome 0.3.2 
autocomplete-emojis 2.5.0 
autocomplete-paths 2.6.0 
blame 0.12.0 
bug-report 0.7.1 
busy-signal 1.4.3 
character-table 0.4.3 
choose-pane 0.7.0 
color-picker 2.2.5 
cursor-history 0.12.0 
dash 1.7.1 
docblockr 0.11.0 
editorconfig 2.2.2 
elm-format 2.2.0 
elmjutsu 5.6.2 
file-icons 2.1.10 
flow-ide 1.8.1 
git-plus 7.9.3 
gitignore-snippets 0.2.5 
grammar-token-limit 0.1.1 
graphviz-preview-plus 1.4.4 
haskell-grammar 0.4.0 
highlight-selected 0.13.1 
html-to-elm 0.2.0 
hyperclick 0.1.3 
indentation-indicator 1.1.0 
intentions 1.1.5 
js-hyperclick 1.11.0 
jumpy 3.1.3 
keybinding-cheatsheet 0.1.1 
language-ansible 0.2.1 
language-babel 2.71.0 
language-docker 1.1.8 
language-dot 1.7.0 
language-dotfiles 1.1.0 
language-elm 1.5.0 
language-env 0.2.0 
language-fish-shell 1.0.5 
language-graphql 0.9.0 
language-hugo 0.3.1 
language-ini 1.19.0 
language-latex 1.1.0 
language-lua 0.9.11 
language-nimrod 0.1.0 
language-ocaml 1.9.5 
language-reason 0.0.3 
language-rust 0.4.12 
language-swift 0.5.0 
language-thrift 1.0.2 
linter 2.2.0 
linter-alex 4.0.0 
linter-coffeelint 1.2.1 
linter-elm-make 0.23.7 
linter-eslint 8.2.1 
linter-js-yaml 1.2.7 
linter-markdown 5.1.0 
linter-refmt 0.3.1 
linter-rust 0.8.0 
linter-shellcheck 1.4.4 
linter-tslint 1.7.0 
linter-ui-default 1.6.5 
markdown-preview-plus 2.4.10 
maximize-panes 0.2.0 
merge-conflicts 1.4.5 
narrow 0.50.3 
nix 2.1.0 
nuclide 0.245.0 
nuclide-format-js 0.0.41 
ocaml-merlin 0.14.4 
one-tab 0.10.0 
open-on-bitbucket 0.5.0 
open-this 0.4.0 
package-cop 0.2.10 
package-sync 1.1.0 
pdf-view 0.59.0 
pigments 0.40.2 
platformio-ide-terminal 2.5.5 
prettier-atom 0.37.0 
project-folder 1.5.0 
racer 0.20.0 
reason-refmt 0.3.2 
regex-railroad-diagram 0.19.3 
relative-numbers 0.8.0 
rustfmt 0.1.3 
set-syntax 0.3.2 
sort-lines 0.14.0 
split-diff 1.4.3 
standardjs-snippets 2.6.0 
tabs-to-spaces 1.0.3 
tool-bar 1.1.0 
vim-mode-plus 0.96.2 
vim-mode-plus-ex-mode 0.9.1 
vim-mode-plus-project-find-from-search 0.2.0

Checked items in TODO already done? It's confusing to leave them there...

Thank you for this package. :)

Are the checked items in TODO already done? If so, it's confusing to leave them there... It's better to remove them, or maybe move them to the Features section.

The way it is now, at first glance (like happened to me when looking at https://atom.io/packages/cursor-history) it seems those are currently TODO items — i.e., items still to be done. :)

[breaking] use keyframe animation to flash landing position

From v1.13-beta, @keyframe animation is available since chrome version is updated.
Use this approach to improve UI effects.

Along with this change, I'll make breaking change that remove several config option to customize decoration.

[try] support history for file which have no filePath

like temporal buffer before saved to disk.
Currently this package only keeps history for editor which have filePath, so impact to changing ths basic assumption is super big.

Will evaluate how it goes.

Compatibility with atom-prettier for JavaScript

When I execute prettier:format.

It rewrite whole editor.
As a result it make all existing marker's position to (LastRow, 0). (In gif (268, 0) history.js).
This is just making history useless.

How to fix?

Remove duplicate row 0 entries from history.
This mean, using prettier invalidate history on that editor, but it's better than keeping useless history.
Alternate approach to stop marker tracking position and keep old position before prettier update content is not work well, since we can NOT predetermine how much rewrite is done by prettier.

Uncaught TypeError: ref1.getModel is not a function

Tried to close the Mocha Test Runner pane.

Atom: 1.16.0 x64
Electron: 1.3.13
OS: Mac OS X 10.12.4
Thrown From: cursor-history package 0.9.1

Stack Trace

Uncaught TypeError: ref1.getModel is not a function

At .atom/packages/cursor-history/lib/main.coffee:30

TypeError: ref1.getModel is not a function
    at closestTextEditor (/packages/cursor-history/lib/main.coffee:30:41)
    at /packages/cursor-history/lib/main.coffee:131:16
    at Function.module.exports.Emitter.simpleDispatch (/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/app.asar/node_modules/event-kit/lib/emitter.js:129:28)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/app.asar/src/command-registry.js:240:20)
    at CommandRegistry.handleCommandEvent (/app.asar/src/command-registry.js:3:59)
    at CommandRegistry.module.exports.CommandRegistry.dispatch (/app.asar/src/command-registry.js:160:19)
    at /packages/mocha-test-runner/lib/result-view.coffee:25:47)
    at HTMLSpanElement.dispatch (/packages/mocha-test-runner/node_modules/jquery/dist/jquery.js:4435:9)
    at HTMLSpanElement.elemData.handle (/packages/mocha-test-runner/node_modules/jquery/dist/jquery.js:4121:28)

Commands

Non-Core Packages

atom-beautify 0.29.23 
atom-ternjs 0.18.2 
atom-typescript 11.0.2 
autoclose-html 0.23.0 
autocomplete-modules 1.6.9 
busy-signal 1.3.0 
cursor-history 0.9.1 
file-icons 2.1.3 
git-plus 7.6.0 
hyperclick 0.0.40 
intentions 1.1.2 
js-hyperclick 1.10.1 
language-brightscript 0.6.3 
linter 2.1.4 
linter-eslint 8.1.6 
linter-jshint 3.0.3 
linter-ui-default 1.2.3 
merge-conflicts 1.4.4 
mocha-test-runner 0.5.1 
node-debugger 1.10.1 
react 0.16.2 
vim-mode-plus 0.91.0

Uncaught TypeError: Cannot read property 'row' of undefined

[Enter steps to reproduce below:]

Atom Version: 1.0.3-9774b20
System: Mac OS X 10.9.5
Thrown From: cursor-history package, v0.4.15

Stack Trace

Uncaught TypeError: Cannot read property 'row' of undefined

At /Users/tmaeda/github/atom-cursor-history/lib/entry.coffee:59

TypeError: Cannot read property 'row' of undefined
  at Entry.module.exports.Entry.isSameRow (/Users/tmaeda/github/atom-cursor-history/lib/entry.coffee:59:43)
  at History.module.exports.History.add (/Users/tmaeda/github/atom-cursor-history/lib/history.coffee:141:16)
  at /Users/tmaeda/github/atom-cursor-history/lib/main.coffee:153:20
  at /Users/tmaeda/github/atom-cursor-history/lib/main.coffee:11:5

Commands

  2x -0:29.7.0 core:move-down (ol.tree-view.full-menu.list-tree.has-collapsable-children.focusable-panel)
  3x -0:29 core:move-up (ol.tree-view.full-menu.list-tree.has-collapsable-children.focusable-panel)
     -0:28.4.0 core:move-down (ol.tree-view.full-menu.list-tree.has-collapsable-children.focusable-panel)
     -0:28.2.0 tree-view:expand-directory (ol.tree-view.full-menu.list-tree.has-collapsable-children.focusable-panel)
     -0:28.1.0 core:move-down (ol.tree-view.full-menu.list-tree.has-collapsable-children.focusable-panel)
     -0:27.6.0 tree-view:open-selected-entry (ol.tree-view.full-menu.list-tree.has-collapsable-children.focusable-panel)
  3x -0:27.2.0 vim-mode:move-down (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
     -0:24.1.0 project-folder:add (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
     -0:22.3.0 core:backspace (atom-text-editor.editor.mini.is-focused)
     -0:20.4.0 editor:move-to-first-character-of-line (atom-text-editor.editor.mini.is-focused)
     -0:20.1.0 project-folder:switch-action (atom-text-editor.editor.mini.is-focused)
     -0:18.3.0 editor:cut-to-end-of-line (atom-text-editor.editor.mini.is-focused)
     -0:16.3.0 project-folder:replace (atom-text-editor.editor.mini.is-focused)
  2x -0:06.3.0 core:close (atom-pane.pane.active)
     -0:04.5.0 settings-view:open (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
     -0:02.6.0 pane:show-previous-item (input#core.destroyEmptyPanes.)

Config

{
  "core": {
    "disabledPackages": [
      "background-tips",
      "script",
      "regex-railroad-diagram",
      "linter-coffeelint",
      "autocomplete-snippets",
      "file-icons",
      "metrics",
      "jumpy",
      "autocomplete-emojis",
      "dev-live-reload",
      "incremental-search",
      "minimap-git-diff",
      "minimap",
      "hashrocket",
      "linter",
      "pigments"
    ],
    "audioBeep": false
  },
  "cursor-history": {
    "flashOnLand": true,
    "searchAllPanes": false
  }
}

Installed Packages

# User
clip-history, v0.1.11
color-picker, v2.0.11
cursor-history, v0.4.15
dev, v0.0.0
fold-comments, v0.5.0
japanese-wrap, v0.2.10
keymap-disabler, v0.1.1
project-folder, v0.1.6
project-manager, v1.15.11
vim-mode, v0.57.0

# Dev
vim-mode, v0.57.0

Doesn't work well with atom v1.13.1

Hi!

I installed this package yesterday and I noticed it doesn't work as expected with atom 1.13.1 (osx).

It stops jumping back in the history just after 2 or 3 positions and it seems unable to go forward.

I'd like to describe it better in order to help you find out what is going on but I am not sure of what kind of data you need.

Uncaught TypeError: target.closest is not a function

Used plugin ide-rust and set the toolchain to beta, after that I got the notification from Atom:

Switched Rls toolchain to beta
Close and reopen editor windows or reload atom to ensure usage of the new toolchain

Clicked on "Reload" button. Error came up.

Atom: 1.23.1 x64
Electron: 1.6.15
OS: "Arch Linux"
Thrown From: cursor-history package 0.12.0

Stack Trace

Uncaught TypeError: target.closest is not a function

At /home/buzz-dee/.atom/packages/cursor-history/lib/main.js:11

TypeError: target.closest is not a function
    at getClosestEditorForTarget (/packages/cursor-history/lib/main.js:11:26)
    at subscriptions.add.atom.commands.onWillDispatch (/packages/cursor-history/lib/main.js:165:24)
    at Function.module.exports.Emitter.simpleDispatch (/usr/lib/atom/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/usr/lib/atom/node_modules/event-kit/lib/emitter.js:141:28)
    at CommandRegistry.handleCommandEvent (/usr/lib/atom/src/command-registry.js:360:18)
    at CommandRegistry.dispatch (/usr/lib/atom/src/command-registry.js:273:17)
    at NotificationElement.onDidClick (/packages/ide-rust/lib/index.js:291:49)
    at HTMLAnchorElement.<anonymous> (/usr/lib/atom/node_modules/notifications/lib/notification-element.js:131:42)

Commands

Non-Core Packages

advanced-open-file 0.16.7 
adwaita-ui 0.30.0 
angularjs 0.5.1 
atom-beautify 0.30.9 
atom-ctags 5.1.2 
atom-easy-jsdoc 4.12.4 
atom-html-preview 0.2.5 
atom-ide-ui 0.7.0 
atom-pair 2.0.13 
atom-ternjs 0.18.3 
autocomplete-ctags 0.4.1 
autocomplete-html-entities 0.2.0 
autocomplete-modules 1.8.0 
autocomplete-php 0.3.7 
autocomplete-python 1.10.5 
autocomplete-ruby 0.2.8 
autocomplete-sass 0.1.0 
busy-signal 1.4.3 
color-picker 2.2.5 
cursor-history 0.12.0 
debugger 0.0.1 
docs-snippets 0.8.0 
dojo-complete 0.4.0 
editorconfig 2.2.2 
emmet 2.4.3 
external-open 0.6.3 
flow-ide 1.9.0 
format-sql 0.3.0 
git-blame 1.4.0 
git-plus 7.10.0 
git-time-machine 1.5.9 
go-debug 1.5.3 
go-plus 5.7.2 
go-signature-statusbar 1.2.3 
grunt-runner 0.14.0 
highlight-line 0.12.0 
highlight-selected 0.13.1 
hyperclick 0.0.0 
ide-crystal 0.2.3 
ide-css 0.2.0 
ide-go 0.4.0 
ide-html 0.4.1 
ide-java 0.7.0 
ide-json 0.1.0 
ide-python 0.4.0 
ide-ruby 0.1.7 
ide-rust 0.8.0 
ide-typescript 0.7.2 
intentions 1.1.5 
jquery-snippets 11.0.0 
js-hyperclick 1.12.2 
js-refactor 0.7.5 
language-babel 2.81.1 
language-ini 1.19.0 
language-rust 0.4.12 
language-cewe-svg 0.9.0 
latexer 0.3.0 
linter 2.2.0 
linter-coffeelint 1.3.1 
linter-csslint 2.0.0 
linter-eslint 8.4.0 
linter-golinter 1.2.2 
linter-htmlhint 1.4.0 
linter-jshint 3.1.6 
linter-python 3.1.2 
linter-ruby 1.2.6 
linter-rust 0.8.4 
linter-sass-lint 1.8.3 
linter-tslint 1.9.0 
linter-ui-default 1.6.10 
merge-conflicts 1.4.5 
meteor-api 2.20.0 
meteor-helper 0.29.0 
meteor-snippets 0.5.0 
minimap 4.29.7 
node-debugger 1.10.1 
open-file-in 1.2.3 
open-in-external-app 0.1.0 
path-open 0.1.0 
pigments 0.40.2 
pretty-json 1.6.4 
project-manager 3.3.5 
python-debugger 0.2.0 
python-indent 1.1.4 
python-tools 0.6.9 
refactor 0.11.5 
remote-edit 1.9.0 
svg-preview 0.12.1 
symbols-tree-view 0.14.0 
term3 0.22.1 
terminal-plus 0.14.5 
uglify 1.3.1 
xatom-debug 1.6.11 
xatom-debug-nodejs 0.9.3

new feature, visit history only for current active editor

Suggested by @tmunro.

Whats appropriate command name, I like short name if its make sense.

Across text-editors

cursor-history:next
cursor-history:prev

Pick entry for current active text-editor(having same URI or path).

cursor-history:next-within-editor
cursor-history:prev-within-editor

?
next-in-editor?, next-for-current-editor??

Doesn't work on hyperclick

It would be nice if support for hyperclick.

Dont use onDidChangeCursorPosition

Currently history preservation is far from complete.
The reason is cursor position is changed internally.
Ex. symbols-view:toggle-file-symbols move cursor position to achieve preview feature.

I don't want to save this internal movement to history.
I did very dirty workaround specifically for symbols-view on #3.
But this approach is far from ideal and never complete.

Noticed, atom.command.onWillDispatch and onDidDispatch hook.
I can use this hook to check cursor position change at pre/post-command execution.

Or simply I can use to lock history saving for specific command ( I can get command name by event.type).

vim-mode renamed command-mode to normal-mode

The example keybinding won't work in the most recent version of vim-mode unless changed to

'atom-text-editor.vim-mode.normal-mode':
  'ctrl-i': 'cursor-history:next'
  'ctrl-o': 'cursor-history:prev'
  # or
  ']': 'cursor-history:next'
  '[': 'cursor-history:prev'

Deprecated selector in `cursor-history/styles/main.less`

In cursor-history/styles/main.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

atom-text-editor .line.cursor-history-info, atom-text-editor::shadow .line.cursor-history-info => atom-text-editor .line.cursor-history-info, atom-text-editor.editor .line.cursor-history-info
atom-text-editor .line.cursor-history-success, atom-text-editor::shadow .line.cursor-history-success => atom-text-editor .line.cursor-history-success, atom-text-editor.editor .line.cursor-history-success
atom-text-editor .line.cursor-history-warning, atom-text-editor::shadow .line.cursor-history-warning => atom-text-editor .line.cursor-history-warning, atom-text-editor.editor .line.cursor-history-warning
atom-text-editor .line.cursor-history-error, atom-text-editor::shadow .line.cursor-history-error => atom-text-editor .line.cursor-history-error, atom-text-editor.editor .line.cursor-history-error
atom-text-editor .line.cursor-history-highlight, atom-text-editor::shadow .line.cursor-history-highlight => atom-text-editor .line.cursor-history-highlight, atom-text-editor.editor .line.cursor-history-highlight
atom-text-editor .line.cursor-history-selected, atom-text-editor::shadow .line.cursor-history-selected => atom-text-editor .line.cursor-history-selected, atom-text-editor.editor .line.cursor-history-selected
atom-text-editor .cursor-history-info .region, atom-text-editor::shadow .cursor-history-info .region => atom-text-editor .cursor-history-info .region, atom-text-editor.editor .cursor-history-info .region
atom-text-editor .cursor-history-success .region, atom-text-editor::shadow .cursor-history-success .region => atom-text-editor .cursor-history-success .region, atom-text-editor.editor .cursor-history-success .region
atom-text-editor .cursor-history-warning .region, atom-text-editor::shadow .cursor-history-warning .region => atom-text-editor .cursor-history-warning .region, atom-text-editor.editor .cursor-history-warning .region
atom-text-editor .cursor-history-error .region, atom-text-editor::shadow .cursor-history-error .region => atom-text-editor .cursor-history-error .region, atom-text-editor.editor .cursor-history-error .region
atom-text-editor .cursor-history-highlight .region, atom-text-editor::shadow .cursor-history-highlight .region => atom-text-editor .cursor-history-highlight .region, atom-text-editor.editor .cursor-history-highlight .region
atom-text-editor .cursor-history-selected .region, atom-text-editor::shadow .cursor-history-selected .region => atom-text-editor .cursor-history-selected .region, atom-text-editor.editor .cursor-history-selected .region

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

Still working?

Hi! @t9md

Remember me from Jumpy?

I was just curious if this is still working? I've wanted to make something like this for sometime, and figured I'd just I use yours if I can get it going!

I tried the aliases, couldn't get that to work, so, I tried cmd shift p to run the commands, but the cursor doesn't jump.

I don't see any errors, checked console etc.

Any ideas? I reloaded the editor of course heh.

Although I should check your code, just curious, do you use a notion of debouncing for the cursors. Or is the history every single cursor? I've wanted to do this with a debounce, so they would have a more meaningful historical footprint (might not matter so much not sure).

-David

Uncaught TypeError: editor.isAlive is not a function

[Enter steps to reproduce:]

Open project and multiple tabs with files
Close atom and open again
Close any tab

Atom: 1.19.0 x64
Electron: 1.6.9
OS: Mac OS X 10.12.6
Thrown From: cursor-history package 0.12.0

Stack Trace

Uncaught TypeError: editor.isAlive is not a function

At /Users/i/.atom/packages/cursor-history/lib/entry.js:25

TypeError: editor.isAlive is not a function
    at /packages/cursor-history/lib/entry.js:25:28)
    at Function.deserialize (/packages/cursor-history/lib/entry.js:10:12)
    at Object.assign.entries.state.entries.map.map.entry (/packages/cursor-history/lib/history.js:28:71)
    at Array.map (native)
    at Function.deserialize (/packages/cursor-history/lib/history.js:28:52)
    at Object.getHistory (/packages/cursor-history/lib/main.js:94:19)
    at Object.checkLocationChange (/packages/cursor-history/lib/main.js:194:12)
    at setTimeout (/packages/cursor-history/lib/main.js:179:18)

Commands

     -1:12.4.0 tree-view:show (atom-workspace.workspace.scrollbars-visible-when-scrolling)
  7x -0:08.3.0 core:close (div.panels-item)

Non-Core Packages

activate-power-mode 2.2.0 
advanced-open-file 0.16.6 
aesthetic-ui 4.0.0 
align-regexp 0.4.0 
angularjs 0.4.0 
atom-beautify 0.30.5 
atom-jade 0.3.0 
atom-typescript 11.0.6 
auto-detect-indentation 1.3.0 
autocomplete-paths 2.5.0 
autoprefixer 3.7.1 
better-jellybeans-syntax 1.0.3 
blame 0.12.0 
bracket-padder 0.4.1 
busy-signal 1.4.3 
clip-history 0.4.0 
color-picker 2.2.5 
css-declaration-sorter 1.1.0 
cursor-history 0.12.0 
dash 1.7.1 
disable-keybindings 0.6.0 
django-templates 0.5.0 
emmet 2.4.3 
file-icons 2.1.10 
find-selection 0.16.0 
git-plus 7.9.3 
git-time-machine 1.5.9 
gitignore-snippets 0.2.5 
go-debug 1.5.0 
go-plus 5.5.5 
go-signature-statusbar 1.2.1 
hyperclick 0.1.3 
intentions 1.1.5 
js-hyperclick 1.11.0 
language-babel 2.71.0 
language-diff 0.7.0 
language-elixir 0.19.0 
language-ember-htmlbars 0.4.0 
language-graphql 0.9.0 
language-haml 0.25.1 
language-haskell 1.12.1 
language-latex 1.1.0 
language-liquid 0.6.0 
language-pascal 0.20.2 
language-rspec 0.6.3 
language-rust 0.4.12 
language-slim 0.5.0 
language-viml 1.1.4 
less-than-slash 0.17.0 
linter 2.2.0 
linter-coffeelint 1.2.1 
linter-erb 1.1.0 
linter-eslint 8.2.1 
linter-js-yaml 1.2.7 
linter-php 1.3.2 
linter-pylint 2.1.0 
linter-python 3.1.2 
linter-ruby 1.2.4 
linter-sass-lint 1.7.4 
linter-ui-default 1.6.4 
merge-conflicts 1.4.5 
minimap 4.29.6 
minimap-bookmarks 0.4.2 
minimap-git-diff 4.3.1 
minimap-split-diff 0.3.7 
narrow 0.50.3 
persistent-undo 1.2.0 
pigments 0.40.2 
project-manager 3.3.5 
rails-transporter 1.7.1 
react-snippets 0.9.0 
relative-numbers 0.8.0 
release-notes 0.53.0 
remote-sync 4.1.5 
rspec-snippets 0.4.0 
ruby-block-converter 4.0.1 
ruby-test-switcher 1.2.3 
script 3.15.0 
seeing-is-believing 2.2.3 
split-diff 1.4.3 
todo-show 1.11.0 
vim-mode-plus 0.96.2

More explicit direction to enable the plugin keymap

It wouldn't hurt to say explicitly that you need to modify vim-mode-plus.cson file ( in packages/vim-mode_plus/keymaps) to add the snippet given in the README.

Edit:
ah ah you see that I needed more help because I was wrong. It's better be in your keymap.cson in atom config directory

When an open file (buffer) is reopened, it loses the last cursor position

It seems that when an open file (buffer) is reopened, it loses last cursor position...

That is:
1 - When file is reopened (and already open), the cursor goes to 1,1 position ( standard Atom behavior, I think ).
2 - If I choose the Go Previous command, it doesn't go to the previous position... (goes to another one).

Can you see what's going on?

It would be nice to have auto-scroll to position when file is opened

Currently, when you open a file the cursor is at the position where it was the last time the file was opened, however, the part of the file that is visible is always the top part of the file. It would be nice if besides keeping the file position, the file were auto-scrolled to where the scroll is at.

Broken from Atom v1.13.0-beta0

Caused upstream change.
Reported atom/atom#13189.

Anyway I'll fix.

Doesn't work on temporary buffers & weird file paths

Temporary buffers would be a nice plus.

By "weird file paths", I have a slightly edge-casy use-case: I work with remote files (through nuclide's remote feature). The paths are a bit different (e.g. nuclide://foo/bar.js), so I think cursor-history gets confused.

Support for remote URIs

It is possible for the files loaded into atom to be from remote locations (such as in nuclide: http://nuclide.io/docs/features/remote/). This breaks the validation logic since there is no way to use fs to check for file existence!
https://github.com/t9md/atom-cursor-history/blob/master/lib/entry.coffee#L41 will always return false for file URIs that look like something://url-to-file.ext. Could you add some logic to support remote urls? Thanks!

Object.basename (/usr/share/atom/resources/app.asar/src/electron-shims.js:31:10)
Entry.inspect (/home/sybren/.atom/packages/cursor-history/lib/entry.coffee:96:37)
History.<anonymous> (/home/sybren/.atom/packages/cursor-history/lib/history.coffee:237:47)
History.inspect (/home/sybren/.atom/packages/cursor-history/lib/history.coffee:240:10)
History.log (/home/sybren/.atom/packages/cursor-history/lib/history.coffee:248:68)
History.add (/home/sybren/.atom/packages/cursor-history/lib/history.coffee:156:14)

Uncaught TypeError: Cannot read property 'getCursorBufferPosition' of undefined

I opened a project
search for something. I am in the search results pane
opened symbol view (shift-command-r)
error

so nothing related to cursor position or any editable document at all.

it should just bail if its not in an editable document

thanks !

Atom Version: 1.0.5
System: Mac OS X 10.10.4
Thrown From: cursor-history package, v0.4.17

Stack Trace

Uncaught TypeError: Cannot read property 'getCursorBufferPosition' of undefined

At /Users/crucial/.atom/packages/cursor-history/lib/main.coffee:246

TypeError: Cannot read property 'getCursorBufferPosition' of undefined
  at Object.module.exports.getPosition (/Users/crucial/.atom/packages/cursor-history/lib/main.coffee:246:11)
  at withPanel.onDidShow (/Users/crucial/.atom/packages/cursor-history/lib/main.coffee:107:23)
  at /Users/crucial/.atom/packages/cursor-history/lib/main.coffee:70:50
  at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:82:11)
  at Panel.module.exports.Panel.show (/Applications/Atom.app/Contents/Resources/app.asar/src/panel.js:77:29)
  at ProjectView.module.exports.SymbolsView.attach (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/symbols-view/lib/symbols-view.js:177:18)
  at ProjectView.module.exports.ProjectView.toggle (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/symbols-view/lib/project-view.js:42:21)
  at atom-workspace.workspaceSubscription.atom.commands.add.symbols-view:toggle-project-symbols (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/symbols-view/lib/main.js:14:46)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:241:29)
  at /Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61
  at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:524:16)
  at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:347:22)
  at HTMLDocument.module.exports.WindowEventHandler.onKeydown (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:177:20)

Commands

     -0:44.1.0 core:close (div.release-notes.padded.pane-item.native-key-bindings)
     -0:41.3.0 project-find:show (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
     -0:40 core:confirm (atom-text-editor.editor.mini.is-focused)
     -0:05.1.0 symbols-view:toggle-project-symbols (ol.results-view.list-tree.focusable-panel.has-collapsable-children)

Config

{
  "core": {
    "ignoredNames": [
      "*.pyc",
      ".DS_Store"
    ],
    "followSymlinks": true,
    "disabledPackages": [
      "cute-cursor",
      "language-go",
      "language-java",
      "syntax-settings",
      "term",
      "language-supercollider",
      "linter-rst",
      "rst-preview",
      "rst-preview",
      "atom-runner",
      "make-runner",
      "ide-haskell",
      "remote-edit",
      "atomatigit",
      "minimap-highlight-selected",
      "tabs-to-spaces",
      "atomic-emacs",
      "git-log",
      "autoflow",
      "autosave",
      "background-tips",
      "block-travel",
      "dash",
      "easy-motion",
      "gist-it",
      "git-blame",
      "git-difftool",
      "git-plus",
      "trailing-spaces",
      "project-colorize",
      "file-icons",
      "term2",
      "web-view",
      "atom-terminal",
      "command-logger",
      "css-color-highlighting",
      "editor-stats",
      "selection-count",
      "fancy-new-file",
      "language-clojure",
      "language-docker",
      "minimap-find-and-replace",
      "mobile-preview",
      "my-package",
      "sourcegraph-atom",
      "org",
      "paredit",
      "autocomplete",
      "jumpy",
      "atom-color-highlight",
      "angularjs-snippets",
      "todo-show",
      "autocomplete-jedi",
      "bezier-curve-editor",
      "coffee-lint",
      "python-jedi",
      "org-mode",
      "highlight-selected",
      "node-resolver",
      "next-occurrence",
      "linter-scss-lint",
      "linter-coffeelint",
      "Atom-Syntax-highlighting-for-Sass",
      "grunt-runner",
      "typewriter-sounds",
      "ide-flow",
      "atom-ctags",
      "linter-jscs"
    ],
    "destroyEmptyPanes": false
  }
}

Installed Packages

# User
angularjs, v0.3.0
atom-django, v0.3.0
atom-ternjs, v0.7.1
autoclose-html, v0.18.0
autocomplete-paths, v1.0.2
autocomplete-plus-python-jedi, v0.3.6
autocomplete-python, v0.5.3
color-picker, v2.0.11
cursor-history, v0.4.17
django-templates, v0.5.0
editorconfig, v1.0.1
emmet, v2.3.12
javascript-snippets, v1.0.0
language-crontab, v0.1.0
language-jade, v0.6.2
language-restructuredtext, v0.7.0
language-swift, v0.4.0
last-cursor-position, v0.9.0
linter, v1.3.4
linter-csslint, v1.0.5
linter-jshint, v1.1.5
linter-jsxhint, v0.1.2
linter-pep8, v1.0.1
linter-pylint, v0.2.2
minimap, v4.12.2
pain-split, v1.4.0
pigments, v0.9.3
project-manager, v1.15.11
python-autopep8, v0.1.3
react, v0.12.6
regex-railroad-diagram, v0.8.4
rename-tabs, v0.1.1
set-syntax, v0.3.0
symbol-gen, v1.0.0
tree-view-git-status, v0.1.2
vim-mode, v0.57.0
zentabs, v0.8.6

# Dev
No dev packages

Goto-line then go back doesn't work

If you go to a specifc line go-to-line:toggle , going back does not take you to where you before.

I suspect that typing the line number into the go-to-line-command-pallette is throwing it off?

I'm not sure though because even if I keep going back I never get back to my original position.

t9md / atom-cursor-history Goto Github PK

atom-cursor-history's Introduction

atom-cursor-history's People

Contributors

Stargazers

Watchers

Forkers

atom-cursor-history's Issues

Steps to reproduce

Stack Trace

Commands

Non-Core Packages

Stack Trace

Commands

Config

Installed Packages

Stack Trace

Commands

Non-Core Packages

Stack Trace

Commands

Non-Core Packages

How to fix?

Stack Trace

Commands

Non-Core Packages

Stack Trace

Commands

Config

Installed Packages

Stack Trace

Commands

Non-Core Packages

Across text-editors

Pick entry for current active text-editor(having same URI or path).

Stack Trace

Commands

Non-Core Packages

Stack Trace

Commands

Config

Installed Packages

Recommend Projects

Recommend Topics

Recommend Org