t3rm1n4l / godownload Goto Github PK
View Code? Open in Web Editor NEWA handy HTTP parallel downloader package and command-line tool in Go
A handy HTTP parallel downloader package and command-line tool in Go
Hi,
First of all, thanks for providing code free of charge.
In case you're still interested, I tested your program with go 1.4 on a WinXP-sp3 system and found that my downloaded files (audio files) were systematically corrupted. Closer inspection revealed that the last few bytes of each part were replaced by zeroes.
I found that this issue could be fixed (at least in my hands) by a slight modification of the for
loop in function Part.Download()
of file download.go
, as follows:
func (part *Part) Download(done chan error, quit chan bool) error {
...
for err != io.EOF {
select {
case <-quit:
return nil
default:
}
nbytes, err := resp.Body.Read(buffer[0:size])
if err != nil && err != io.EOF { // don't break the loop on read EOF
return err
}
nbytes, err = part.file.WriteAt(buffer[0:nbytes], int64(part.offset+part.dlsize))
if err != nil {
return nil
}
part.dlsize += nbytes
remaining := part.size - part.dlsize
switch {
case remaining == 0:
return nil
case remaining < 4096:
size = part.size - part.dlsize
}
}
...
Please note that this proposed fix has not been extensively tested
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.