t2ym / gulp-i18n-preprocess Goto Github PK

Add dropJson option to drop the extracted JSON files for output

Recognize i18n-element.html HTML imports as indicators of I18N target elements

Support Shadow DOM v1 slot for i18n-format parameters

Attribute name for parameters have to be changed from param to slot for Shadow DOM v1 targets

This issue is synchronous with t2ym/i18n-behavior#31.

firstChild non-null check is missing in applying i18n-format to handle cases like the following.

template is empty:

<p>ABC
  <template is="dom-if"> </template>
</p>

Redundant I18N-target attribute are required for attr$= like this:

<i18n-attr-repo>
  <template id="custom">
    <any-elements aria-label$></any-elements>
  </template>
</i18n-attr-repo>

This issue is in sync with t2ym/i18n-behavior#46

Compound binding support for I18N-target attributes.

Parameterized:

  attr="Compound binding attribute has [[bound.value]] {{parameters}} in the value string"
  "{{i18nFormat(attrId.0,bound.value,parameters)}}"
  [ "Compound binding attribute has {1} {2} in the value string", "[[bound.value]]", "{{parameters}}" ]

Concatenated: (Parameters with functions cannot be reordered in translation)

  attr2="Compound binding attribute has [[f1(bound.value)]] {{f2(parameters)}} in the value string"
  "{{attrId.0}}[[f1(bound.value)]]{{attrId.2}}{{f2(parameters)}}{{attrId.4}}"
  [ "Compound binding attribute has ", "[[f1(bound.value)]]", " ", "{{f2(parameters)}}", " in the value string" ]

This issue is synchronous with t2ym/i18n-behavior#26.

Preprocessed:

  <input id="yourname" aria-label="{{model.yourname.aria-label}}">

Disappeared in DOM:

  <input id="yourname">

The issue is synchronous with t2ym/i18n-behavior#20

When i18n-format is automatically applied, child templates such as dom-repeat, dom-if are not properly rendered.

Paragraph with a child template:

  <p id="paragraph">
    A paragraph with 
    <template is="dom-repeat" items="{{text.parameters}}">
      <i>{{item}} </i>
    </template>
    is converted to 
    <code>&lt;i18n-format&gt;</code>.
  </p>

Expected preprocess:

  <p id="paragraph">
    <i18n-format lang="{{effectiveLang}}">
      <span>{{text.paragraph.0}}</span>
      <template is="dom-repeat" items="{{text.parameters}}">
        <i param="1">{{item}} </i>
      </template>
      <code param="2">{{text.paragraph.2}}</code>
    </i18n-format>
  </p>

Actual preprocess: The rendered <i> is not selected for <content select='[param="1"]'></content>.

  <p id="paragraph">
    <i18n-format lang="{{effectiveLang}}">
      <span>{{text.paragraph.0}}</span>
      <template param="1" is="dom-repeat" items="{{text.parameters}}">
        <i>{{item}} </i>
      </template>
      <code param="2">{{text.paragraph.2}}</code>
    </i18n-format>
  </p>

If contents of the child template have more than 1 elements or have compound bindings, i18n-format must not be applied.

This issue is synchronous with t2ym/i18n-behavior#21.

title global attribute is not preprocessed for I18N.

I18N tasks (scan, preprocess, leverage, feedback, etc.) have to be integrated with the new interface polymer-cli.

As of polymer-cli 0.8.0, userTransformers plugin interface, which API is still private, can be used to integrate the I18N tasks with polymer build process.

With Thin Syntax, set <template basepath> on targetVersion >= 2 so that <dom-module assetpath> attribute can be set reliably despite of unreliable and undocumented assetpath conversion by vulcanize.

Related Issue at the client side:

t2ym/i18n-element#29

Supply omitted id for thin syntax.

Omitted template id:

<link rel="import" href="i18n-element/define-element.html">
<link rel="import" href="i18n-element/i18n-element.html">

<template>
 ...
</template>
<script>
Define = class ThinElement extends BaseElements.I18nElement {
}
</script>

Omitted class name:

<link rel="import" href="i18n-element/define-element.html">
<link rel="import" href="i18n-element/i18n-element.html">

<template id="thin-element">
 ...
</template>
<script>
Define = class extends BaseElements.I18nElement {
}
</script>

Preprocessed:

<link rel="import" href="i18n-element/define-element.html">
<link rel="import" href="i18n-element/i18n-element.html">

<template id="thin-element" localizable-text="embedded">
 ...
</template>
<script>
Define = class ThinElement extends BaseElements.I18nElement {
}
</script>

Design issues:

• How to handle external scripts <script src="thin-element.js"></script>
• How to determine id
• Element name (id) from file name is easier to implement

For templates for thin syntax, assetpath has to be "." so that vulcanize can convert it to an appropriate path.

Original Issue on i18n-element:
t2ym/i18n-element#27

This issue is in sync with t2ym/i18n-behavior#43

Refine excluded attributes for I18N.

List of excluded attributes:

id
text-id
is
lang

Redundant null file check in doPreprocess() should be removed.

Add legacy attribute to dom-module for Polymer 2.x compatibility

<link rel="import" href="bower_components/i18n-element/i18n-behavior.html">

<dom-module id="i18n-legacy-element" legacy>
  <template>...</template>
</dom-module>
<script>
Polymer({ is: 'i18n-legacy-element', behaviors: [ BehaviorsStore.I18nBehavior ] });
</script>

Attribute Id is incorrect for I18N-target attribute with $=

Support Custom Elements v1 format for i18n-dom-bind

<i18n-dom-bind id="binding-name">
  <template>
    ...
  </template>
</i18n-dom-bind>

Cannot find i18n-attr-repo template for Polymer 2.x since it is not in dom-module but as template id="i18n-attr-repo" in i18n-attr-repo.html for Polymer 2.x

In gulpfile.js transformers for Polymer CLI, previous default JSON files overwrite new ones.

Previous default JSON files from src have to be dropped before preprocess transformation.

This issue is synchronous with t2ym/i18n-behavior#28.

Extra empty text node is attached in converting compound bindings to span node.

In parsing a compound binding text node like this:

{{name}}A{{name2}}

Extra empty text node is attached:

<span>{{name}}</span>A<span>{{name2}}</span>

Empty text node at the end:
result = [ <span>, #text, <span>, #text]

This issue is synchronous with t2ym/i18n-behavior#30.

Unreachable code paths in parsing text nodes with compound bindings should be removed.

This issue is synchronous with t2ym/i18n-behavior#25.

Global attribute title is not extracted for input elements.

<input title="a tooltip" value="{{name}}">

At the beginning of the embedded JSON that is wrapped by <template id="localizable-text">, an extra insignificant newline is added just for prettiness of the preprocessed template. This extra newline causes some test failures in exactly matching textContent strings.

Current newline insertion for pretty looking:

<br>{{text.text_15}}
<template id="localizable-text">
<json-data>
...

Fix to eliminate undesirable side-effects in tests:

<br>{{text.text_15}}<template id="localizable-text">
<json-data>
...

This issue is synchronous with t2ym/i18n-behavior#24.

ARIA attributes that contain UI assistance strings such as aria-label and aria-valuetext are not extracted in preprocessing.

<input aria-label="Your name" value="{{name}}">

Compound binding attribute beginning or ending with annotations are mistreated as JSON

attr-mistreated-as-json1="[[bound.parameters]] are at the head and the tail of [[compound.attribute]]"
attr-mistreated-as-json2="{{bound.parameters}} are at the head and the tail of {{compound.attribute}}"

This issue is synchronous with t2ym/i18n-behavior#23.

In explicit use of i18n-format, an annotated variable in the first child is unexpectedly extracted as a string and the variable is not evaluated.

The first child is not evaluated:

      <i18n-format id="statusMessage">
        <span>{{tr(status,text.statusMessage)}}</span><!-- this textContent should be evaluated -->
        <span>{{responseTime}}</span>
      </i18n-format>

This issue is in sync with t2ym/i18n-behavior#40

Register I18N-target attributes for custom elements without I18nBehavior.

Example I18N-target attributes in a static template in the light DOM of i18n-attr-repo:

    <i18n-attr-repo>
      <template id="custom">
        <shop-md-decorator error-message="$"></shop-md-decorator>
      </template>
    </i18n-attr-repo>

Integrate I18N tasks with polymer-build library for gulp

This issue is in sync with t2ym/i18n-behavior#42.

Support selective I18N-target attributes.

For example, pick up value="Button Label" attribute of <input> tag if type="button"

Example selective attribute:

<input type="button" value="Button Label">

Expected Definition:

<i18n-attr-repo>
  <template id="custom">
    <input value="type=button|submit">
  </template>
</i18n-attr-repo>

Workaround as of version 1.0.1:

<i18n-attr-repo>
  <template id="custom">
    <input label="$"><!-- define label as I18n-target attribute -->
  </template>
</i18n-attr-repo>

<dom-module id="my-element">
  <template>
    <!-- forward to the 'value' attribute -->
    <input id="ok-button"
      value="{{text.model.ok-button.label}}"
      on-click="_ok"
      label="OK">
  </template>
</dom-module>