Git Product home page Git Product logo

Comments (10)

maccan-tech avatar maccan-tech commented on June 6, 2024 5

+1
Maby let oss be able set the minimum value.

from rain-gauge-card.

tanker11 avatar tanker11 commented on June 6, 2024 4

from rain-gauge-card.

Gavin-A92 avatar Gavin-A92 commented on June 6, 2024 4

I'd like to leave a +1 for this change too.....IMHO 40mm is excessive as a minimum max level for the Gauge.

As example almost biblical rain yesterday here (Ireland) but still only hitting 27mm of rain in 24 hours.....going back over past 12 months the max daily rain here was 37mm......not sure where dev is from so maybe 40mm+ daily is usual (tho you're UK I think so unlikely)....anyway just my thoughts.....

from rain-gauge-card.

t1gr0u avatar t1gr0u commented on June 6, 2024

@tanker11 could I please have more information.

  • What is your configuration?
  • Can I have a screenshot?
  • What values have you tried?

from rain-gauge-card.

tanker11 avatar tanker11 commented on June 6, 2024

Sure, sorry.
Here is my config:
type: custom:rain-gauge-card
entity: sensor.rain_24h
show_warning: false
show_error: false
is_imperial: false
max_level: 3

What I get is:
image

According to my understanding the level should be around 1/3 of the total height, right?
If I change the max_level to 2, nothing changes in the displaying, however it should be about 1/2 of the total height with the actual value of 1.1.

from rain-gauge-card.

t1gr0u avatar t1gr0u commented on June 6, 2024

@tanker11 I've set the minimum to be 40mm so if the max_level is anything below this then it will not take this into account.
But if you set this anything above then it will work.

I just wanted to be defensive within the code.

from rain-gauge-card.

t1gr0u avatar t1gr0u commented on June 6, 2024

If I get more requests to drop the minimum (40mm) then I would consider it :)

from rain-gauge-card.

tanker11 avatar tanker11 commented on June 6, 2024

from rain-gauge-card.

steve125125 avatar steve125125 commented on June 6, 2024

It works of i set is-imperial to true.

But it would be nice if this works with mm as well.

type: custom:rain-gauge-card
language: de
name: Regen
show_error: false
show_warning: false
entity: sensor.innen_innen_innen_regen_pws_rain_today
hourly_rate_entity: sensor.innen_innen_innen_regen_pws_rain
is_imperial: true
max_level: '8'

from rain-gauge-card.

t1gr0u avatar t1gr0u commented on June 6, 2024

@tanker11 this is now fixed in v1.4.0, thank you for using this card.

from rain-gauge-card.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.