szymondukla / festivo-php-wrapper Goto Github PK

Hello Szymon, just wondering if you are going to share the source code.
Thank you!

                    [2019-05-20] => Array
                        (
                            [0] => Array
                                (
                                    [name] => Kristi Himmelfartsdag
                                    [country] => DK
                                    [date] => 2019-05-20
                                    [public] => 1
                                )

                        )

This date should be 2019-05-30

Describe the bug
When you want to make a call with only mandatory fields like year and country, Slim throws an error

SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'month' cannot be null (SQL: insert into `api_usage` (`id`, `endpoint`, `country`, `year`, `month`, `day`, `previous`, `upcoming`, `pretty`, `ip_address`, `status`, `timestamp`) values (, /v1/holidays, PL, 2019, , , 0, 0, 0, XXXX, 200, 2019-03-18 14:02:57))

It looks like your's api_isage table doesn't follow mandatory parameters: https://github.com/SzymonDukla/HolidayAPI-Wrapper#parameters

To Reproduce
Visit https://holidayapi.pl/v1/holidays?year=2019&country=PL and you will see an error.

It would also be nice to see on which dates the stores are closed..

And the same with banks.. Stores and banks are not closed on the same dates

Thank you so much for making such a useful service available free of charge. I have noticed a small issue with Canadian holiday queries, however. Remembrance Day dates returned by the API are identical to Thanksgiving Day, which is in early/mid October. Remembrance Day in Canada is actually November 11th every year.

To reproduce: https://holidayapi.pl/v1/holidays?country=CA&year=2019