It seems that if you have parameters for your queue (e.g. typed queues or contact subqueues), these parameters don't get passed on, so when your done with your batch, you will be pushed back into the default queue.

If you request a change for an SepaMandate, which

• with a requested change
• supplies a new mandate reference
• supplies a cancel reason (for the case there's a change)

This creates an activity without reference which then crashes the processing desktop.

It looks like the i/copy.png icon has been discontinued in CiviCRM, so the"copy" icons is currently broken. We'll move this into the extension itself, to fix this.

In ticket #19 the address handler was refactored. The new implementation contains a grave/stupid error (see here), that stores the addresses across different calls and different contacts. In particular the recorded original address might be wrong when submitting multiple changes in the same PHP session.

Simply use CRM_Contact_BAO_Contact_Utils::getImage

Currently, if empty values are submitted (contact and address handlers), they will not show in the processing screen. There should, however, be an option to enable to user to reset/clear individual fields in a controlled way.

The activity date used to be the 'create date' of the request, but it's not reliable b/c it's changed but the "postpone" option anyway.

It seems like when using the SddUpdate handler the following error can occur:

Sorry, due to an error, we are unable to fulfill your request at the moment. You may want to contact your administrator or service provider with more details about what action you were performing when this occurred.

BIC is required for creditor [2].

There is a setting for the session size, but it's not evaluated - the session is always 10.

suggested behaviour:

1. show the fact that the email is 'on hold' in UI
2. remove 'on hold' flag, if email is changed (overwritten)

Funded by AIVL, an action for Contact Update that can be used in the Form Process and Data Processor extensions to be added upon install or with upgrade if the Action Provider extension is installed.

Add processed contacts to CiviCRM's recent items, use CRM_Utils_Recent::add

The API should be able to detect, if the last scheduled change request is identical to this one. If that's the case, the new change request data will not be stored, and the request effectively ignored.

There's some indications that the lack of the quickform between the requests processed may cause some issues.

While creating a new Form Builder with an Activity and attempting to add the Contact Update fields (for users to fill out) they weren't available.

How to reproduce

1. Create a Form Builder form
2. Attempt to add the fields to the form
3. You cannot add them to the Add section, but can add them in the Values section
   

What was expected

The ability to add these fields for users to fill out and create an Activity

Solution

As it turns out, Form Builder doesn't load custom fields that are set to "is_view": "1" (ref), but regardless they are set as Read-only so cannot be modified normally.

I would suggest that all the *_applied be modified to "is_view": "0". I think leaving the others to not being able to be modified makes a load of sense.

Thoughts? I would be happy to provide a patch, but I suspect this is going to catch others off guard like it did for me (It took me like a few hours to figure out why :( )

The code already does the right thing, but the API specs don't allow empty values.

In the course of the recent refactoring (reference needed) the address sharing functionality broke - even though it wasn't working properly anyway in some scenarios.

To fix this once and for all, we suggest a new line "share with" in the address processing panel with the following options:

1. update: if the changes should be applied to the current address and the master address (only if the current address is connected to a master)
2. unshare and update: if the changes should be applied to the current address but not the master address. Consequently, the link to the master address is therefore severed (only if the current address is connected to a master)
3. create and share: if the changes should be applied to the current address, and to a newly created master address with the submitted master_contact_id (only if the current address is not connected to a master)
4. create: if the changes should be applied to the current address, but not linked to a master address (only if the current address is not connected to a master)

Remarks:

• these options will be shown per location type
• there could potentially be more than master_contact_ids involved: a submitted one, and the current one.

The system currently doesn't have checks to avoid the processing of change requests (activities) in status Completed. Even though the intended workflow shouldn't take you into this scenario, you can still get there by e.g. cloning a tab or closing an activity outside the I3Val system.

Therefore, we want to add the following checks:

• When opening a new I3Val pending change, make sure that it is 'Pending' - otherwise it should be skipped
• When confirming an I3Val change, check again if the activity is still 'Pending', otherwise issue an error message. This should tackle the scenario where you have the same change opened in two windows.

If you have more than one address type, the address override is more than confusing. The location type selector does not select to overwrite the address of the given type, but to overwrite the same address and also change it's location type. Very badly designed, sorry.

the transmitted value is different from the current value
but still it is not adopted to the value that should be applied
and as a result it is also not applied
are there any conditions I do not know of, or is this a bug?

Hello! :)

I've installed the master branch of this extension. I switched to the configuration, added the Quick History and saved. The change was saved - However I got the following error:

User deprecated function: Deprecated function CRM_Core_BAO_Setting::setItem, use refer docs for correct methods https://docs.civicrm.org/dev/en/latest/framework/setting/. in CRM_Core_Error::deprecatedWarning() (line 1053 of /var/www/vhosts/crm.animalsociety.de/httpdocs/dev/public/sites/all/modules/civicrm/CRM/Core/Error.php).

As described in #12, the address handler panel can be very confusing to the user. With this ticket, we want to completely refactor the panel to improve usability.

While testing a few submissions, I noticed that on the Processing requested updates page were not choosing the proper action when there already existed a matching record.

How to reproduce

1. Create a Contact that has an Email with a Location Type of Work
2. Create a new Activity for this extension that has a new Email and matching Location Type Work as above
3. Go to the Processing requested update page
4. See that the Email Data is displaying the Add new Phone action rather than the Overwrite existing action
5. Repeat above but with Phone

What was expected

It would appropriate choose the proper action based on seeing a duplicate Location Type based on that field.

Solution

I found what appears to be a mistype (?) in the code. Basically, the action code is checking for a field that doesn't exist, but does exist in the processed code. When I changed that it was working great.

I'll post a merge request shortly

When submitting a new (potential) mandate reference to an SDD update, the reference will be used without double checking it. This can lead to exceptions, if the reference is already in use. In this case, the system should rather try to find a new, unused, reference by appending a counter.

Fix Code to be compatible with CiviCRM 5.60:

CRM/I3val/Logic.php:86:    $activity_data['status_id'] = CRM_Core_OptionGroup::getValue('activity_status', 'Scheduled', 'name');
CRM/I3val/CustomData.php:141:            $activity_type = CRM_Core_OptionGroup::getValue('activity_type', $activity_type, 'name');

• Update CustomData Helper to 0.10
• use legecayCode extension to replace call in Logic.php:86

The SDD update handler allows to apply changes to an existing mandate, if the only change is the amount.

If, however, you submit a reason with the along with the amount change request, this will prevent the mandate "update" and trigger the creation of a new mandate.

I3Val should be able to process not only the complete queue, but also a subset identified by activity types. This was originally envisioned and at least partly implemented, but this feature needs to be reviewed, fixed and tested.

The idea is that we can then have links in the menu pointing to the subset processing.

Funded by AIVL, an action for Mandate Update that can be used in the Form Process and Data Processor extensions to be added upon install or with upgrade if the Action Provider extension is installed.

currently birth_data and deceased_date aren't normalised, so there might be differences detected where there aren't any.

Details need to be investigated

The XCM creates similiar, but less structured attribute change reports. It would be good if we could convert these into I3Val activities

While processing, if there are other pending changes in the queue, there should be a prominent new button showing the number of other change requests for that contact. Upon pressing it, you would leave the current queue and get a new queue with only the changes of this contact. The current subset filter (see #3) should not be applied to the contact's changes.

A this point we should also issue a warning if one of these change requests is claimed by another process.

This is a duplicate of #42

In the course of the recent refactoring (reference needed) the address sharing functionality broke - even though it wasn't working properly anyway in some scenarios.

Since we currently don't have funding for a proper solution (#41), we would at least like to display the currently active master_contact_ids, along with a submitted value.

It would just list the names + location types of the currently used master_contact_ids, along with a link.

The country field for the address doesn't have an 'empty' option. As a result, you can never set/leave the country empty.

Best to be done in MKDocs format for publishing on https://docs.civicrm.org

See #20