systems-cs-pub-ro / uso-lab-book Goto Github PK

There are formatting issues when building the files chapter:

/home/razvan/school/uso/uso-lab-book.git/chapters/files/archive.rst:433: WARNING: Error in "code-block" directive:
maximum 1 argument(s) allowed, 92 supplied.

.. code-block:: bash
    student@uso:~$ zip înregistrări.zip înregistrare_lab01.mov înregistrare_lab02.mov  înregistrare_lab03.mov
      adding: înregistrare_lab01.mov (deflated 0%)
      adding: înregistrare_lab02.mov (deflated 0%)
      adding: înregistrare_lab03.mov (deflated 0%)
    student@uso:~$ ls -l
    total 34828
    drwxr-xr-x 3 student student    4096 Aug 19 12:15 dezarhivare
    -rw-r--r-- 1 student student 5242880 Aug 19 11:55 înregistrare_lab01.mov
    -rw-r--r-- 1 student student 3145728 Aug 19 11:55 înregistrare_lab02.mov
    -rw-r--r-- 1 student student 1048576 Aug 19 11:55 înregistrare_lab03.mov
    -rw-r--r-- 1 student student 7340032 Aug 19 12:35 înregistrare_lab04.mov
    -rw-r--r-- 1 student student 9441280 Aug 19 17:56 înregistrări.tar
    -rw-r--r-- 1 student student 9439072 Aug 19 18:02 înregistrări.zip
    student@uso:~$ rm înregistrare_lab01.mov înregistrare_lab02.mov  înregistrare_lab03.mov
/home/razvan/school/uso/uso-lab-book.git/chapters/files/archive.rst:451: WARNING: Error in "code-block" directive:
maximum 1 argument(s) allowed, 80 supplied.

.. code-block:: bash
    student@uso:~$ unzip înregistrări.zip
    Archive:  înregistrări.zip
      inflating: înregistrare_lab01.mov
      inflating: înregistrare_lab02.mov
      inflating: înregistrare_lab03.mov
    student@uso:~$ ls -lh
    total 35M
    drwxr-xr-x 3 student student 4.0K Aug 19 12:15 dezarhivare
    -rw-r--r-- 1 student student 5.0M Aug 19 11:55 înregistrare_lab01.mov
    -rw-r--r-- 1 student student 3.0M Aug 19 11:55 înregistrare_lab02.mov
    -rw-r--r-- 1 student student 1.0M Aug 19 11:55 înregistrare_lab03.mov
    -rw-r--r-- 1 student student 7.0M Aug 19 12:35 înregistrare_lab04.mov
    -rw-r--r-- 1 student student 9.1M Aug 19 17:56 înregistrări.tar
    -rw-r--r-- 1 student student 9.1M Aug 19 18:02 înregistrări.zip
/home/razvan/school/uso/uso-lab-book.git/chapters/files/io_redirection.rst:199: WARNING: Title level inconsistent:

Exerciții
"""""""""

The current setup doesn't center images on page; namely using the syntax here.

The generated HTML code does contain class="align-center"but the image is not rendered properly. It may have to do with the CSS.

In chapter "files", file "files.rst", section "2) Ierahie de fișiere", one cannot tell when a file is regular file or directory.
One suggestion should be to use tree -F that puts "/" at the end of a directory name or add a note to specify how to tell apart between the two file types.

For the USO lab, I have modified the text directly in the lab, adding the following note to the text: (Notă: Numele cu extensie din structura sunt fișiere, restul sunt directoare) and replacing "Favorite" with "Favorite.txt", but I don't know whether this is the best approach or not (see: https://ocw.cs.pub.ro/courses/uso/laboratoare/laborator-01/files#exercitii_-_ierarhii_de_fisiere_si_directoare).

In the section Modficare permisiunilor [1], the command sudo adduser student maria is taking effect only after a login in the terminal.

This should be mentioned as a warning during the exercises, otherwise, the students will get stuck on Permission denied when they are trying to access /home/maria/todo_list as student.

[1] https://ocw.cs.pub.ro/courses/uso/laboratoare/laborator-09#modificarea_permisiunilor

There are formatting issues when building the improve-cli chapter:

/home/razvan/school/uso/uso-lab-book.git/chapters/improve-cli/improve-shell.rst:27: WARNING: Bullet list ends without a blank line; unexpected unindent.

In chapter "files", file "file-editor.rst" (the content that is uploaded on DokuWiki, probably in a PR here on Github), the students are told to comment lines that contain regular text, not code, and the comment lines shortcut from Sublime doesn't work (doesn't know how to comment regular text).

Link to lab exercises: https://ocw.cs.pub.ro/courses/uso/laboratoare/laborator-01/editor#exercitii_-_editor_grafic

The explanations for {} [1] are wrong or incomplete. From the lab [1], I get that {} are a form of OR.
From lab: "... folosim sintaxa {} pentru a defini o listă de cuvinte ... care pot fi folosite în înlocuire. Această sintaxă înlocuiește exact un cuvânt din lista oferită" + "Citim expresia {Downloads,Music}: în locul acestei expresii poate să existe cuvântul Downloads sau cuvântul Music."

In reality, {} represent expansion of terms. Ex: touch file{1,2,3,4,5}.txt expands to touch file1.txt file2.txt file3.txt file4.txt file5.txt. And ls {Downloads,Music} expands to ls Downloads Music.
See "Brace Expansion" from [2].

Please correct or improve the text that refers to {}.

[1] https://ocw.cs.pub.ro/courses/uso/laboratoare/laborator-05#sintaxa_speciala1
[2] https://linux.die.net/man/1/bash

There is no mention in the lab's text[1] to add execution permissions before launching any script.

A command block of chmod +x ./script.sh should be added.

[1] https://ocw.cs.pub.ro/courses/uso/laboratoare/laborator-07

In the lab's text, in the summary section, there is information about cmp and diff [1] (the file comparison summary section is under grep summary section). However, there is no information about the two commands (usage and examples) in the main sections. I think that the file comparison section might be missing or the file comparison summary section should have been removed from the lab.

[1] https://ocw.cs.pub.ro/courses/uso/laboratoare/laborator-05#optiuni_uzuale_ale_grep1

The gifs that shows how to close a tab from a terminal are not placed correctly.

More exactly:

• in chapters/basic/terminal.rst and in the lab (https://ocw.cs.pub.ro/courses/uso/laboratoare/laborator-00#deschiderea_si_inchiderea_taburilor): the text indicates how to close a tab in a terminal using the application menu, but the gif shows how to use the 'x' button attached to the tab.

• in chapters/basic/cheatsheet.rst and in the lab (https://ocw.cs.pub.ro/courses/uso/laboratoare/laborator-00#inchiderea_taburilor2), the gifs for "how to close the tab in a terminal using the application menu" and for "how to close the tab in a terminal using the 'x' button attached to the tab" should be swapped.

There are formatting issues when building the net chapter:

/home/razvan/school/uso/uso-lab-book.git/chapters/net/extra.rst:4: WARNING: Duplicate explicit target name: "aici".

• Output for my_ls is wrong (command is run from ~ whilst the output is from ~/uso_lab02.
• Explanation on removing a symbolic link is wrong: when removing a link, the target isn't removed.
• Explanation on creating a symbolic link is wrong: when creating a link without specifiying a name, the links name defaults to the name of the target.

There are formatting issues when building the app-dev chapter:

/home/razvan/school/uso/uso-lab-book.git/chapters/app-dev/make-lib.rst:144: WARNING: Could not lex literal_block as "bash". Highlighting skipped.
/home/razvan/school/uso/uso-lab-book.git/chapters/app-dev/make-lib.rst:153: WARNING: Could not lex literal_block as "bash". Highlighting skipped.
/home/razvan/school/uso/uso-lab-book.git/chapters/app-dev/make-multiple.rst:55: WARNING: Could not lex literal_block as "bash". Highlighting skipped.
/home/razvan/school/uso/uso-lab-book.git/chapters/app-dev/make-multiple.rst:160: WARNING: Could not lex literal_block as "bash". Highlighting skipped.
/home/razvan/school/uso/uso-lab-book.git/chapters/app-dev/make-multiple.rst:216: WARNING: Could not lex literal_block as "bash". Highlighting skipped.