Git Product home page Git Product logo

Comments (13)

designermonkey avatar designermonkey commented on August 16, 2024

@vlad-ghita that's a good spot there, can you confirm this?

from cachelite.

vlad-ghita avatar vlad-ghita commented on August 16, 2024

I stumbled on it already. Yes, I can confirm this.

from cachelite.

designermonkey avatar designermonkey commented on August 16, 2024

If anyone knows how to achieve this, can you pick it up please?

from cachelite.

vlad-ghita avatar vlad-ghita commented on August 16, 2024

Quick fix:

Uninstall Cachelite.
Install Cachelite.

Hopefully, it will get the highest ID in tbl_extensions table and thus fire latest (after URL Router).

Though I think Sym 2.3 executes extension delegates alphabetically in Extenion order ... sucks :(

Ideal option ... custom delegate execution order editable in Admin ;;)

from cachelite.

designermonkey avatar designermonkey commented on August 16, 2024

Maybe @brendo can shed some light on how we could do this?

from cachelite.

nickdunn avatar nickdunn commented on August 16, 2024

Agreed, CacheLite should be updated so that it waits for the page to be properly resolved first.

from cachelite.

designermonkey avatar designermonkey commented on August 16, 2024

Would anyone like to take charge of this?

from cachelite.

jensscherbl avatar jensscherbl commented on August 16, 2024

Depends on how fast you need it. I would do it, but could take a few days before I actually get to do it.

from cachelite.

designermonkey avatar designermonkey commented on August 16, 2024

There's no urgency, just a need to take ownership of the update.

Really appreciate it Jens.

from cachelite.

brendo avatar brendo commented on August 16, 2024

While there is no way to currently make Cachelite execute before URL Router (see #993), I think this issue can be solved by using the information that is passed via the delegate instead of using the $_GET array.

The FrontendPageResolved delegate passes back the page_data of the resolved page, which contains the current page path which looks like it may simplify the logic of that _in_excluded_pages() function.

from cachelite.

jensscherbl avatar jensscherbl commented on August 16, 2024

@brendo Thanks. Will try that.

from cachelite.

vlad-ghita avatar vlad-ghita commented on August 16, 2024

@jensscherbl

Any updates on this?

from cachelite.

jensscherbl avatar jensscherbl commented on August 16, 2024

Will push an update next week, sorry for the delay.

from cachelite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.