Git Product home page Git Product logo

Comments (12)

andrewminton avatar andrewminton commented on July 17, 2024

Figured it out! We need the generate() function to make the object into a string.

$xml = DomDocument::loadXML($context['xml']->generate());

from cachelite.

brendo avatar brendo commented on July 17, 2024

Yep, the signature changed of the FrontendOutputPreGenerate delegate to pass an XMLElement object instead of a string.

from cachelite.

andrewminton avatar andrewminton commented on July 17, 2024

Cool beans! Cachelite working with 2.4 now then..

from cachelite.

nitriques avatar nitriques commented on July 17, 2024

Great !

from cachelite.

nitriques avatar nitriques commented on July 17, 2024

@andrewminton Would you mind sending a PR with this commit please: f5ea821 ? Thanks mate!

from cachelite.

andrewminton avatar andrewminton commented on July 17, 2024

To your repo?

from cachelite.

nitriques avatar nitriques commented on July 17, 2024

No to here! It still not merged in here...

from cachelite.

andrewminton avatar andrewminton commented on July 17, 2024

Hmmmmm ok. Thought it was.

from cachelite.

andrewminton avatar andrewminton commented on July 17, 2024

Can't send a pull request as I do seem to have read/write access already. Do you want to manually merge the changes in?

from cachelite.

andrewminton avatar andrewminton commented on July 17, 2024

Sorry, Github link to my commit was making me think it was actually a push to the Symphonists repo instead of my group repo... PR sent now.

from cachelite.

nitriques avatar nitriques commented on July 17, 2024

Thanks !

from cachelite.

nitriques avatar nitriques commented on July 17, 2024

@andrewminton @brendo this can be closed now since #18 has been merged. Thanks!

from cachelite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.