sylvainde / guitartabs Goto Github PK

Python 0.37% HTML 99.62% CSS 0.01% Shell 0.01%

guitar-tabs guitar-chords guitar-tablature ukulele-chords python beautifulsoup beautifulsoup4 beautiful-soup kindlegen kindle

guitartabs's Introduction

Collect tabs from various websites and group them into an ebook (for Kindle)

Source \ Supported features	Basic content	Chord aligned	Chord short description	Chord long description
azchords.com	Yes	Yes
boiteachansons.net	Yes
e-chords.com	Yes	Yes	Yes	Yes
guitaretab.com	Yes	Yes	Yes	Yes
guitartabs.cc	Yes	Yes	Yes
guitartabsexplorer.com	Yes	Yes
songsterr.com
tabs4acoustic.com	Yes	Yes	Yes
ultimate-guitar.com	Yes	Yes	Yes	Yes

The files in output correspond to the output with the file input_examples/list_of_urls_of_tabs.txt.

Usage

usage: main.py [-h] [--mobi] [--pdf] [--tabfile TABFILE] [--listfile LISTFILE] [--output OUTPUT] [--name NAME]

Download tabs and generate HTML and/or PDF and/or Mobi files

optional arguments:
  -h, --help            show this help message and exit
  --mobi, -m            Generate mobi file
  --pdf, -p             Generate pdf file
  --tabfile TABFILE, -t TABFILE
                        File containing URL for tabs
  --listfile LISTFILE, -l LISTFILE
                        File containing URL for lists of tabs
  --output OUTPUT, -o OUTPUT
                        File containing URL for lists of tabs (".html" suffix not required)
  --name NAME, -n NAME  Name for for generated book

guitartabs's People

Contributors

Stargazers

Watchers

guitartabs's Issues

Chords from boiteachansons are not properly retrieved anymore

Html format has changed in the last months - see 562c98a (and in particular the html output)

Handle tabs from various websites

HTML format for https://www.tabs4acoustic.com seems to be changed

Create Kindle Dictionnary for Chords

This would be pretty cool to have the definition shown when the cursor goes on a Chord name.

https://kdp.amazon.com/en_US/help/topic/G2HXJS944GL88DNV#kindlegen

Better printing format

Current CSS is minimal but tweaks to the printing format could be handled. It would be a nice touch to have a new page after each song.

Handle new data from UltimateGuitar tabs

Visiting ultimateguitare.com recently, I had the feeling that a few things had changed (piano tabs ?).
This would not appear in my local tests as I have a cache of webpages retrieved. It may be worth trying to move the cache and check how different the new results are (is everything working properly ? are there any relevant pieces of information we could rely on ?)

Invalid HTML content for some tabs

GuitarTabFromGuitarTabDotCom -> ok
GuitarTabFromGuitarTabsExplorer -> not perfect

https://www.guitartabsexplorer.com/ac-dc-Tabs/highway-to-hell-tab.php -> extra "&"

GuitarTabFromGuitarTabsDotCc -> ok
GuitarTabFromTabs4Acoustic -> ko

All songs: extra "pre" starting the tab content

GuitarTabFromUltimateGuitar -> not perfect

https://tabs.ultimate-guitar.com/tab/elvis-presley/cant-help-falling-in-love-chords-1086983 -> extra "&"
empty "pre" for pro tabs

GuitarTabFromEChords -> ok

https://www.e-chords.com/tabs/pink-floyd/comfortably-numb&v=2 (and many other) -> extra "&" in url

GuitarTabFromSongsterr -> ok

https://www.azchords.com/b/beatles-tabs-410/alltogethernow-tabs-816351.html -> extra "&"

GuitarTabFromBoiteAChansons

https://www.boiteachansons.net/artistes/israel-kamakawiwo` -> problem with quote

tbc

Pretty print strumming patterns

The strumming pattern is described via a list of values, a denuminator integer and a is_triplet flag.
On the ultimateguitar website, this is rendered in different ways that would be nice to emulate somehow.

First step is to collect data and see how they are displayed on the original website.

Some lists from boiteachansons are not retrieved properly

$ python main.py -l input_examples/list_of_urls_of_list.txt

https://www.boiteachansons.net/partitions/nouveautes: 0 tabs retrieved
https://www.boiteachansons.net/partitions/top50Chansons: 0 tabs retrieved
https://www.boiteachansons.net/partitions/Z: 0 tabs retrieved


https://www.boiteachansons.net/partitions/aleatoire: 50 tabs retrieved
https://www.boiteachansons.net/artistes/the-beatles: 206 tabs retrieved

Unexpected new content if tabs from TabsExplorer

Following an update of the HTML cache, it appears that the content for tabs from TabsExplorer is slightly different than it used to be.
A cleanup would probably be nice.

HTML escaping for UltimateGuitarTabs is not quite right

For https://tabs.ultimate-guitar.com/tab/the-beatles/here-comes-the-sun-tabs-201130 for instance, we can see:

1 & 2 & 3 & 4 & 5 & 6 & 1 & 2 & 1 & 2 & 3 & 4 &

Corresponding HTML code is:

1 &amp; 2 &amp; 3 &amp; 4 &amp; 5 &amp; 6 &amp; 1 &amp; 2 &amp; 1 &amp; 2 &amp; 3 &amp; 4 &amp;

This should have been:

1 & 2 & 3 & 4 & 5 & 6 & 1 & 2 & 1 & 2 & 3 & 4 &

Corresponding HTML code is:

1 & 2 & 3 & 4 & 5 & 6 & 1 & 2 &

This is caused by the call to content = htmlmodule.escape(content) but removing it is not a solution. Indeed, in a different song, the HTML code becomes ...end harmonica solo.> instead of ...end harmonica solo.>. This leads to invalid HTML code (detected by kindlegen).

A better solution should be found.