Builiding product from prototype about sylius HOT 4 CLOSED

Can you check again now? It should be fixed in e0895f0.

from sylius.

No, still error while executing insert. I update app completly and make the fix, but the exception is present.

from sylius.

Hi, could fix this problem but the changes was made in AssortmentBundle, i comment here because i post here, maybe you can move it to AssortmentBundle issue.
When you create a product normaly, it dispatch 4 events

sylius.product.pre_create
sylius.product.pre_update
sylius.variant.pre_create
sylius.variant.pre_update

And sylius.listener.image_upload is listening this event, when its hear this event it make all about image...

The problem its when you create a product from prototype, any of this event are dispatch, so path in INSERT INTO sylius_variant_image is empty and throw an exception.

To fix it I chage
AssortmentBundle\Controller\PrototypeController, buildAction. When form is POST i call $productController->create (inherit FROM RESOURCE CONTROLLER) , it persis,flush and dispatch event.
I delete the persist and flush directly from the $productController->getManager().

It look so

public function buildAction(Request $request, $id)
{
    $prototype = $this->findOr404(array('id' => $id));
    $productController = $this->getProductController();

    $product = $productController->createNew();

    $this
        ->getBuilder()
        ->build($prototype, $product)
    ;

    $form = $productController->getForm($product);


    if ($request->isMethod('POST') && $form->bind($request)->isValid()) {            

        //$manager = $productController->getManager();
        //$manager->persist($product);
        //$manager->flush();

        $productController->create($product);   

        $productController->setFlash('success', '%resource% has been successfully created.');

        return $productController->redirectTo($product);
    }

    return $productController->renderResponse('build.html', array(
        'prototype' => $prototype,
        'product'   => $product,
        'form'      => $form->createView()
    ));
}

Now when you create a product from prototype and choose a image it work all fine.

Greeting,
Carlos

from sylius.

This is the fix indeed! Thanks for debugging the issue. Can you open a PR for assortment bundle?

Simplest way to do it, is to install vendors with composer install --prefer-source. Then inside vendors/sylius/assortment-bundle... you'll have Sylius assortment bundle repository. You can fork it, add as remote and push your changes there - finally open PR. :) Or you can just fork&clone assortment bundle, make the changes, push, open PR.

I can help you with all that if you want. Thanks!

from sylius.