Support UITableViewCell & UICollectionViewCell identifiers about swiftgen HOT 17 OPEN

Hi @netbe

The feature is still definitely in our roadmap, and we actually renamed the storyboard subcommand to ib in the latest 6.0 release, and rearranged the parsers in SwiftGenKit too… in order to better prepare for supporting that (as this won't be limited to storyboards anymore, and parsers are better arranged now to be more flexible for that)

The previous Pull Requests though won't probably completely fit anymore the new code organization, so we might need to rewrite those, but that should actually be easier now, hopefully.

I won't give you a deadline though, as I'm not sure how much free time we'll have between all contributors to work on this, so when this will be done, but any contribution in that direction is welcome

from swiftgen.

Probably better wait for #24 before starting to work on this issue

from swiftgen.

Hey @AliSoftware ! In developing a tool with similar features to SwiftGen I built a library that makes extracting (eventually) everything, including UITableViewCell and UICollectionViewCell identifiers in Storyboards much easier. It may be overkill for your use but the library is StoryboardKit.

To see UITableView Identifier extraction check seguecode's usage here: ViewControllerClassInfo+seguecode.swift Line 35-66

from swiftgen.

Hey @yoiang

Thanks for the input, will take a look later in the week!

from swiftgen.

+1 on this. I suggest adding UICollectionViewCell to the issue title (they are easy to forget about 😉).

from swiftgen.

+1

from swiftgen.

Feel free to make a PR to make this be implemented and released faster, as I'm pretty busy those days and won't have much time implementing it that soon.

from swiftgen.

No worries :-)
#66

from swiftgen.

My comment is not related to SwiftGen, but as its user I'll comment anyway.
For UITableViewCell and UICollectionViewCell it's quite good practice to use class names as identifiers.
You can do it with extenstion like this one:

extension UITableView {

    public func dequeueReusableCell<T:UITableViewCell>(type: T.Type) -> T {
        let tableCell       : T
        let cellIdentifier  = String(T)

        if let cell = self.dequeueReusableCellWithIdentifier(cellIdentifier) as? T {
            tableCell = cell
        } else if let _ = NSBundle(forClass: T.classForCoder()).pathForResource(cellIdentifier, ofType:"nib") {
            registerNib(UINib(nibName: cellIdentifier, bundle: nil), forCellReuseIdentifier: cellIdentifier)
            if let cell = NSBundle(forClass: T.classForCoder()).loadNibNamed(cellIdentifier, owner: nil, options: nil)[0] as? T {
                tableCell = cell
            } else {
                //if anyone had better suggestion for fallback, you're welcome to comment
                tableCell = T(style: .Default, reuseIdentifier: cellIdentifier)
            }
        } else {
            tableCell = T(style: .Default, reuseIdentifier: cellIdentifier)
        }
        return tableCell
    }
}

In code you use it like this:

let cell = tableView.dequeueReusableCell(CommentVideoCell)

This actually solves 3 problems:

• XIB naming
• Identifier naming
• Do don't need to register your cells explicitly

So you can avoid magic string in both cases.
Of course, there are cases when you need more than 1 identifier for some cell, but truly, during few years of iOS development I haven't found too many cases like this.

As for UICollectionViewCell you can find similar code here:
https://gist.github.com/krodak/25680b1ec18e750f6ddd

from swiftgen.

@krodac I guess you didn't read about my comment on #66 and my pod Reusable library then 😉

from swiftgen.

@aisoftware - yes, I missed it ;-) But looking at it now it's not exactly the same approach, is it?

from swiftgen.

Just had a great idea for a template once this is implemented. Since Reusable looks up the cell identifier based on the value of the reuseIdentifier property, a swiftgen template could generate an extension for every custom *Cell class found, simply supplying the reuseIdentifer that was found in the storyboard. I think this would eliminate the possibility of the two getting out of sync.

from swiftgen.

@phatblat Sounds good to me! Don't hesitate to piggy-back on #66 to discuss that and make it happen the way you just described!

from swiftgen.

I'm on it! 🏃

from swiftgen.

The new reference PR to implement that is now SwiftGen/SwiftGenKit#16

from swiftgen.

@AliSoftware is that still wip ?

from swiftgen.

@AliSoftware thanks for the update

from swiftgen.