Git Product home page Git Product logo

ws_flexslider's Introduction

ws_flexslider's People

Contributors

anubiso avatar davidbruchmann avatar froemken avatar jacobsenj avatar jfr avatar macjohnny avatar svewap avatar tobiasgraeber avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

ws_flexslider's Issues

Tag 1.4.1

Could you please tag the current version 1.4.1.

Thank you

Support lazy loading for images

Hi!

Is there a possibility to activate lazy loading for images?
If not, I guess this would be a nice/helpful feature for the future.

settings.templateLayout

How to set own templateLayout setting? In Plugin Options BE is only empty field with no choice to set this value.

Problems with localized drafts

Hi,

we utilize Flexslider at our TYPO3 (v7.6) site with two languages. Within a page a localized flexslider plugin element is placed. The editors work in draft enviroments.

After an image is added to the Flexslider element, the editor switches to the localized view. There he/she adds the localized image, too. But it is impossible to edit the description text. After hitting "save" the text is reverted. I investigated the data changes inside tx_wsflexslider_domain_model_image table. Title and other data will be changed on save, only description won't.

Another issue is the deletion of image items within the localized plugin. After delete and save the image item appears again. But i found, that the image is actually deleted, but still shown. After putting the changes to live environment the item is gone.

These are behavoiors that occur in draft editing mode with a localized plugin element.

Regards
Nyro

Boolean values as string

In the current version boolean JavaScript-values (true / false) are wrapped in quotes and therefore become strings. This breaks functionality and should be reverted.

Example of the fault:

<script type="text/javascript">
/*<![CDATA[*/
/*flexslider-66*/


    jQuery(document).ready(function() {
        jQuery('#flexslider-66').flexslider({
            animation: "fade",
            animationLoop: "true",
            itemMargin: "0",
            easing: "swing",
            direction: "horizontal",
            reverse: "false",
            smoothHeight: "true",
            startAt: "0",
            slideshow: "false",
            slideshowSpeed: "3500",
            animationSpeed: "500",
            initDelay: "0",
            randomize: "true",

            pauseOnAction: "true",
            pauseOnHover: "0",
            useCSS: "true",
            touch: "true",
            video: "false",

            controlNav: "false",
            directionNav: "false",
            prevText: "Zurück",
            nextText: "Weiter",

            keyboard: "false",
            multipleKeyboard: "false",
            mousewheel: "false",
            pausePlay: "false",
            pauseText: "Pause",
            playText: "Abspielen",

            controlsContainer: "",
            manualControls: "",
            sync: "",
            asNavFor: "",

            itemWidth: "0",
            itemMargin: "0",
            minItems: "0",
            maxItems: "0",
            move: "0",

            carousel: "false",
            start: function(slider){
                jQuery('body').removeClass('loading');
            }
        });
    });

    

/*]]>*/
</script>

It should be like this:

<script type="text/javascript">
/*<![CDATA[*/
/*flexslider-66*/


    jQuery(document).ready(function() {
        jQuery('#flexslider-66').flexslider({
            animation: "fade",
            animationLoop: true,
            itemMargin: "0",
            easing: "swing",
            direction: "horizontal",
            reverse: false,
            smoothHeight: true,
            startAt: "0",
            slideshow: true,
            slideshowSpeed: "3500",
            animationSpeed: "500",
            initDelay: "0",
            randomize: true,

            pauseOnAction: true,
            pauseOnHover: false,
            useCSS: true,
            touch: true,
            video: false,

            controlNav: false,
            directionNav: false,
            prevText: "Zurück",
            nextText: "Weiter",

            keyboard: true,
            multipleKeyboard: false,
            mousewheel: false,
            pausePlay: false,
            pauseText: "Pause",
            playText: "Abspielen",

            controlsContainer: "",
            manualControls: "",
            sync: "",
            asNavFor: "",

            itemWidth: "0",
            itemMargin: "0",
            minItems: "0",
            maxItems: "0",
            move: "0",

            carousel: false,
            start: function(slider){
                jQuery('body').removeClass('loading');
            }
        });
    });

    

/*]]>*/
</script>

Add constant for jquery.flexslider js

Just like plugin.tx_wsflexslider.includejquerycore, I would love the possibility of disabling the jQuery FlexSlider JavaScript inclusion.

This comes in handy working with a module bundler at least. I can provide a PR if you want!

Thanks for your hard work.

Adding slides using list module does not allow association with content element

Users on my site are adding flexslider images using the List module and "Images" table. However, when doing that, the slides are not associated with a content element (ie. the content_uid field gets set to 0). Thus, the slides do not show up. Is there a way for editors to link the image record to a content element, eg through a dropdown? Alternatively, would there be some Typoscript that could be used in the page template which would set the content_uid to a certain value (perhaps assuming there is only one slider on a page)?
Thanks.

height issue when changing to slide animation

When i use the fade animation everything works like a charm. Smooth fade and everything is working as expected.
But when i change to the slide animation, suddenly i get a huge blank space with a height of 2000px.
It's no big deal, but it would be nice to have the option.
And, on a personal note, i just want to know why this strange behaviour happens.

Edit: Is there a reason, why the flexslider.js is still 2.2.2, while the current version is 2.6.4?

Unknown type: select, render type: select with TYPO3 10 LTS/ws_flexslider 1.5.12

Hello,

most fields on 'Erweiterungsoptionen' show errors - 'Unknown type: select, render type: select'.

Tested on two fresh TYPO3 104 (LTS)-Installations with PHP 7.3.11.

Check TCA Migarations shows up "The 'tx_wsflexslider_domain_model_image' TCA configuration 'showRecordFieldList' inside the section 'interface' is not evaluated anymore and should therefore be removed".

Best regards
wini2

jquery is very old

Hey Sven,

Standard jquery in the extension is 1.7.2 which is very old and shows an error in chorme.
I played around with jquery and the last version that works ist 1.8.2

[globalVar = LIT:1 = {$plugin.tx_wsflexslider.includejquerycore}]
page.includeJSFooterlibs {
#jquery = http://ajax.googleapis.com/ajax/libs/jquery/1.8.3/jquery.min.js
#jquery = http://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js
jquery = http://ajax.googleapis.com/ajax/libs/jquery/1.8.2/jquery.min.js
jquery.external = 1
jquery.forceOnTop = 1
}
[global]

All higher versions will make some problems - in espacially in mobile versionsof the website, for example take a look at chrome.

I am using TYPO3 8 and 1.5.9 of the slider.

Cheers,
Andrea

Bug: Language is not respected

When we added a localization, the slider was showing images from both languages.

Setting $query->getQuerySettings()->setRespectSysLanguage(true) in the createQuery() in class ImageRepository seems to resolve this.

public function createQuery() { $query = parent::createQuery(); $query->getQuerySettings()->setRespectStoragePage(false); $query->getQuerySettings()->setRespectSysLanguage(true); return $query; }

In 7.6.4 text-field has no RTE

Hi,

in 7.6.4 using ws_flexslider 1.5.0 the text-field has no RTE. In the field it is possible to write html and it is rendered in frontend but the RTE is not shown. A short look into the code (without being any kind of expert) promises that this is no intention...

Bye
Markus

JS Bug with PHP 7.3?

Hi!
I´ve switched from PHP 7.2 to 7.3 in an TYPO3 9.6 with Flexslider 1.5.14. That leads die JS-Errors because of different inline js:

PHP 7.3:

jQuery(document).ready(function(){jQuery('#flexslider-59').flexslider({animation:"fade",animationLoop:!0,itemMargin:"0",easing:"swing",direction:"horizontal",reverse:!1,smoothHeight:!1,startAt:"0",slideshow:!0,slideshowSpeed:"6000",animationSpeed:"2000",initDelay:"0",randomize:!1,pauseOnAction:!0,pauseOnHover:!0,useCSS:!0,touch:!0,video:!1,controlNav:!1,directionNav:!0,prevText:"Zurück",nextText:"Weiter",keyboard:!0,multipleKeyboard:!1,mousewheel:!1,pausePlay:!1,pauseText:"Pause",playText:"Abspielen",controlsContainer:"{settings.controlsContainer}",manualControls:"{settings.manualControls}",sync:"{settings.sync}",asNavFor:"{settings.asNavFor}",itemWidth:"{settings.itemWidth}",itemMargin:"{settings.itemMargin}",minItems:"{settings.minItems}",maxItems:"{settings.maxItems}",move:"{settings.move}",carousel:{settings.carousel},start:function(slider){jQuery('body').removeClass('loading')}})});

Problem width PHP 7.3 here -> "{settings.controlsContainer}" instead of ""

PHP 7.2:

jQuery(document).ready(function(){jQuery('#flexslider-59').flexslider({animation:"fade",animationLoop:!0,itemMargin:"0",easing:"swing",direction:"horizontal",reverse:!1,smoothHeight:!1,startAt:"0",slideshow:!0,slideshowSpeed:"6000",animationSpeed:"2000",initDelay:"0",randomize:!1,pauseOnAction:!0,pauseOnHover:!0,useCSS:!0,touch:!0,video:!1,controlNav:!1,directionNav:!0,prevText:"Zurück",nextText:"Weiter",keyboard:!0,multipleKeyboard:!1,mousewheel:!1,pausePlay:!1,pauseText:"Pause",playText:"Abspielen",controlsContainer:"",manualControls:"",sync:"",asNavFor:"",itemWidth:"0",itemMargin:"0",minItems:"0",maxItems:"0",move:"0",carousel:!1,start:function(slider){jQuery('body').removeClass('loading')}})});

It´s an old, big installation, so could also have other causes (maybe configuration issue?!).
But switching back to PHP 7.2. fixed the mentioned problem.

Maybe someone can confirm that issue?

Best
Christoph

task: TCA Migration

image

  • The TCA setting 'mergeIfNotBlank' was removed in TCA tx_wsflexslider_domain_model_image['columns']['fal_image']['l10n_mode'] and changed to tx_wsflexslider_domain_model_image['columns']['fal_image']['config']['behaviour']['allowLanguageSynchronization'] = true
  • The TCA setting 'localizationMode' is deprecated and should be removed from TCA for tt_content['columns']['tx_wsflexslider_images']['config']['behaviour']['localizationMode']
  • The link wizard has been migrated to a 'renderType' => 'inputLink '. It has been migrated from TCA table "tx_wsflexslider_domain_model_image['columns']['link']['config']['wizards']['link']" to "tx_wsflexslider_domain_model_image['columns']['link']['config']['renderType'] = 'inputLink'".
  • The 'foreign_types' property from TCA tx_wsflexslider_domain_model_image['columns']['fal_image']['config'] and has been migrated to tx_wsflexslider_domain_model_image['columns']['fal_image']['config']['overrideChildTca']['types']

Version 1.2.7 won't wok with config.sys_language_mode = strict

When using config.sys_language_mode = strict following error occurs:

#1: PHP Warning: spl_object_hash() expects parameter 1 to be object, null given in /typo3_src-6.2.10/typo3/sysext/extbase/Classes/Persistence/ObjectStorage.php line 147

Can somebody confirm this issue? Any idea how to fix this in a quick way?

Version 1.5.5 and more languages

Hi,

my webpage is configured in two languages:

  language = sk
  locale_all = sk_SK.utf8
  htmlTag_langKey = sk-SK
  linkVars = L
  sys_language_uid = 0
  sys_language_overlay = 1
  sys_language_mode = content_fallback;1,0

default is Slovak and second language for translation is English. I'm using also the extension sr_language_menu:
plugin.tx_srlanguagemenu.defaultLanguageTitle = Slovak

I can change plugin Language to Slovak/English as for all content elements on webpages (first picture)

one

but when I try to set the language for specified image (second picture), the options differs from original one. There is Default instead of Slovak (default)
two

I've done the translation of plugin to EN. The language of images I set in database to 0, but it didn't help. The plugin added a lot of images links without any effect.

Is it connected with the incompatibility of extensions or something else?

Usage of feInterface is no longer part of the TYPO3 CMS Core

Entries in deprecation.log:

03-08-15 04:07: Usage of feInterface is no longer part of the TYPO3 CMS Core. Please check EXT:ws_flexslider.
03-08-15 04:07: TYPO3\CMS\Core\Utility\GeneralUtility::loadTCA() - since 6.1, will be removed two versions later

Affected version: EXT:ws_flexslider version 1.4.1

settings.showCaption not offered in content element form

Hi,
I wanted the option to hide the image captions. I saw the option is already there, as it is specified in flexform.xml. But the form field does not appear in my BE content element form.
TYPO3 8.7.9, ws_flexslider 1.5.5
Thanks and thumbs up!
Nils

Slider title

First of all - thanks for taking care, Sven.
I use TYPO3 8 and ws_flexslider 1.5.9.
Would be great if I can chose title and can also chose "hide title" like in normal content elements. So I could chose if I would like to have a text on the slider image or not.
This would be really helpful iin multilanguage pages - and also for an overview of the slider elements.
No title is IMHO not really helpful.

What do you think?

Cheers,

Andrea

Link is not updating correctly

In TYPO3 v7.6 there's a bug while I try to update the link of the image in Flexslider.

This is the file where that field is defined:
typo3conf/ext/ws_flexslider/Configuration/TCA/Image.php

and in this line (188) is possibly the error:
'softref' => 'typolink[linkList]',

should be:
'softref' => 'typolink,typolink_tag,images,url',

The problem, while selecting the link from a page the hidden field is not being updated. Saving the page doesn't update the ID correctly (there's still the old value).

If I enter the ID manually in the input field it is being saved correctly, because the hidden field is being updated. Why is this happening? Can anyone reproduce this?

typo3_bug_flexslider_link

deprecation warning for condition

component="TYPO3.CMS.Frontend.Configuration.TypoScript.ConditionMatching.ConditionMatcher": Expression could not be parsed. - {"expression":"globalVar = LIT:1 = "}

TYPO3 10.4
ws_flexslider 1.5.14

DynLinkViewHelper not found typo3-7.6 - ver 1.5.0 - 1.5.4

Could not analyse class: "WapplerSystems\WsFlexslider\ViewHelpers\DynLinkViewHelper" maybe not loaded or no autoloader? Class WapplerSystems\WsFlexslider\ViewHelpers\DynLinkViewHelper does not exist

I'm trying to use flexslider
but there is no DynLinkViewHelper.php in ws_flexslider/Classes/ViewHelpers/
How can I fix this?

Icon Fonts are not loading in TER-Version 1.5.7 of the Extension

TYPO3-ter version 1.5.7 comes with CSS of jQuery FlexSlider v2.7.1 which has no declarations for font-icons in flexslider.css, i.e. the fonts in the font dir are not loaded. The Version here on github and the one on packagist comes with the older CSS from FlexSlider v2.2.0, which loads the fonts.

In the original Version of the jQuery FlexSlider, which is offered here https://woocommerce.com/flexslider/ the declaration for the font integration are located in the demo.css. In v2.7.0 they are still in flexslider.css

No Page cache

Hi,
We are using the ws_flexslider extension on one page.
We are using the extension nc_staticfilecache and the cache is generated normally for every page.
Except the ones with the ws_flexslider.

We got this "error" from the nc_staticfilecache extension
page has INTincScript:
tx_extbase_core_bootstrap->run

I guess it has something to do that the extension is preventing the generation of cache because of beeing a USER_INT object?

Is there anything how I could solve this issue?
best regards

Errormessage: 'No class named WapplerSystems\WsFlexslider\Hooks\ItemsProcFunc' (62 chars)

When i insert a new element with WS Flexslider i get a error message

'No class named WapplerSystems\WsFlexslider\Hooks\ItemsProcFunc' (62 chars)

and at the end i get a error on the Webside "Oops, an error occurred! Code: 201710230942070443c246"

I use Typo3 7.6.23
Php-Version: 5.6.30-0+deb8u1
ws_flexslider 1.5.4
OS: Debian Jessie

I insert two pictures. I didn't change any of the default settings of the plugin.

Bernd

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.