svalkanov / wifivoid Goto Github PK

I have a few ideas as to how to help you out, but as there are no unit tests I lack a good way to validate my changes don't actually break anything,

https://github.com/SValkanov/wifivoid/blob/master/lib/hash_patch.rb

A) Generally speaking, it's not a good idea to monkey patch core classes. If you know what you're doing, you're aware of the dragons that lie that way... if you don't, beware, that way leads to nothing but dragons...

B) You don't ever actually use this method as far as I can tell, so there's no reason to have it included and it should be removed anyway.

c) I'm not sure this even does what you expect... but without unit tests, it's kinda hard to say.

It's clear that this is designed as a proof of concept and isn't intended for people to use to attack their neighbours. However, you should make that explicitly clear with the use of a proper license.

GNU, GPL, and MIT, I think all make for appropriate umbrellas for releasing this type of code but IANAL! so I am far from qualified to give legal advice. (I generally refer to what license is nmap released under) I think you're releasing this code in good faith (e.g.: you literally can't control how someone will use your code, and if you thought it up, someone else is bound to eventually think it up too...), so, I'd rather be able to see your code and figure out how to protect against it than be blind sided.,..