suyoin / rbxts-fabric Goto Github PK

In a new project with no previous imports from Reducers or Symbol, exports from these definition files do not appear in the intellisense.

import { } from "@rbxts/fabric/src/FabricLib/Fabric/Operators/Reducers";
import { named } from "@rbxts/fabric/src/FabricLib/Shared/Symbol";

Whatever handles the intellisense does not randomly look in package subdirectories to look for definition files.

getOrCreateUnit<TAdd extends keyof FabricUnits>(
	unitResolvable: TAdd
): ThisFabricUnit<TAdd>;

Not sure how to write the conditional for this.

I believe augmenting the @rbxts/roact types like

declare global {
	namespace JSX {
		interface IntrinsicAttributes {
			[key in keyof FabricUnits]: FabricUnit<key>["data"];
		}
	}
}

would work.

Given this sample,

import { UnitDefinition, ThisFabricUnit } from "@rbxts/fabric";

declare global {
	interface FabricUnits {
		ExampleUnit: ExampleUnitDefinition;
	}
}

interface ExampleUnitDefinition extends UnitDefinition<"ExampleUnit"> {
	foo(this: ThisFabricUnit<"ExampleUnit">): void;
}

The ExampleUnitDefinition interface does not have any intellisense for properties like data, ref, or _addLayerData

the DEBUG field of the Fabric class makes it inaccessible to disable DEBUG mode. To fix change protected to public.

declare class Fabric {
	public DEBUG: boolean;

https://github.com/suyoin/rbxts-fabric/blob/main/src/FabricLib/Fabric/Types.d.ts#L39

It only checks a definition's data field. Not sure how to do conditionals inside of interfaces like these.