Git Product home page Git Product logo

authentication-challenge-template's People

Contributors

david35008 avatar moran1324 avatar

Watchers

 avatar  avatar

authentication-challenge-template's Issues

refresh or access?

GET path: /api/v1/users, description: Get users DB (admin only),

Request template: header {Authorization: "Bearer -access token-"}
Server Responses: status 200, body: {USERS: [...[{email, name, password, isAdmin}]} | status 401 "Refresh Token Required" | status 403 "Invalid Refresh Token".

does this get a refresh token or access?

Problematic for use with react router

if all the endpoints are not in one file, you cant use arrays for users and information, because both /users endpoints and /api endpoints need them.
one solution is using fs and .json files, but this creates a problem with reseting for tests and adding the users - it seem to mess with the way bcrypt creates a hash

Typo in README

It is written in the readme that login entry point gets in the body the object : {user,email,password}, but in the test it recives: {name,email,password}.
Makes some of the tests to fail, not fun

INFORMATION of the USERS is not uniquely identified

currently only the email of the user is a unique field.
so if each item in the INFORMATION array for all the users is represented by the name of the user, users with the same name will get their information mixed up.

image

status 400 or 401

POST path: "/users/logout", description: Logout Session.

Request template: body: {token: -refresh token-"}
server responses: status 200 "User Logged Out Successfully" | status 400 "Refresh Token Required" | status 400 "Invalid Refresh Token".

Are you sure both errors should be status 400? in other endpoints its 401 for "Refresh Token Required"

user description in read me

"USERS [...{email, user, password, isAdmin},{}...]"

it should be "[...{email, name, password, isAdmin},{}...]"

Dependencies version Error

Hi, after running "npm i" in both the client and the root directory,
The react command "npm start" shows the following error:

image

The client cannot be run at all.
The challenge still works but the client experience is missing.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.