Git Product home page Git Product logo

Comments (7)

d10r avatar d10r commented on September 27, 2024 1

Agree, we need to handle this mappings in metadata.
The numerical chainId is the only deterministic and unique identifier we can rely on across the ecosystem.
Going forward we should try to minimize the amount of non-SF-specific information we need to manually maintain in metadata in order to keep maintenance overhead of shuffling networks low.
Can be done by adding a postprocessing step to metadata (or just add to the existing build script) which pulls in relevant metadata provided by others, e.g. https://github.com/wagmi-dev/viem/tree/main/src/chains/definitions , and merges that with SF-specific metadata.

from protocol-monorepo.

0xdavinchee avatar 0xdavinchee commented on September 27, 2024

attempting to redeploy subgraph: https://github.com/superfluid-finance/protocol-monorepo/actions/runs/6865195493

it is quite a confusing issue otherwise

from protocol-monorepo.

0xdavinchee avatar 0xdavinchee commented on September 27, 2024

looks like the optimism-goerli subgraph is quite outdated, I would reckon that this is related to the issue.

from protocol-monorepo.

hellwolf avatar hellwolf commented on September 27, 2024

do we redeploy?

from protocol-monorepo.

0xdavinchee avatar 0xdavinchee commented on September 27, 2024

I tried to but there was an issue in buildNetworkConfig.ts due to inconsistencies between what we've decided to go with in terms of canonical names in shortName or name in metadata.

Addressing this root issue, once and for all here: #1748.

Placing the canonical name in metadata once and then we can just forget about it and use the canonical name instead.

from protocol-monorepo.

d10r avatar d10r commented on September 27, 2024

fixed and re-synced

from protocol-monorepo.

0xdavinchee avatar 0xdavinchee commented on September 27, 2024

#1747 (comment)

from protocol-monorepo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.