Comments (7)
Agree, we need to handle this mappings in metadata.
The numerical chainId is the only deterministic and unique identifier we can rely on across the ecosystem.
Going forward we should try to minimize the amount of non-SF-specific information we need to manually maintain in metadata in order to keep maintenance overhead of shuffling networks low.
Can be done by adding a postprocessing step to metadata (or just add to the existing build script) which pulls in relevant metadata provided by others, e.g. https://github.com/wagmi-dev/viem/tree/main/src/chains/definitions , and merges that with SF-specific metadata.
from protocol-monorepo.
attempting to redeploy subgraph: https://github.com/superfluid-finance/protocol-monorepo/actions/runs/6865195493
it is quite a confusing issue otherwise
from protocol-monorepo.
looks like the optimism-goerli subgraph is quite outdated, I would reckon that this is related to the issue.
from protocol-monorepo.
do we redeploy?
from protocol-monorepo.
I tried to but there was an issue in buildNetworkConfig.ts
due to inconsistencies between what we've decided to go with in terms of canonical names in shortName
or name
in metadata.
Addressing this root issue, once and for all here: #1748.
Placing the canonical name in metadata once and then we can just forget about it and use the canonical name instead.
from protocol-monorepo.
fixed and re-synced
from protocol-monorepo.
from protocol-monorepo.
Related Issues (20)
- [OPS] Deploy contracts v1.9.1 HOT 15
- [ETHEREUM-CONTRACTS] Get rid of compiler warnings HOT 2
- [Deployer Whitelisting Request] HOT 4
- [PROTOCOL-OPS] scroll-sepolia cannot be upgraded HOT 1
- [SUBGRAPH][FEATURE] Inconsistency: AccountTokenSnapshot has `updatedAt(Timestamp/BlockNumber)` but not the equivalent for "created at"
- [SUBGRAPH] superTokenLogicCreatedEvents missing recent events HOT 3
- [BUG] Ask about the scope of bug bounty HOT 1
- [OPS] DegenChain verification of framework and yoink related contracts HOT 3
- [AUTOMATION] Vesting scheduler execution failed because of repeated create HOT 2
- Subgraph endpoint update required HOT 1
- [ETHEREUM-CONTRACTS] Superfluid: make app gas limit configurable
- [ETHEREUM-CONTRACTS] Superfluid host: allow batchcall operations to fail
- [SUBGRAPH] Native Super Token name empty
- [ETHEREUM-CONTRACTS] Disable FlowNFT hooks
- [ETHEREUM-CONTRACTS] [METADATA] [SDK-CORE] remove flowNFT code
- [PROTO-OPS] Upgrade eth-mainnet from 1.8 to 1.11 HOT 3
- SQF Superapp Factory on Arbitrum HOT 2
- [Deployer Whitelisting Request] SQF on Optimism HOT 2
- [Deployer Whitelisting Request] SQF on Base HOT 2
- [ETHEREUM-CONTRACTS] Upgrade to OpenZeppelin 5 and Rework Its Dependency Management (Breaking Chnage)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from protocol-monorepo.