Git Product home page Git Product logo

Comments (15)

d10r avatar d10r commented on June 16, 2024

scroll-sepolia gov action failing:

$ NETWORK=scroll-sepolia; npx truffle exec --network $NETWORK ops-scripts/deploy-framework.js 
Using network 'scroll-sepolia'.

truffle detected true
use truffle native environment (isTruffle) false
protocol release version: v1
======== Deploying superfluid framework ========
reset superfluid framework:  false
network Type:  private
network ID:  534351
chain ID:  534351
deployer:  0xd15D5d0f5b1b56A4daEF75CfE108Cb825E97d015
app whitelisting enabled: false
truffle detected false
use truffle native environment (isTruffle) false
protocol release version: v1
Checking ERC1820 deployment at 0x1820a4B7618BdE71Dce8cdc73aAB6C95905faD24
ERC1820 is already deployed.
Using @superfluid-finance/js-sdk in a non-native Truffle environment.
                Peer dependency @truffle/contract is required.
Set default from address to the first account 0xd15D5d0f5b1b56A4daEF75CfE108Cb825E97d015
Resolver address 0xB62446a3006d86f6e9eAa36da773c311E7B8AF91
previous versionString: 1.9.0-68a7920579bd96e2
new versionString:      1.9.1-54fd3865fc7f0a46
SuperfluidLoader-v1 address 0xe25603df330027d91A0BAcc3e80a7f9e84930FC6
SuperfluidLoader does not need new deployment.
TestGovernance needs new deployment.
TestGovernance.new: started
TestGovernance.new: done, gas used 1817224, gas price 0.1 Gwei
Superfluid.v1 address 0x42b05a6016B9eED232E13fd56a8F0725693DBF8e
Superfluid does not need new deployment.
initializing TestGovernance with config: {
  "liquidationPeriod": 3600,
  "trustedForwarders": [
    "0xcfA132E353cB4E398080B9700609bb008eceB125",
    "0x6DA13Bde224A05a288748d857b9e7DDEffd1dE08"
  ]
}
governance.initialize: started
governance.initialize: done, gas used 248426, gas price 0.1 Gwei
Setting resolver TestGovernance.v1 -> 0x94aE5f52E401A5766b0877d2f030cFb9C3792BD7 ...
Auto detecting admin type of 0xd15D5d0f5b1b56A4daEF75CfE108Cb825E97d015
Account has no code, assuming ownable contract.
Resolver Admin type: Direct Ownership (default)
Executing resolver action...
Resolver action executed.
governance.replaceGovernance: started
governance.replaceGovernance: done, gas used 41496, gas price 0.1 Gwei
GDAv1 proxy address 0x93fA9B627eE016990Fe5e654F923aaE8a480a75b
===== STARTING UPGRADE PHASE ======
Superfluid logic code has changed
SuperfluidLogic.new: started
SuperfluidLogic.new: done, gas used 4871291, gas price 0.1 Gwei
Superfluid new logic code address 0xDf2F3A7e116575478B72A7A4cc80C219ECE4ca5B
ConstantFlowAgreementV1 logic code has changed
ConstantFlowAgreementV1.new: started
ConstantFlowAgreementV1.new: done, gas used 4728830, gas price 0.1 Gwei
New ConstantFlowAgreementV1 address 0xDD5462a7dB7856C9128Bc77Bd65c2919Ee23C6E1
ConstantFlowAgreementV1 new logic code address 0xDD5462a7dB7856C9128Bc77Bd65c2919Ee23C6E1
InstantDistributionAgreementV1 logic code has changed
SlotsBitmapLibrary.new: started
SlotsBitmapLibrary.new: done, gas used 628833, gas price 0.1 Gwei
SlotsBitmapLibrary address 0xe9F27eb8cdAaA0B01a4034e109496C3026b01bd9
InstantDistributionAgreementV1.new: started
InstantDistributionAgreementV1.new: done, gas used 4610365, gas price 0.1 Gwei
New InstantDistributionAgreementV1 address 0xdAA54C18cE99b84Ce718f56f7E6F70E243550C70
InstantDistributionAgreementV1 new logic code address 0xdAA54C18cE99b84Ce718f56f7E6F70E243550C70
GeneralDistributionAgreementV1 logic code has changed
SuperfluidPoolDeployerLibrary.new: started
SuperfluidPoolDeployerLibrary.new: done, gas used 574539, gas price 0.1 Gwei
SuperfluidPoolDeployerLibrary address 0x1116540FAEc8DC4e6CB80fD5Df3AD514dE51a2e7
GeneralDistributionAgreementV1.new: started
GeneralDistributionAgreementV1.new: done, gas used 5189622, gas price 0.1 Gwei
New GeneralDistributionAgreementV1 address 0x95043eC349476B413eF5c369c4d2454a1a65eaB9
GeneralDistributionAgreementV1 new logic code address 0x95043eC349476B413eF5c369c4d2454a1a65eaB9
checking if SuperTokenFactory needs to be redeployed...
   constantOutflowNFTLogicChanged: true
   constantInflowNFTLogicChanged: true
   poolAdminNFTLogicChanged: true
   poolMemberNFTLogicChanged: true
   superTokenFactoryCodeChanged: true
   superTokenLogicCodeChanged: true
SuperTokenFactory logic code has changed
   factory.getSuperTokenLogic.call()
   getting FlowNFT addrs
   getting PoolNFT addrs
Check-upgrading Flow NFTs...
ConstantOutflowNFT logic code has changed
ConstantOutflowNFT.new: started
ConstantOutflowNFT.new: done, gas used 2008377, gas price 0.1 Gwei
ConstantOutflowNFT Logic address 0xC8DCf0cbB0f02475eBADAbE7daebc5B8b6b81F57
ConstantOutflowNFT new logic code address 0xC8DCf0cbB0f02475eBADAbE7daebc5B8b6b81F57
ConstantInflowNFT logic code has changed
ConstantInflowNFT.new: started
ConstantInflowNFT.new: done, gas used 1835043, gas price 0.1 Gwei
ConstantInflowNFT Logic address 0xF353978890204756fc5fa6dfbD16a91eac9E6f4d
ConstantInflowNFT new logic code address 0xF353978890204756fc5fa6dfbD16a91eac9E6f4d
Check-upgrading Pool NFTs...
PoolAdminNFT logic code has changed
PoolAdminNFT.new: started
PoolAdminNFT.new: done, gas used 1315257, gas price 0.1 Gwei
PoolAdminNFT Logic address 0xf4baE246462166Ad35Bb11Fc9831953664195531
PoolAdminNFT new logic code address 0xf4baE246462166Ad35Bb11Fc9831953664195531
PoolMemberNFT logic code has changed
PoolMemberNFT.new: started
PoolMemberNFT.new: done, gas used 1516877, gas price 0.1 Gwei
PoolMemberNFT Logic address 0x385439D9063cAD130E4786FEAB5A17eD79E648D5
PoolMemberNFT new logic code address 0x385439D9063cAD130E4786FEAB5A17eD79E648D5
SuperTokenLogic.new: started
SuperTokenLogic.new: done, gas used 4403647, gas price 0.1 Gwei
SuperToken new logic code address 0xf759c2EE9D7107E83F9C0dbe6645fBd54eA92644
SuperTokenFactoryLogic.new: started
SuperTokenFactoryLogic.new: done, gas used 2085199, gas price 0.1 Gwei
SuperTokenFactory new logic code address 0xC780A70C45b84ae880a14E60A724579504447bcb
SuperfluidPool logic code has changed
SuperfluidPool.new: started
SuperfluidPool.new: done, gas used 2695181, gas price 0.1 Gwei
New SuperfluidPoolLogic address 0x60f89041bf199A112980ad221971fc47c5D7BE1E
SuperfluidPool new logic code address 0x60f89041bf199A112980ad221971fc47c5D7BE1E
Creting gov action: gov.updateContracts(0x42b05a6016B9eED232E13fd56a8F0725693DBF8e, 0xDf2F3A7e116575478B72A7A4cc80C219ECE4ca5B,
            [0xDD5462a7dB7856C9128Bc77Bd65c2919Ee23C6E1,0xdAA54C18cE99b84Ce718f56f7E6F70E243550C70,0x95043eC349476B413eF5c369c4d2454a1a65eaB9], 0xC780A70C45b84ae880a14E60A724579504447bcb, 0x60f89041bf199A112980ad221971fc47c5D7BE1E)
Governance address: 0x94aE5f52E401A5766b0877d2f030cFb9C3792BD7
Governance owner: 0xd15D5d0f5b1b56A4daEF75CfE108Cb825E97d015
Auto detecting admin type of 0xd15D5d0f5b1b56A4daEF75CfE108Cb825E97d015
Account has no code, assuming ownable contract.
Governance Admin Type: Direct Ownership (default)
Executing governance action...
execution reverted
Truffle v5.11.5 (core: 5.11.5)
Node v18.19.0

scroll-mainnet: ran out of funds:

$ NETWORK=scroll-mainnet; OUTPUT_FILE=tmp/1.9.1/$NETWORK.addrs npx truffle exec --network $NETWORK ops-scripts/deploy-framework.js
Using network 'scroll-mainnet'.

truffle detected true
use truffle native environment (isTruffle) false
protocol release version: v1
======== Deploying superfluid framework ========
reset superfluid framework:  false
output file:  tmp/1.9.1/scroll-mainnet.addrs
network Type:  private
network ID:  534352
chain ID:  534352
deployer:  0xd15D5d0f5b1b56A4daEF75CfE108Cb825E97d015
app whitelisting enabled: true
truffle detected false
use truffle native environment (isTruffle) false
protocol release version: v1
Checking ERC1820 deployment at 0x1820a4B7618BdE71Dce8cdc73aAB6C95905faD24
ERC1820 is already deployed.
Using @superfluid-finance/js-sdk in a non-native Truffle environment.
                Peer dependency @truffle/contract is required.
Set default from address to the first account 0xd15D5d0f5b1b56A4daEF75CfE108Cb825E97d015
Resolver address 0xb25a19c0e7d10c8D37E5b63Ed3213b67f7ebfF80
previous versionString: 1.9.0-d3a271c988976724
new versionString:      1.9.1-54fd3865fc7f0a46
SuperfluidLoader-v1 address 0x7613030429E95cDFC76FE70f9573037068B51815
SuperfluidLoader does not need new deployment.
Superfluid.v1 address 0x0F86a21F6216c061B222c224e315d9FC34520bb7
Superfluid does not need new deployment.
Governance address 0xC2C9a709A6744816b3712D520BD314fe610AEa33
GDAv1 proxy address 0x97a9f293d7eD13f3fbD499cE684Ed4F103295a28
===== STARTING UPGRADE PHASE ======
Superfluid logic code has changed
SuperfluidLogic.new: started
SuperfluidLogic.new: done, gas used 4871303, gas price 0.51 Gwei
Superfluid new logic code address 0x777Be25F9fdcA87e8a0E06Ad4be93d65429FCb9f
ConstantFlowAgreementV1 logic code has changed
ConstantFlowAgreementV1.new: started
ConstantFlowAgreementV1.new: done, gas used 4728830, gas price 0.51 Gwei
New ConstantFlowAgreementV1 address 0x554c06487bEc8c890A0345eb05a5292C1b1017Bd
ConstantFlowAgreementV1 new logic code address 0x554c06487bEc8c890A0345eb05a5292C1b1017Bd
InstantDistributionAgreementV1 logic code has changed
SlotsBitmapLibrary.new: started
SlotsBitmapLibrary.new: done, gas used 628833, gas price 0.51 Gwei
SlotsBitmapLibrary address 0x5Bb5908dcCC9Bb0fC39a78CfDf9e47B4C08E9521
InstantDistributionAgreementV1.new: started
InstantDistributionAgreementV1.new: done, gas used 4610365, gas price 0.51 Gwei
New InstantDistributionAgreementV1 address 0x74b57883f8ce9F2BD330286E884CfD8BB24AC4ED
InstantDistributionAgreementV1 new logic code address 0x74b57883f8ce9F2BD330286E884CfD8BB24AC4ED
GeneralDistributionAgreementV1 logic code has changed
SuperfluidPoolDeployerLibrary.new: started
SuperfluidPoolDeployerLibrary.new: done, gas used 574539, gas price 0.51 Gwei
SuperfluidPoolDeployerLibrary address 0x109412E3C84f0539b43d39dB691B08c90f58dC7c
GeneralDistributionAgreementV1.new: started
GeneralDistributionAgreementV1.new: done, gas used 5189622, gas price 0.51 Gwei
New GeneralDistributionAgreementV1 address 0xE40983C2476032A0915600b9472B3141aA5B5Ba9
GeneralDistributionAgreementV1 new logic code address 0xE40983C2476032A0915600b9472B3141aA5B5Ba9
checking if SuperTokenFactory needs to be redeployed...
   constantOutflowNFTLogicChanged: true
   constantInflowNFTLogicChanged: true
   poolAdminNFTLogicChanged: true
   poolMemberNFTLogicChanged: true
   superTokenFactoryCodeChanged: true
   superTokenLogicCodeChanged: true
SuperTokenFactory logic code has changed
   factory.getSuperTokenLogic.call()
   getting FlowNFT addrs
   getting PoolNFT addrs
Check-upgrading Flow NFTs...
ConstantOutflowNFT logic code has changed
ConstantOutflowNFT.new: started
ConstantOutflowNFT.new: done, gas used 2008389, gas price 0.51 Gwei
ConstantOutflowNFT Logic address 0xEb69Ed9143D33D5FbaD67F394456F212C65c1544
ConstantOutflowNFT new logic code address 0xEb69Ed9143D33D5FbaD67F394456F212C65c1544
ConstantInflowNFT logic code has changed
ConstantInflowNFT.new: started
ConstantInflowNFT.new: done, gas used 1835055, gas price 0.51 Gwei
ConstantInflowNFT Logic address 0x87a1aABD01dC70260C06962f27A02722A67d0574
ConstantInflowNFT new logic code address 0x87a1aABD01dC70260C06962f27A02722A67d0574
Check-upgrading Pool NFTs...
PoolAdminNFT logic code has changed
PoolAdminNFT.new: started
PoolAdminNFT.new: done, gas used 1315257, gas price 0.51 Gwei
PoolAdminNFT Logic address 0x598D5dB9902cbBd6e8Ee9CDb3A231377cdA2f018
PoolAdminNFT new logic code address 0x598D5dB9902cbBd6e8Ee9CDb3A231377cdA2f018
PoolMemberNFT logic code has changed
PoolMemberNFT.new: started
PoolMemberNFT.new: done, gas used 1516877, gas price 0.51 Gwei
PoolMemberNFT Logic address 0x9e6C7Fb511090E9A0dE0Bf6A0E5358dd90EC0432
PoolMemberNFT new logic code address 0x9e6C7Fb511090E9A0dE0Bf6A0E5358dd90EC0432
SuperTokenLogic.new: started
SuperTokenLogic.new: done, gas used 4403647, gas price 0.51 Gwei
SuperToken new logic code address 0x5f001c3915084186B9109fB9DC1E978C98F854B0
SuperTokenFactoryLogic.new: started
invalid transaction: insufficient funds for l1fee + gas * price + value
Truffle v5.11.5 (core: 5.11.5)
Node v18.19.0

from protocol-monorepo.

d10r avatar d10r commented on June 16, 2024

hiccups

  • getting past canonical SuperToken logic addresses from subgraph (for token upgrade) seems to still not work. Events not being registered?
  • verification for some contracts (those with proxy?) fails on routescan-based snowtrace (while passing with sourcify). Example:
> npx truffle run --network avalanche-fuji verify Superfluid@0xA0bCeca6565bb35A05b704A79c3A2EbEB0c057D5 
Verifying contracts on snowtrace
   Verifying Superfluid@0xA0bCeca6565bb35A05b704A79c3A2EbEB0c057D5
   Error: Compilation successful, but bytecode does not match with deployed bytecode for address 0xA0bCeca6565bb35A05b704A79c3A2EbEB0c057D5, please check your parameters: https://testnet.snowtrace.io/address/0xA0bCeca6565bb35A05b704A79c3A2EbEB0c057D5#code
   Successfully verified 1 contract(s).
Verifying contracts on sourcify
   Verifying Superfluid@0xA0bCeca6565bb35A05b704A79c3A2EbEB0c057D5
   Pass - Verified: https://sourcify.dev/#/lookup/0xA0bCeca6565bb35A05b704A79c3A2EbEB0c057D5
   Successfully verified 1 contract(s).

> npx truffle run --network avalanche-fuji verify Superfluid@0x85Fe79b998509B77BF10A8BD4001D58475D29386 --custom-proxy UUPSProxy 
Verifying contracts on snowtrace
   Verifying Superfluid@0x85Fe79b998509B77BF10A8BD4001D58475D29386
   Verifying custom proxy contract UUPSProxy at 0x85Fe79b998509B77BF10A8BD4001D58475D29386
   Verifying proxy implementation Superfluid at 0xa0bceca6565bb35a05b704a79c3a2ebeb0c057d5
   Linking proxy and implementation addresses
   Error: Compilation successful, but bytecode does not match with deployed bytecode for address 0xa0bceca6565bb35a05b704a79c3a2ebeb0c057d5, please check your parameters: https://testnet.snowtrace.io/address/0x85Fe79b998509B77BF10A8BD4001D58475D29386#code
   Successfully verified 1 contract(s).
Verifying contracts on sourcify
   Verifying Superfluid@0x85Fe79b998509B77BF10A8BD4001D58475D29386
   Verifying custom proxy contract UUPSProxy at 0x85Fe79b998509B77BF10A8BD4001D58475D29386
   Verifying proxy implementation Superfluid at 0xa0bceca6565bb35a05b704a79c3a2ebeb0c057d5
   Contract source code already verified: https://sourcify.dev/#/lookup/0x85Fe79b998509B77BF10A8BD4001D58475D29386
   Successfully verified 1 contract(s).

process improvements

  • deployment and verification were done from different machines
  • fork test can now also be used for networks using a Safe based gov owner. In this case, the calldata needs to be provided (see https://github.com/d10r/sf-test-gov-actions)
  • changed the fork test such that the sequential execution of framework update and token update can be simulated

from protocol-monorepo.

d10r avatar d10r commented on June 16, 2024

base-mainnet: transacting fails with

{"code":-32000,"message":"invalid sender"}

Seems RPC related. We're currently falling back to Alchemy.

from protocol-monorepo.

hellwolf avatar hellwolf commented on June 16, 2024

Optimism core contracts upgraded. Pending super token contracts upgrades.

from protocol-monorepo.

hellwolf avatar hellwolf commented on June 16, 2024

Base core contracts upgraded. Pending super token contracts upgrades.

from protocol-monorepo.

hellwolf avatar hellwolf commented on June 16, 2024

All optimism managed super tokens upgraded.

from protocol-monorepo.

d10r avatar d10r commented on June 16, 2024

I suggest we close this once the mainnet upgrades are executed.
scroll-sepolia is now tracked in #1906

from protocol-monorepo.

hellwolf avatar hellwolf commented on June 16, 2024

Arbitrum done:

image.png

from protocol-monorepo.

hellwolf avatar hellwolf commented on June 16, 2024

Gnosis Chain done:

image.png

from protocol-monorepo.

hellwolf avatar hellwolf commented on June 16, 2024

Avalanche-C done:

image.png

from protocol-monorepo.

hellwolf avatar hellwolf commented on June 16, 2024

BSC done:

image.png

from protocol-monorepo.

hellwolf avatar hellwolf commented on June 16, 2024

CELO done:

image.png

from protocol-monorepo.

hellwolf avatar hellwolf commented on June 16, 2024

Base done:

image.png

from protocol-monorepo.

hellwolf avatar hellwolf commented on June 16, 2024

Polygon:

image.png

image.png

image.png

from protocol-monorepo.

hellwolf avatar hellwolf commented on June 16, 2024

Scroll mainnet done:

image.png

from protocol-monorepo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.