superandroidanalyzer / dalvik Goto Github PK

Seems that there is some unknown data between the class_defs section and the data section. For example, the test file has 76,792 bytes of unknown data. We should understand what this is and try to parse it.

The Failure crate was created to replace error-chain. We should change the code to use it.

We are not taking advantage of the new Cargo.toml keywords, we should add them. This is the list of keywords we should add in the [badges] section:

• codecov = { repository = "...", branch = "master", service = "github" }: Adds Codecov coverage report for the project.
• is-it-maintained-issue-resolution = { repository = "..." }: Adds information about issue resolution time.
• is-it-maintained-open-issues = { repository = "..." }: Adds information about open issues.
• maintenance = { status = "..." }: Adds information about the current maintenance status. Options are actively-developed, passively-maintained, as-is, none, experimental, looking-for-maintainer and deprecated. I would propose experimental, but suggestions are welcome. Maybe one day we can move it to actively-developed ;)

For more information, check the Package metadata section in the Cargo documentation.

Currently we only have big integration tests (that still do not pass for not being implemented), but no tests for small element parsers. We need those to verify correctness.

Here is the tracking issue for parser implementations:

• Header
• StringIdList
• TypeIdList
• PrototypeIdList
• FieldIdList
• MethodIdList
• ClassDefList
• Map
• TypeList
• AnnotationSetList
• AnnotationSet
• ClassData
• Code - No bytecode parsing yet.
• StringData
• DebugInfo
• Annotation
• EncodedArray
• AnnotationsDirectory

New in version 038:

• call_site_id_item
• method_handle_item
• Values for method handles and method types.

nom is a parser combinator crate which makes parsing binary formats quite easy.

I was thinking about starting a dex parser using it, but your project already exists so it’d be better to just contribute; if you are fine with this new dependency I will try to migrate the existing parsers.