sunnyjaycer / stream-rebounder Goto Github PK

Changes

• There is an emergency close stream function, but an emergency withdraw function may also be a good idea. Otherwise funds streamed to a jailed app will still be lost.

• To remove the need to "lock" the contract, I would use host.isAppJailed(address(this)); instead to assert the app is not jailed on creates and updates.

• Poison Super Tokens can jail app AND can be valid on the super token factory. PoC PR to follow.

Some comments:

• Remove unused imports:

  stream-rebounder/contracts/StreamRebounder.sol

  Line 4 in 2247e50

  import "hardhat/console.sol";

There are more imports not used.

• Can we use the custom errors pattern?

• Don't think this is necessary, always mirror incoming stream.

  stream-rebounder/contracts/StreamRebounder.sol

  Line 25 in 2247e50

  mapping(address => int96) public flowRates;

• Outside testnets we need to give a key, maybe using the pattern if key is given use it, if not default to this method call.

  stream-rebounder/contracts/StreamRebounder.sol

  Line 47 in 2247e50

  host.registerApp(configWord);

• I think if the user closes receiving stream we should respond by closing incoming stream, and not try to be sticky.

  stream-rebounder/contracts/StreamRebounder.sol

  Line 141 in 2247e50

  newCtx = cfaV1Lib.createFlowWithCtx(_ctx, receiver, _superToken, flowRates[receiver]);

• Unneeded assert
  

  stream-rebounder/contracts/StreamRebounder.sol

  Line 32 in 2247e50

  assert(address(host) != address(0));

If Host is address zero, will revert when init CFA Library