sumo-mbryant / linux-ftools Goto Github PK

See man 3 sprintf, first argument is a buffer, not format string.
Patch attached. Also squeeze the output (should squeeze even more), open files 
read-only, do not call mmap on empty files and directories (it will fail 
anyway), put the file name in the summary at the end so that the table stays 
aligned with long paths too.

Hello!
I've tryed to build linux-ftools into Debian Lenny amd64 package and met issue:
parsechangelog/debian: warning:     debian/changelog(l4): found start of entry 
where expected more change data or trailer
LINE: linux-ftools (1.0.0) unstable; urgency=low
parsechangelog/debian: warning:     debian/changelog(l4): found eof where 
expected more change data or trailer
Use of uninitialized value $v in pattern match (m//) at 
/usr/share/perl5/Dpkg/Fields.pm line 229, <STDIN> line 4.
Use of uninitialized value $v in pattern match (m//) at 
/usr/share/perl5/Dpkg/Fields.pm line 229, <STDIN> line 4.
dpkg-buildpackage: source package linux-ftools
dpkg-buildpackage: source version 1.1.0
dpkg-buildpackage: error: unable to determine source changed by

So I've fixed debian/changelog & debian/control, patch is below:
builder@builder-lenny-amd64:~/hgs/linux-ftools$ hg diff -r 336 -r 344
diff -r ab53cc4019c1 -r 272f03b0084e debian/changelog
--- a/debian/changelog  Wed Feb 09 16:03:50 2011 -0800
+++ b/debian/changelog  Tue May 10 11:35:06 2011 +0000
@@ -1,6 +1,8 @@
 linux-ftools (1.1.0) stable; urgency=high
   * Fixed a number of bugs and package is now stable

+ -- root <[email protected]>  Sun, 21 Nov 2010 04:58:07 +0000
+
 linux-ftools (1.0.0) unstable; urgency=low

   * Initial Release.
diff -r ab53cc4019c1 -r 272f03b0084e debian/control
--- a/debian/control    Wed Feb 09 16:03:50 2011 -0800
+++ b/debian/control    Tue May 10 11:35:06 2011 +0000
@@ -1,5 +1,5 @@
 Source: linux-ftools
-Section: unknown
+Section: admin
 Priority: extra
 Maintainer: Kevin Burton <[email protected]>
 Build-Depends: debhelper (>= 7), autotools-dev

What steps will reproduce the problem?
1. Run linux-fincore on a file >2GB on a 32-bit system

What is the expected output? What do you see instead?

I see the error "Could not open file: File too large"

What version of the product are you using? On what operating system?

hg latest.

Patch attached

What steps will reproduce the problem?
1. gcc fallocate.c 
2. ./a.out file.txt 10000000
3. ls -al

What is the expected output? What do you see instead?
upon ls -al the size should be increased by 10000000. Instead the file size 
remains same as it was before executing falloc.

What version of the product are you using? On what operating system?
linux 3.4 kernel ext4

Please provide any additional information below.
Please have look at the attached file depicting commands i have execute.Am i 
doing something wrong.

Hello,

Is this project dead? I've been having problems building from source. I think 
these are mainly down to a few changes in build tools since this was written. I 
have included these below. I'd like to gte these working as they do look super 
useful!


What steps will reproduce the problem?

hg clone https://code.google.com/p/linux-ftools/
cd linux-ftools
./configure
make


<pre>
CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/sh 
/home/rcampbel/src/linux-ftools/missing --run aclocal-1.11 
/home/rcampbel/src/linux-ftools/missing: line 54: aclocal-1.11: command not 
found
WARNING: `aclocal-1.11' is missing on your system.  You should only need it if
         you modified `acinclude.m4' or `configure.ac'.  You might want
         to install the `Automake' and `Perl' packages.  Grab them from
         any GNU archive site.
 cd . && /bin/sh /home/rcampbel/src/linux-ftools/missing --run automake-1.11 --gnu
/home/rcampbel/src/linux-ftools/missing: line 54: automake-1.11: command not 
found
WARNING: `automake-1.11' is missing on your system.  You should only need it if
         you modified `Makefile.am', `acinclude.m4' or `configure.ac'.
         You might want to install the `Automake' and `Perl' packages.
         Grab them from any GNU archive site.
CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/sh 
/home/rcampbel/src/linux-ftools/missing --run autoconf
configure.ac:7: error: possibly undefined macro: AM_INIT_AUTOMAKE
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
make: *** [configure] Error 1
</pre>

autoreconf
make

<pre>
./configure: line 2202: syntax error near unexpected token `linux-ftools,'
./configure: line 2202: `AM_INIT_AUTOMAKE(linux-ftools, 1.3.0)'
</pre>

vi configure.ac

<pre>
AC_INIT([linux-ftools], [1.3.0], BUG-REPORT-ADDRESS)
AC_CONFIG_SRCDIR([linux-fincore.c])
AM_INIT_AUTOMAKE([linux-ftools], [1.3.0])
</pre>

Changed to...

<pre>
AC_INIT([linux-ftools], [1.3.0])
AC_CONFIG_SRCDIR([linux-fincore.c])
AM_INIT_AUTOMAKE
</pre>

make

<pre>
CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/sh 
/home/rcampbel/src/linux-ftools/missing --run aclocal-1.11 
/home/rcampbel/src/linux-ftools/missing: line 54: aclocal-1.11: command not 
found
WARNING: `aclocal-1.11' is missing on your system.  You should only need it if
         you modified `acinclude.m4' or `configure.ac'.  You might want
         to install the `Automake' and `Perl' packages.  Grab them from
         any GNU archive site.
 cd . && /bin/sh /home/rcampbel/src/linux-ftools/missing --run automake-1.11 --gnu
/home/rcampbel/src/linux-ftools/missing: line 54: automake-1.11: command not 
found
WARNING: `automake-1.11' is missing on your system.  You should only need it if
         you modified `Makefile.am', `acinclude.m4' or `configure.ac'.
         You might want to install the `Automake' and `Perl' packages.
         Grab them from any GNU archive site.
CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/sh 
/home/rcampbel/src/linux-ftools/missing --run autoconf
configure.ac:7: error: possibly undefined macro: AM_INIT_AUTOMAKE
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
make: *** [configure] Error 1
</pre>

libtoolize --force
make

<pre>
/bin/sh ./config.status --recheck
running CONFIG_SHELL=/bin/sh /bin/sh ./configure --no-create --no-recursion
./configure: line 2195: AM_INIT_AUTOMAKE: command not found
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking how to run the C preprocessor... gcc -E
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking fcntl.h usability... yes
checking fcntl.h presence... yes
checking for fcntl.h... yes
checking for stdlib.h... (cached) yes
checking for string.h... (cached) yes
checking sys/time.h usability... yes
checking sys/time.h presence... yes
checking for sys/time.h... yes
checking for unistd.h... (cached) yes
checking for stdbool.h that conforms to C99... yes
checking for _Bool... yes
checking for size_t... yes
checking for struct stat.st_blksize... yes
checking for struct stat.st_blocks... yes
checking for stdlib.h... (cached) yes
checking for GNU libc compatible malloc... yes
checking for stdlib.h... (cached) yes
checking for unistd.h... (cached) yes
checking for sys/param.h... yes
checking for getpagesize... yes
checking for working mmap... yes
checking for getpagesize... (cached) yes
checking for memset... yes
checking for munmap... yes
checking for strtol... yes
configure: creating ./config.status
 /bin/sh ./config.status
config.status: creating Makefile
Makefile:16: *** missing separator.  Stop.
</pre>


What is the expected output? What do you see instead?

See above


What version of the product are you using? On what operating system?

CentOS 7 64 Bit in Virtualbox


Please provide any additional information below.

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?


Please provide any additional information below.

just use unistd.h

Allow build on both Debian and RHEL - unistd_64.h is debian specific. unistd.h 
has a ifdef that selects the right distribution specific file.

I'd suggest to change building instructions on debian to be:
= Making Debian packages

apt-get install autoconf automake fakeroot debhelper dpkg-dev
dpkg-buildpackage -I'.git' -I'.svn' -I'.hg' -i -sd -us -uc -rfakeroot