sukiwp / suki Goto Github PK

Just a minor issue as screenshot

The button Scroll to Top will not work if I choose the option "static" display.

I've setup a Suki-based theme locally. I don't want / need to export my whole local code+DB, just the Suki theme settings. I am aware there's an Suki import (plugin) but is there also an export?

If there's not a formal export process, what are the WP option (table) key names that I should look for? Worst case, maybe I can do a manual copy from one DB to the other?

Or maybe there's a way for me to piggy-back on the import plugin?

p.s. Ultimately, I'd be interested in a way of doing the settings via a PHP file. That is, instead of fumbling around in the customizer, I could pre-define the settings via PHP and import that as my own set of defaults (instead of the "generic" Suki defaults). To some extent, this would also serve as a backup for the theme (in case the client muck it up I can restore the theme back to where it started without having to mess with the entire DB).

Thanks in advance for your help.

• not able to translate search placeholder because default text domain is "default". Maybe override default search form in theme can solve the issue

• the woocommerce buttons like add to cart, place order and update cart are not inheriting the border-style and color from the customizer default button settings
  add to cart, View cart, checkout, proceed to checkout tidak ikut warna button global.
  add to cart and proceed to checkout button can be change from customizer > woocommerce > alt button (but the default value of alt button on hover doesn't work). If you change to other color, the hover color works. if you set back the hover color to default (default button click), customizer live preview shows the correct color (default) but if you refresh the page or go to the page, the hover color setting doesn't work (using woocommerce default color). View cart and checkout button in pop up mini cart are not inheriting the color from global button setting neither woocommerce alt button setting.

• cart table on mobile: certain table rows have a double border because the td as well as the table has a border set in the css

• dropdown cart menu is not align properly
  it happened if subtotal translated text and the total amount is too long. It can be solved with custom css min-width. another issue is the product title will through the product image.

Customizer set border radius of general element > button but the css generate rule border width.

Implement realistic content width in Gutenberg editor.

When a user selects content layout, Gutenberg editor should display the real content width.

Since file_get_contents is not allowed in theme codes (Theme Check) and the only possible way to get the SVG codes out of SVG icon files is using WP_Filesystem.

Loading WP_Filesystem on frontend seems like a performance hindrance.

That's why we need to use a more direct technique for better performance. One that is easiest to do is putting all SVG icons' content in an array (just like what Twenty Nineteen and Twenty Twenty do).

What's need to do:

• Change the gulp vendors task to print SVG file content instead of copying the files into assets/icons directory.
• Deprecate suki/frontend/svg_icon_path filter, because we no longer access the icon files.
• Change the suki_icon render function to adapt this new technique.
• Check Suki Pro's Custom Icons compatibility.

Currently, all template rendering is done via overridable functions.

To make further development (via Child Theme) easier, we might need to use get_template_part instead of overridable functions.

This way, a Child Theme developer can easily override template parts just by creating a template file on the Child Theme with the same folder path as the Parent Theme.

Need to do:

• Porting all existing template functions into separate partial template files
• Check and review all template filters and see if all of them are working well

In the header builder the inactive elements are not shown. The title "Inactive elements" is displayed, but nothing underneath.

Hi guys, I just uploaded the first beta version of v1.3.0, which is a huge update for us. You can download the first beta here: https://github.com/sukiwp/suki/releases/download/1.3.0-beta/suki-1.3.0-beta.zip

THIS IS NOT A PRODUCTION VERSION, Please only use for testing, not for live websites.

Changelog:

• NEW: Hero Section - Replace the former "Page Header" section.
• NEW: Dedicated Single Post Page options (formerly uses the same layout as "Default" post layout for archives page).
• NEW: Dedicated Single Static Page options (formerly uses the same layout as "Default" post layout for archives page).
• NEW: Native breadcrumb module.
• NEW: Header Elemets — Add new options to show Shopping Cart's amount and its responsive visibility.
• NEW: Social Icons — Add more social icons: WordPress, Messenger, Skype, Slack, Telegram, WhatsApp, GitLab, Bitbucket.
• NEW: Sidebar - Add new option to set widget title tag (h2 / h3 / h4 / div) for custom SEO needs.
• NEW: Footer Widgets Bar - Add new option to set widget title tag (h2 / h3 / h4 / div) for custom SEO needs.
• NEW: Gutenberg - Add new theme supports for Gutenberg features: theme font sizes, custom line height, custom units, custom cover block padding, custom link color.
• NEW: Footer Elements — Add new element: HTML (accepts HTML tags and shortcode).
• NEW: Border radius and Box shadow options for posts layout, sidebar.
• NEW: WPML Compatibility - Add WPML configuration file (wpml-config.xml) for automatic WPML integration.
• TWEAK: Header Elements — SVG Logo now will be displayed using <img> tag instead of the inline SVG method. This will prevent display issue when both desktop and mobile SVG logo contain elements with same ID (e.g. gradient fill effect).
• TWEAK: Header Elements — Improve header's Shopping Cart template (If you overrode this template via Child Theme, please review the template again).
• TWEAK: Header Elements — Allow "Shopping Cart Dropdown" inside the mobile header bar.
• TWEAK: Header Builder — Improve header menu javascript to support full width Mega Menu (available since Suki Pro v1.2).
• TWEAK: Social Icons — Update some existing social icons.
• TWEAK: Social Icons — Add hidden label on each social icon for better accessibility.
• TWEAK: Social Icons — Remove Google+.
• TWEAK: Google Fonts — Update Google Fonts list.
• TWEAK: WooCommerce compatibility — Improve mini cart widget's buttons CSS (make each button full width for better compatibility with longer text in non-english languages).
• TWEAK: Elementor compatibility — Move compatibility CSS to standalone inline CSS.
• TWEAK: Customizer — Improve Customizer UI & UX.
• TWEAK: Theme Dashboard — Improve theme dashboard layout for better compatibility with Suki Pro's White Label module. Now user won't see "pro" badges and links to our website on the modules manager.
• TWEAK: Deprecate "Page Header" section.
• FIX: Header — Shopping cart dropdown toggle does nothing on Cart and Checkout pages. Now it works like a link to the Cart page.
• FIX: WooCommerce — "My Account" page's navigation links color doesn't follow the global link color configured in Customizer.
• FIX: Elementor Pro compatibility — Elementor Pro's WooCommerce products grid CSS conflict with theme's CSS.
• FIX: Customizer Preview Frame size for Tablet and Mobile modes.

TODO:

• Improve Customizer UX to prevent ambiguous options.
• Provide fallback compatibility for Suki Pro 1.1.x version.
• Check migration from "Page Header" to Hero Section.
• Fix any possible bugs.

When enabling the second image, it's stretches to 100% height, 100% width.

Default behaviour could be to set it to cover:

.woocommerce ul.products li.product .suki-product-thumbnail.suki-product-thumbnail-alt-hover-image a img:nth-child(2) {
object-fit: cover;
}

The comment is out of the screen.

Add padding option to the Page Canvas layout. This will allow user to make "padded full width layout".

The Woocommerce breadcrumb structure on archives is not correct. It is displaying the categories/subcategories first, then "Home", and then "Shop". "Home" should be first, then "Shop", and then the category/subcategory,

This has been asked by many users.

A global Page Settings in the Customizer for Pages.

Hey David - I was thinking more about (a previous issue I added) the customizer setting and my friction points as a designer /developer (as opposed to someone who needs the customizer).

Might there be SASS files for what the customize produces?

For example, currently, if the style guide (formal or informal) I'm working off of has a primary color and that color changes, then I need to find / remember all the place in the customizer it's used. Instead, if there were SASS files, I could update the $primary-color value and it would cascade. Mind you, I get it, I'd have to assign the $variables to the properties (as I would in the customizer), I get that :) But even that for me is easier than driling up and down and around in the customizer. Sometimes I get dizzy from that :)

Funny, this is similar to the discussion about headings and font sizes. Ultimately, I'm using the a layer of abstraction, which can add an extra layer - of confusion? - to the customizer. I think I saw something about a future color pallet feature. Maybe that'll help? But I think I'd still like to have the SASS, if it's avaiilable. Or even just all the CSS the customizer might render. I can reverse engineer the SASS from that, I hope :)

I looks like Suki style.css is being enqueue'd and since it's empty, it doesn't need to be. Or maybe it does, and I don't yet understand why :)

Yeah. Minor. But I noticed it and figured it was worth mentioning.

• the hero section does not work (no page title is displayed)
• the off canvas cart does not work properly when used with "show on header after succeed)

Hi,

It would be nice to have elements for phone and e-mail (like social). So you can add them easily to the header or footer. What do you think about it?

The font path is specified as "../../../../../../plugins/woocommerce/assets/fonts/star.eot"
The problem is that the name of the plugins folder may have a different name, defined through the constants WP_PLUGIN_DIR, WP_PLUGIN_URL.

Any time I create a page with Page Builder plugin as Elementor, Brizy, etc the backend change font-family and font-size. It is weird.

Screenshot: https://cl.ly/7ef687

Brizy doesn't allow users to change its maximum content width. It's always set to 1170px. It would be useful if users can use the theme's container width (as configured on Customize > Page Canvas & Wrapper > Container Width) as Brizy maximum content width.

This feature should be optional and configurable from Customizer.

https://web.dev/content-visibility/

We can speed up the rendering process using "content-visibility" CSS. However "content-visibility" is currently only supported by Chromium browsers. https://caniuse.com/css-content-visibility

Hi David,
I got this warnings when I have Suki theme active in my local env (using PHP 8.0.6):

Warning: Private methods cannot be final as they are never overridden by other classes in E:\www\mapsteps-ms\wp-content\themes\suki\inc\class-suki.php on line 46

Warning: Private methods cannot be final as they are never overridden by other classes in E:\www\mapsteps-ms\wp-content\themes\suki\inc\class-suki.php on line 51

Warning: The magic method Suki::__wakeup() must have public visibility in E:\www\mapsteps-ms\wp-content\themes\suki\inc\class-suki.php on line 51

Should be easy to fix though. Just letting you know so that you can prepare Suki for PHP 8.

Thanks :)

If I choose Contained Section for Bottom Bar, in mobile it is blank.

https://cl.ly/512258 (mobile view)
https://cl.ly/d319a2 (desktop view - it's fine)

URL for check: https://askusecase.com

Full-width works fine. I get edge to edge.

Alignment: Left, center and right, all seem fine as well.

But alignment: Wide width isn't even full width of the main content container/wrapper. There a class alignwide for the

I'll fix mine on my own, but I wanted to let you know.

wp-content/plugins/suki-pro/inc/class-suki-pro-notice.php line 119 has an error regarding array_push requiring two options

Would it be possible to add a filter to the add_meta_box function on the priority so on could set it to low via a function in the child theme? Would be great when using ACF and classic editor.

something like this on line 108 in class-suki-admin-metabox-page-settings.php
apply_filters( 'suki_metabox_prio', 'high' )

The front-end and login users are seeing the post differently because of font style are not match.

Preview feature is the same case that I cannot see correctly how the site shows visitors.

For better UX, when there is no element left in the inactive panel, we need to hide the "(+) add" icon.

When doing products search, the title in the page header (title bar) doesn't show "Search results for" but "Shop" text instead.

In the master version, globally disabling the hero section does not work. It is still being displayed.

the blog posts are not being displayed when you choose them to be displayed on your homepage (in the "general settings" from WP).

There's something wrong with the focus event.

Suki: Version: 1.0.14

Using the blog grid view the title is wrapped in an h2 tag, but the class="entry-small-title h3" I presume that h3 class should be an h2.

Add built-in social links widget with simple styles.

Specifications:

• Users can choose what icons to display.
• Users can sort the icons.
• Users can specify each social link URL (or use global settings on Customizer).
• Users can set the link to open in a new tab.
• No style options, that means icon size and gap is defined by default on theme CSS.
• No color options, social links will inherit sidebar's link colors.

If you share a features roadmap, more people can help this project.

For the fonts being used, I'm only using a couple styles for each. For example, for the heading font, we're only using bold.

I suppose I can de-enqueue Suki's font enqueue'ing, and then roll my own - less heavy version - but maybe there's something already baked into Suki (that I can't find).

Your thoughts / insights would be appreciated. tia

If I type #f3f the color pickers autocompletes to #ff33ff, but I wanted to type #f3f3f3. It's very annoying :/

The function suki_entry_meta() in this file

https://github.com/sukiwp/suki/blob/master/inc/template-tags.php

is not plugable because it's wrapped by this conditional:

if ( ! function_exists( 'suki_entry_header_meta' ) ) :

I'd call this a significant bug because plugging suki_entry_header_meta() means that suki_entry_meta() will also go MIA.

Mind you, I get it, you'd think someone would have plugged suki_entry_header_meta() at some point but I guess not :)

When a product has a rating or longer text the product block height is not the same.

This only happens if "Add to cart" setting is enabled. I tried to find a solution but couldn't get it to work.

Since the update to Suki 1.2.9 opening the submenu on a mobile device does not work anymore. There is a script error.

main.min.js?ver=1.2.9:1 Uncaught ReferenceError: duration is not defined
at Object.slideDown (main.min.js?ver=1.2.9:1)
at HTMLDocument.e (main.min.js?ver=1.2.9:1)

Hi,

Why can we only enable/disable pro elements and not the ones in the free version?

For example: I like to disable google fonts elements. This is not possible (greyed out).

There might be a reason why you did that. But, it would be great if we could also enable/disable the default elements in the dashboard.

Thanks!

When Page Header is activated, the blog post title would be moved inside the Page Header but the post header meta becomes disappeared.

Post header meta should also be displayed along with post title inside the Page Header section.

The post title won't hide when I select it in the Customizer, using the Gutenberg editor.

This happens on a clean, newly installed WP install.

Suki should have modified the original WooCommerce CSS instead of overriding using an additional CSS file.

This method could improve performance:

• Reduce HTTP requests
• Smaller CSS file

Current behavior:

• Clicking the parent menu item won't open the sub-menus.
• User needs to click the dropdown sign to open the sub-menus.
• The dropdown sign is way off to the right side of the menu item when the vertical header bar is wide.

Possible solution:

• Move the dropdown sign next to the menu item label.