sui-components / frontend-pre-commit-rules Goto Github PK

DEPRECATED: Use https://github.com/SUI-Components/sui/tree/master/packages/sui-precommit instead - A set of rules to add consistency to your code.

Home Page: https://schibsted-engineers.gitbooks.io/frontend-pre-commit-rules/content/

JavaScript 100.00%

frontend-pre-commit-rules's Introduction

SUI React Components

SUI Components is an Open-Source, high quality library of React components that empowers teams to craft any product with ease.

⚙️ Minimum requirements

🖥 Environment Support

Modern browsers and Internet Explorer 11+ (with polyfills)
Server-Side Rendering

🧪 Test Coverage

✨ Features

Well-tested, production ready presentational React components.
Isolated components. Each component is a package.
Customizable components using variables.

frontend-pre-commit-rules's People

Contributors

Stargazers

Watchers

Forkers

nahuelsotelo javifelices cristiancedenogallego carloscuatin sui-framework twjmgorduez

frontend-pre-commit-rules's Issues

.babelrc shouldn't be copied if already exists.

It's not compatible with Babel 6, and it's overwriting the one generated by the sui-generator.

Installation failure with npm install (windows environment: command line / gitbash)

francisco.delacasa@AFE0804002 MINGW64 /c/GitProjects/re-home-search (feature/doc_revision)
$ npm i
npm WARN package.json @schibstedspain/[email protected] No license field.

> @schibstedspain/[email protected] install C:\GitProjects\re-home-search\node_modules\@schibstedspain\frontend-pre-commit-rules
> node bin/install.js

fs.js:500
  return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode);
                 ^
Error: ENOENT, no such file or directory 'C:\GitProjects\re-home-search\.git\hooks\pre-commit'
    at Error (native)
    at Object.fs.openSync (fs.js:500:18)
    at Object.fs.writeFileSync (fs.js:1099:15)
    at Object.exports.installHooks (C:\GitProjects\re-home-search\node_modules\@schibstedspain\frontend-pre-commit-rules\node_modules\git-validate\lib\utils.js:234:12)
    at Object.<anonymous> (C:\GitProjects\re-home-search\node_modules\@schibstedspain\frontend-pre-commit-rules\bin\install.js:10:10)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Function.Module.runMain (module.js:501:10)
npm ERR! Windows_NT 6.3.9600
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "i"
npm ERR! node v0.12.4
npm ERR! npm  v2.10.1
npm ERR! code ELIFECYCLE

npm ERR! @schibstedspain/[email protected] install: `node bin/install.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the @schibstedspain/[email protected] install script 'node bin/install.js'.
npm ERR! This is most likely a problem with the @schibstedspain/frontend-pre-commit-rules package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node bin/install.js
npm ERR! You can get their info via:
npm ERR!     npm owner ls @schibstedspain/frontend-pre-commit-rules
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     C:\GitProjects\re-home-search\npm-debug.log

Change "react/jsx-quotes"

This rule is deprecated and breaks the linter since eslint version 4.0.0. We must change it to "jsx-quotes": [2, "prefer-single"],

Need to increase value of property NestingDepth

NestingDepth: 4 Proposal

In order to be able to overwrite css properties sometimes we need to create deeper nesting structures specially when we have:

.re-component {
   .sui-subcomponent {
      .a {
         &:hover {
           // hover states are an example;
         }
      }
   }
}

Roll back fileNameExtension rule in scss-lint.yml

It's not needed anymore to specify the filename extension when importing .scss files with the latest version of the generator.

7e90884#diff-e9419947d819494941dc8d981f0e128c

IMHO we should let the usage of double quotes for string instead banning them. They are useful when we want to use the single quote inside the string. Without using doubles we have to escape anytime we need the simple quote, like apostrophes or English contractions.

I agree with lowering the level of alert from error to warning and see if we require them in the sentence. In Spanish we shouldn't use them, but in Catalan or English single quote should be more accessible.

RULE: https://github.com/scm-spain/frontend-pre-commit-rules#stringquotes
INFO: https://en.wikipedia.org/wiki/Quotation_mark